November 2022 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: virt_phy: configure.ac: add --enable-werror

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30014 ) Change subject: virt_phy: configure.ac: add --enable-werror ...................................................................... virt_phy: configure.ac: add --enable-werror Change-Id: I081ae20bfc6ed5f2906756a956b9fba0ae8e55f1 --- M src/host/virt_phy/configure.ac 1 file changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/14/30014/1 diff --git a/src/host/virt_phy/configure.ac b/src/host/virt_phy/configure.ac index fbff2c1..97c2e19 100644 --- a/src/host/virt_phy/configure.ac +++ b/src/host/virt_phy/configure.ac @@ -33,6 +33,28 @@ CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined" fi +AC_ARG_ENABLE(werror, + [AS_HELP_STRING( + [--enable-werror], + [Turn all compiler warnings into errors, with exceptions: + a) deprecation (allow upstream to mark deprecation without breaking builds); + b) "#warning" pragmas (allow to remind ourselves of errors without breaking builds) + ] + )], + [werror=$enableval], [werror="no"]) +if test x"$werror" = x"yes" +then + WERROR_FLAGS="-Werror" + WERROR_FLAGS+=" -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition" + WERROR_FLAGS+=" -Wno-error=deprecated -Wno-error=deprecated-declarations" + WERROR_FLAGS+=" -Wno-error=cpp" # "#warning" + CFLAGS="$CFLAGS $WERROR_FLAGS" + CPPFLAGS="$CPPFLAGS $WERROR_FLAGS" +fi + +AC_MSG_RESULT([CFLAGS="$CFLAGS"]) +AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"]) + AC_CONFIG_FILES([ Makefile include/Makefile -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30014 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I081ae20bfc6ed5f2906756a956b9fba0ae8e55f1 Gerrit-Change-Number: 30014 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: virt_phy: support building with -Werror

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30013 ) Change subject: virt_phy: support building with -Werror ...................................................................... virt_phy: support building with -Werror Change-Id: Iccd2575faadee1ad3982466bf6a07fa5d52b0250 --- M src/host/virt_phy/src/l1ctl_sap.c M src/host/virt_phy/src/virtphy.c 2 files changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/13/30013/1 diff --git a/src/host/virt_phy/src/l1ctl_sap.c b/src/host/virt_phy/src/l1ctl_sap.c index a0e8c0c..35370f0 100644 --- a/src/host/virt_phy/src/l1ctl_sap.c +++ b/src/host/virt_phy/src/l1ctl_sap.c @@ -580,6 +580,7 @@ l1ctl_tx_tbf_cfg_conf(ms, cfg_req); } +#if 0 static const enum osmo_gprs_cs osmo_cs_by_l1ctl[] = { [L1CTL_CS_NONE] = OSMO_GPRS_CS_NONE, [L1CTL_CS1] = OSMO_GPRS_CS1, @@ -603,6 +604,7 @@ return -1; return osmo_cs_by_l1ctl[l1]; } +#endif static const enum l1ctl_coding_scheme l1ctl_cs_by_osmo[] = { [OSMO_GPRS_CS_NONE] = L1CTL_CS_NONE, diff --git a/src/host/virt_phy/src/virtphy.c b/src/host/virt_phy/src/virtphy.c index 412da9c..f2b8e5d 100644 --- a/src/host/virt_phy/src/virtphy.c +++ b/src/host/virt_phy/src/virtphy.c @@ -62,12 +62,12 @@ static char *mcast_netdev = NULL; static int mcast_ttl = -1; -static void print_usage() +static void print_usage(void) { printf("Usage: virtphy\n"); } -static void print_help() +static void print_help(void) { printf(" Some useful help...\n"); printf(" -h --help This text.\n"); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30013 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iccd2575faadee1ad3982466bf6a07fa5d52b0250 Gerrit-Change-Number: 30013 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: configure.ac: add --enable-werror

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30012 ) Change subject: trxcon: configure.ac: add --enable-werror ...................................................................... trxcon: configure.ac: add --enable-werror Change-Id: Id9b561f59599e5eb0267e3baaa33bf9cdde22ea3 --- M src/host/trxcon/configure.ac 1 file changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/12/30012/1 diff --git a/src/host/trxcon/configure.ac b/src/host/trxcon/configure.ac index 46991a2..554caab 100644 --- a/src/host/trxcon/configure.ac +++ b/src/host/trxcon/configure.ac @@ -32,6 +32,28 @@ CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined" fi +AC_ARG_ENABLE(werror, + [AS_HELP_STRING( + [--enable-werror], + [Turn all compiler warnings into errors, with exceptions: + a) deprecation (allow upstream to mark deprecation without breaking builds); + b) "#warning" pragmas (allow to remind ourselves of errors without breaking builds) + ] + )], + [werror=$enableval], [werror="no"]) +if test x"$werror" = x"yes" +then + WERROR_FLAGS="-Werror" + WERROR_FLAGS+=" -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition" + WERROR_FLAGS+=" -Wno-error=deprecated -Wno-error=deprecated-declarations" + WERROR_FLAGS+=" -Wno-error=cpp" # "#warning" + CFLAGS="$CFLAGS $WERROR_FLAGS" + CPPFLAGS="$CPPFLAGS $WERROR_FLAGS" +fi + +AC_MSG_RESULT([CFLAGS="$CFLAGS"]) +AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"]) + dnl Checks for typedefs, structures and compiler characteristics AC_CONFIG_MACRO_DIRS([m4]) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30012 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id9b561f59599e5eb0267e3baaa33bf9cdde22ea3 Gerrit-Change-Number: 30012 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ggsn: Parametrize T3-RESPONSE and N3-REQUESTS

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30007 ) Change subject: ggsn: Parametrize T3-RESPONSE and N3-REQUESTS ...................................................................... ggsn: Parametrize T3-RESPONSE and N3-REQUESTS Since osmo-ggsn.git Ia15c1cfd201d7c43e9a1d6ceb6725ddf392d2c65 osmo-ggsn supports configuration of X3 timer, which should be set to (T3-RESPONSE * N3-REQUESTS) configured at the peer. The default values are 5 and 3 respectively, hence X3 is by default 5*3=15 seconds. Let's use that default value for now. Once new osmo-ggsn version is released, we can speed up test duration by decreasing the values of the module parameters introduced in this commit and configure VTY gtp timers at osmo-ggsn accordingly. Related: OS#5485 Change-Id: I02c0982674b43317a5fc8f341c03eeeb1efee77f --- M ggsn_tests/GGSN_Tests.ttcn 1 file changed, 7 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index 21fdec7..6cc9732 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -77,6 +77,8 @@ * The tests expect to be able to send ping packets between any two simulated MS within the same * address range. This requires IP forwarding to be enabled on the corresponding tun interfaces. */ + integer mp_t3_response := 5; /* local T3-RESPONSE timeout, seconds */ + integer mp_n3_requests := 3; /* local N3-REQUESTS counter */ GGSN_Impl m_ggsn_impl := GGSN_IMPL_OSMOCOM; } @@ -296,13 +298,13 @@ } function f_shutdown_helper() runs on GT_CT { - /* Sleep N3_REQUESTS * T3_REQUEST seconds, nowadays 5*3=15s. + /* Sleep (T3-RESPONSE * N3-REQUESTS) seconds. * This ensures all retransmit queues are cleared before jumping * into next tests, hence avoding situation where a test resuses * a seqnum still in the GGSN's resp queue (dup req detector). * See OS#5485 avout decreasing time. We could also add a new * VTY command that calls gtp_clear_queues() */ - f_sleep(15.0); + f_sleep(int2float(mp_t3_response * mp_n3_requests)); setverdict(pass); } @@ -2090,16 +2092,15 @@ } - /* Send a duplicate echo req. osmo-ggsn maintains a queue for sent - responses (60 seconds): If same delete req is sent and duplicate is - detected, saved duplicate response should be sent back. */ + /* Send a duplicate echo req. osmo-ggsn maintains a queue for sent responses (T3-RESPONSE * N3-REQUESTS): + * If same delete req is sent and duplicate is detected, saved duplicate response should be sent back. */ testcase TC_act_deact_retrans_duplicate() runs on GT_CT { f_init(); var PdpContext ctx := valueof(t_DefinePDP(f_rnd_imsi('26242'H), "1234", c_ApnInternet, valueof(t_EuaIPv4Dyn))); f_pdp_ctx_act(ctx); f_pdp_ctx_del(ctx, '1'B); /* leave some time in between to make sure retransmit response queue keeps packets for a while */ - f_sleep(1.0); + f_sleep(int2float(mp_t3_response)); /* g_c_seq_nr was increased during f_pdp_ctx_del(), we want a duplicate. If it was not a duplicate, osmo-ggsn would answer with a failure since that PDP ctx was already deleted. */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30007 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I02c0982674b43317a5fc8f341c03eeeb1efee77f Gerrit-Change-Number: 30007 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmo-sgsn[master]: vty: Make new libgtp tdefs configurable through VTY

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/29970 ) Change subject: vty: Make new libgtp tdefs configurable through VTY ...................................................................... vty: Make new libgtp tdefs configurable through VTY Related: OS#5485 Depends: osmo-ggsn.git Change-Id I10bc8e2e197c0e8753b23b684b5ae41025672bf7 Change-Id: I46e9cd158a9f2f721c69f807beb7bb67a459f4a4 --- M TODO-RELEASE M include/osmocom/sgsn/sgsn.h M src/sgsn/sgsn_vty.c M tests/osmo-sgsn_test-nodes.vty 4 files changed, 29 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/TODO-RELEASE b/TODO-RELEASE index 1c5d61f..21bfa66 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -1 +1,2 @@ #component what description / commit summary line +libgtp >1.9.0 gtp_T_defs \ No newline at end of file diff --git a/include/osmocom/sgsn/sgsn.h b/include/osmocom/sgsn/sgsn.h index f0eda98..f08037a 100644 --- a/include/osmocom/sgsn/sgsn.h +++ b/include/osmocom/sgsn/sgsn.h @@ -93,6 +93,7 @@ /* Timer defintions */ struct osmo_tdef *T_defs; + struct osmo_tdef *T_defs_gtp; int dynamic_lookup; diff --git a/src/sgsn/sgsn_vty.c b/src/sgsn/sgsn_vty.c index a394c41..0929f1f 100644 --- a/src/sgsn/sgsn_vty.c +++ b/src/sgsn/sgsn_vty.c @@ -136,6 +136,26 @@ return osmo_tdef_vty_set_cmd(vty, g_cfg->T_defs, argv); } +DEFUN(show_timer_gtp, show_timer_gtp_cmd, + "show timer gtp " OSMO_TDEF_VTY_ARG_T_OPTIONAL, + SHOW_STR "Show timers\n" "GTP (libgtp) timers\n" + OSMO_TDEF_VTY_DOC_T) +{ + const char *T_arg = argc > 0 ? argv[0] : NULL; + return osmo_tdef_vty_show_cmd(vty, g_cfg->T_defs_gtp, T_arg, NULL); +} + +DEFUN(cfg_sgsn_timer_gtp, cfg_sgsn_timer_gtp_cmd, + "timer gtp " OSMO_TDEF_VTY_ARG_SET_OPTIONAL, + "Configure or show timers\n" "GTP (libgtp) timers\n" + OSMO_TDEF_VTY_DOC_SET) +{ + /* If any arguments are missing, redirect to 'show' */ + if (argc < 2) + return show_timer(self, vty, argc, argv); + return osmo_tdef_vty_set_cmd(vty, g_cfg->T_defs_gtp, argv); +} + char *gprs_pdpaddr2str(uint8_t *pdpa, uint8_t len, bool return_ipv6) { static char str[INET6_ADDRSTRLEN + 10]; @@ -312,6 +332,7 @@ vty_out(vty, " cdr interval %d%s", g_cfg->cdr.interval, VTY_NEWLINE); osmo_tdef_vty_write(vty, g_cfg->T_defs, " timer "); + osmo_tdef_vty_write(vty, g_cfg->T_defs_gtp, " timer gtp "); if (g_cfg->pcomp_rfc1144.active) { vty_out(vty, " compression rfc1144 active slots %d%s", @@ -1719,6 +1740,9 @@ g_cfg->T_defs = sgsn_T_defs; osmo_tdefs_reset(g_cfg->T_defs); + g_cfg->T_defs_gtp = gtp_T_defs; + osmo_tdefs_reset(g_cfg->T_defs_gtp); + install_element_ve(&show_sgsn_cmd); //install_element_ve(&show_mmctx_tlli_cmd); install_element_ve(&show_mmctx_imsi_cmd); @@ -1726,6 +1750,7 @@ install_element_ve(&show_pdpctx_all_cmd); install_element_ve(&show_subscr_cache_cmd); install_element_ve(&show_timer_cmd); + install_element_ve(&show_timer_gtp_cmd); install_element(ENABLE_NODE, &update_subscr_insert_auth_triplet_cmd); install_element(ENABLE_NODE, &update_subscr_create_cmd); @@ -1773,6 +1798,7 @@ install_element(SGSN_NODE, &cfg_grx_ggsn_cmd); install_element(SGSN_NODE, &cfg_sgsn_timer_cmd); + install_element(SGSN_NODE, &cfg_sgsn_timer_gtp_cmd); install_element(SGSN_NODE, &cfg_no_comp_rfc1144_cmd); install_element(SGSN_NODE, &cfg_comp_rfc1144_cmd); diff --git a/tests/osmo-sgsn_test-nodes.vty b/tests/osmo-sgsn_test-nodes.vty index 7e2e3a3..22d81d2 100644 --- a/tests/osmo-sgsn_test-nodes.vty +++ b/tests/osmo-sgsn_test-nodes.vty @@ -55,6 +55,7 @@ ggsn dynamic grx-dns-add A.B.C.D timer [TNNNN] [(<0-2147483647>|default)] + timer gtp [TNNNN] [(<0-2147483647>|default)] no compression rfc1144 compression rfc1144 active slots <1-256> compression rfc1144 passive -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/29970 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I46e9cd158a9f2f721c69f807beb7bb67a459f4a4 Gerrit-Change-Number: 29970 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in libosmo-pfcp[master]: Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-def...

by fixeria

fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30011 ) Change subject: Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition ...................................................................... Abandoned Duplicate of https://gerrit.osmocom.org/c/libosmo-pfcp/+/29986. -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30011 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I0af059e89a9c63af3c73585fad94304556e2c37e Gerrit-Change-Number: 30011 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon

2 years, 7 months

1
0
0 0

Change in libsmpp34[master]: test_apps: Fix compilation of example smsc code

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/29987 ) Change subject: test_apps: Fix compilation of example smsc code ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29987 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I12f4daefaa07a1c1b42dc295724e3ec0bdcddfd7 Gerrit-Change-Number: 29987 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 04 Nov 2022 20:59:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-pfcp[master]: Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-def...

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30011 ) Change subject: Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition ...................................................................... Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition ... if --enable-werror is used Change-Id: I0af059e89a9c63af3c73585fad94304556e2c37e --- M configure.ac 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/11/30011/1 diff --git a/configure.ac b/configure.ac index 1b8436e..ba7ff86 100644 --- a/configure.ac +++ b/configure.ac @@ -68,6 +68,7 @@ if test x"$werror" = x"yes" then WERROR_FLAGS="-Werror" + WERROR_FLAGS+=" -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition" WERROR_FLAGS+=" -Wno-error=deprecated -Wno-error=deprecated-declarations" WERROR_FLAGS+=" -Wno-error=cpp" # "#warning" CFLAGS="$CFLAGS $WERROR_FLAGS" -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30011 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I0af059e89a9c63af3c73585fad94304556e2c37e Gerrit-Change-Number: 30011 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in libosmo-pfcp[master]: contrib/jenkins.sh: build with --enable-werror

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30010 ) Change subject: contrib/jenkins.sh: build with --enable-werror ...................................................................... contrib/jenkins.sh: build with --enable-werror Change-Id: I5d22083e40b5c95b2412e1dcb4aba4f023f54e23 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/10/30010/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 414a6cb..e90ffa7 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -47,7 +47,7 @@ cd "$base" autoreconf --install --force -./configure --enable-sanitize $CONFIG +./configure --enable-sanitize --enable-werror $CONFIG $MAKE $PARALLEL_MAKE LD_LIBRARY_PATH="$inst/lib" $MAKE check \ || cat-testlogs.sh -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30010 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I5d22083e40b5c95b2412e1dcb4aba4f023f54e23 Gerrit-Change-Number: 30010 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in libosmo-gprs[master]: Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-def...

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30009 ) Change subject: Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition ...................................................................... Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition ... if --enable-werror is used Change-Id: I6d37291f66afacfc2d9cb7133f7240bbf87c0003 --- M configure.ac 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/09/30009/1 diff --git a/configure.ac b/configure.ac index 84824fc..1ebd185 100644 --- a/configure.ac +++ b/configure.ac @@ -62,6 +62,7 @@ if test x"$werror" = x"yes" then WERROR_FLAGS="-Werror" + WERROR_FLAGS+=" -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition" WERROR_FLAGS+=" -Wno-error=deprecated -Wno-error=deprecated-declarations" WERROR_FLAGS+=" -Wno-error=cpp" # "#warning" CFLAGS="$CFLAGS $WERROR_FLAGS" -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30009 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I6d37291f66afacfc2d9cb7133f7240bbf87c0003 Gerrit-Change-Number: 30009 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022