October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-mgw[master]: osmux: Simplify and constify param passing
by pespin 06 Oct '22

06 Oct '22

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/29644 to look at the new patch set (#2). Change subject: osmux: Simplify and constify param passing ...................................................................... osmux: Simplify and constify param passing Parameters passed to several functions are rearrange to make code simplier to follow, as well as dependencies between the different functions. As a result, some parameters can be marked as const while doing the change. Change-Id: Idebd4a66630c16548f557632a54d6b7e1b3906fd --- M include/osmocom/mgcp/osmux.h M src/libosmo-mgcp/mgcp_osmux.c M src/libosmo-mgcp/mgcp_protocol.c 3 files changed, 24 insertions(+), 34 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/44/29644/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29644 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Idebd4a66630c16548f557632a54d6b7e1b3906fd Gerrit-Change-Number: 29644 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

Change in osmo-mgw[master]: osmux: cosmetic: Fix indentation
by fixeria 06 Oct '22

06 Oct '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29642 ) Change subject: osmux: cosmetic: Fix indentation ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29642 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic7087e7907c1078d134d7d9b11ed6a6bf1941308 Gerrit-Change-Number: 29642 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Oct 2022 11:11:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-mgw[master]: osmux: Drop unused role parameter
by fixeria 06 Oct '22

06 Oct '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29641 ) Change subject: osmux: Drop unused role parameter ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29641 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I39c2852bb60aaba4f85188c55f157e4abec47a0e Gerrit-Change-Number: 29641 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Oct 2022 11:11:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-mgw[master]: osmux: Change couple log lines to OSMUX category
by pespin 06 Oct '22

06 Oct '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29639 ) Change subject: osmux: Change couple log lines to OSMUX category ...................................................................... osmux: Change couple log lines to OSMUX category Change-Id: Ia04d08099f0b1e81707699d872779108f22522bf --- M src/libosmo-mgcp/mgcp_protocol.c 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index 46e1d6b..67a185a 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -47,6 +47,7 @@ #include <osmocom/mgcp/mgcp_codec.h> #include <osmocom/mgcp/mgcp_conn.h> #include <osmocom/mgcp/mgcp_iuup.h> +#include <osmocom/mgcp/debug.h> /* Contains the last successfully resolved endpoint name. This variable is used * for the unit-tests to verify that the endpoint was correctly resolved. */ @@ -741,10 +742,10 @@ { if (!endp->trunk->cfg->osmux_initialized) { if (osmux_init(OSMUX_ROLE_BSC, endp->trunk) < 0) { - LOGPENDP(endp, DLMGCP, LOGL_ERROR, "Cannot init OSMUX\n"); + LOGPENDP(endp, DOSMUX, LOGL_ERROR, "Cannot init OSMUX\n"); return -3; } - LOGPENDP(endp, DLMGCP, LOGL_NOTICE, "OSMUX socket has been set up\n"); + LOGPENDP(endp, DOSMUX, LOGL_NOTICE, "OSMUX socket has been set up\n"); } return mgcp_parse_osmux_cid(line); -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29639 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia04d08099f0b1e81707699d872779108f22522bf Gerrit-Change-Number: 29639 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-mgw[master]: osmux: Change couple log lines to OSMUX category
by fixeria 06 Oct '22

06 Oct '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29639 ) Change subject: osmux: Change couple log lines to OSMUX category ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29639 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia04d08099f0b1e81707699d872779108f22522bf Gerrit-Change-Number: 29639 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Oct 2022 11:09:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-mgw[master]: osmux: Add claudators around IPv6 address to distinguish port in log ...
by fixeria 06 Oct '22

06 Oct '22

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29640 ) Change subject: osmux: Add claudators around IPv6 address to distinguish port in log line ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-mgw/+/29640/comment/7d391afc_b808a8ae PS2, Line 7: claudators > I think this is not a word used in English. […] Let's keep it in the commit log for the history ;) Like we already have "b0rken timeslots" in osmo-bsc.git. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I811ac5b4386f06c224f29f44f10dce4008fa7a4f Gerrit-Change-Number: 29640 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Oct 2022 11:06:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

Build failure of network:osmocom:nightly/osmo-msc in Debian_Unstable/x86_64
by OBS Notification 06 Oct '22

06 Oct '22

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-msc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 80s] [396/517] installing libdpkg-perl-1.21.9 [ 80s] [397/517] installing libosmo-ranap-dev-1.3.0.2.a9c38.202210060052 [ 80s] [398/517] installing libpaper-utils-1.1.28+b1 [ 80s] [399/517] installing libsctp-dev-1.0.19+dfsg-2 [ 80s] [400/517] installing libsqlite3-dev-3.39.4-1 [ 80s] [401/517] installing mailcap-3.70+nmu1 [ 80s] [402/517] installing autoconf-2.71-2 [ 80s] [403/517] installing libfile-find-rule-perl-0.34-2 [ 81s] [404/517] installing lmodern-2.005-1 [ 82s] [405/517] installing sgml-data-2.0.11+nmu1 [ 83s] [406/517] installing libstdc++-12-dev-12.2.0-5 [ 83s] [407/517] installing libatk-bridge2.0-0-2.46.0-3 [ 83s] [408/517] installing libfontconfig1-2.13.1-4.5 [ 83s] Processing triggers for sgml-base (1.30) ... [ 83s] [409/517] installing libtool-2.4.7-4 [ 83s] [410/517] installing libenchant-2-2-2.3.3-1 [ 83s] [411/517] installing libpam-modules-1.5.2-3 [ 84s] dpkg: error processing archive .init_b_cache/libpam-modules.deb (--install): [ 84s] trying to overwrite '/usr/share/man/man5/namespace.conf.5.gz', which is also in package libpam-modules-bin 1.5.2-3 [ 84s] Errors were encountered while processing: [ 84s] .init_b_cache/libpam-modules.deb [ 84s] exit ... [ 84s] ### VM INTERACTION START ### [ 84s] [ 66.202040][ T1] sysrq: Power Off [ 84s] [ 66.205196][ T16] reboot: Power down [ 84s] ### VM INTERACTION END ### [ 84s] [ 84s] lamb27 failed "build osmo-msc_1.9.0.25.ba4d6.202210060052.dsc" at Thu Oct 6 11:04:47 UTC 2022. [ 84s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

1 0

Build failure of network:osmocom:latest/osmo-msc in Debian_Unstable/x86_64
by OBS Notification 06 Oct '22

06 Oct '22

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/os… Package network:osmocom:latest/osmo-msc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 93s] [396/517] installing libdpkg-perl-1.21.9 [ 94s] [397/517] installing libosmo-ranap-dev-1.3.0 [ 94s] [398/517] installing libpaper-utils-1.1.28+b1 [ 94s] [399/517] installing libsctp-dev-1.0.19+dfsg-2 [ 94s] [400/517] installing libsqlite3-dev-3.39.4-1 [ 94s] [401/517] installing mailcap-3.70+nmu1 [ 94s] [402/517] installing autoconf-2.71-2 [ 94s] [403/517] installing libfile-find-rule-perl-0.34-2 [ 94s] [404/517] installing lmodern-2.005-1 [ 96s] [405/517] installing sgml-data-2.0.11+nmu1 [ 97s] [406/517] installing libstdc++-12-dev-12.2.0-5 [ 97s] [407/517] installing libatk-bridge2.0-0-2.46.0-3 [ 97s] [408/517] installing libfontconfig1-2.13.1-4.5 [ 97s] Processing triggers for sgml-base (1.30) ... [ 97s] [409/517] installing libtool-2.4.7-4 [ 97s] [410/517] installing libenchant-2-2-2.3.3-1 [ 98s] [411/517] installing libpam-modules-1.5.2-3 [ 98s] dpkg: error processing archive .init_b_cache/libpam-modules.deb (--install): [ 98s] trying to overwrite '/usr/share/man/man5/namespace.conf.5.gz', which is also in package libpam-modules-bin 1.5.2-3 [ 98s] Errors were encountered while processing: [ 98s] .init_b_cache/libpam-modules.deb [ 98s] exit ... [ 98s] ### VM INTERACTION START ### [ 98s] [ 69.254750][ T1] sysrq: Power Off [ 98s] [ 69.260778][ T16] reboot: Power down [ 98s] ### VM INTERACTION END ### [ 98s] [ 98s] cloud136 failed "build osmo-msc_1.9.0.dsc" at Thu Oct 6 11:04:48 UTC 2022. [ 98s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

1 0

Build failure of network:osmocom:nightly/osmo-sgsn in Debian_Unstable/x86_64
by OBS Notification 06 Oct '22

06 Oct '22

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 80s] [395/516] installing intltool-debian-0.35.0+20060710.5 [ 80s] [396/516] installing libdpkg-perl-1.21.9 [ 80s] [397/516] installing libosmo-ranap-dev-1.3.0.2.a9c38.202210060052 [ 81s] [398/516] installing libpaper-utils-1.1.28+b1 [ 81s] [399/516] installing libsctp-dev-1.0.19+dfsg-2 [ 81s] [400/516] installing mailcap-3.70+nmu1 [ 81s] [401/516] installing autoconf-2.71-2 [ 81s] [402/516] installing libfile-find-rule-perl-0.34-2 [ 81s] [403/516] installing lmodern-2.005-1 [ 82s] [404/516] installing sgml-data-2.0.11+nmu1 [ 83s] [405/516] installing libstdc++-12-dev-12.2.0-5 [ 84s] [406/516] installing libatk-bridge2.0-0-2.46.0-3 [ 84s] [407/516] installing libfontconfig1-2.13.1-4.5 [ 84s] Processing triggers for sgml-base (1.30) ... [ 84s] [408/516] installing libtool-2.4.7-4 [ 84s] [409/516] installing libenchant-2-2-2.3.3-1 [ 84s] [410/516] installing libpam-modules-1.5.2-3 [ 84s] dpkg: error processing archive .init_b_cache/libpam-modules.deb (--install): [ 84s] trying to overwrite '/usr/share/man/man5/namespace.conf.5.gz', which is also in package libpam-modules-bin 1.5.2-3 [ 84s] Errors were encountered while processing: [ 84s] .init_b_cache/libpam-modules.deb [ 84s] exit ... [ 84s] ### VM INTERACTION START ### [ 84s] [ 66.607838][ T1] sysrq: Power Off [ 84s] [ 66.610748][ T16] reboot: Power down [ 84s] ### VM INTERACTION END ### [ 84s] [ 84s] lamb28 failed "build osmo-sgsn_1.9.0.5.13ccb.202210060052.dsc" at Thu Oct 6 11:04:55 UTC 2022. [ 84s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

1 0

Build failure of network:osmocom:nightly/osmo-hnodeb in Debian_Unstable/x86_64
by OBS Notification 06 Oct '22

06 Oct '22

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-hnodeb failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 81s] [394/514] installing intltool-debian-0.35.0+20060710.5 [ 81s] [395/514] installing libdpkg-perl-1.21.9 [ 81s] [396/514] installing libosmo-ranap-dev-1.3.0.2.a9c38.202210060052 [ 81s] [397/514] installing libpaper-utils-1.1.28+b1 [ 81s] [398/514] installing libsctp-dev-1.0.19+dfsg-2 [ 81s] [399/514] installing mailcap-3.70+nmu1 [ 81s] [400/514] installing autoconf-2.71-2 [ 81s] [401/514] installing libfile-find-rule-perl-0.34-2 [ 81s] [402/514] installing lmodern-2.005-1 [ 83s] [403/514] installing sgml-data-2.0.11+nmu1 [ 84s] [404/514] installing libstdc++-12-dev-12.2.0-5 [ 84s] [405/514] installing libatk-bridge2.0-0-2.46.0-3 [ 84s] [406/514] installing libfontconfig1-2.13.1-4.5 [ 84s] Processing triggers for sgml-base (1.30) ... [ 84s] [407/514] installing libtool-2.4.7-4 [ 84s] [408/514] installing libenchant-2-2-2.3.3-1 [ 84s] [409/514] installing libpam-modules-1.5.2-3 [ 85s] dpkg: error processing archive .init_b_cache/libpam-modules.deb (--install): [ 85s] trying to overwrite '/usr/share/man/man5/namespace.conf.5.gz', which is also in package libpam-modules-bin 1.5.2-3 [ 85s] Errors were encountered while processing: [ 85s] .init_b_cache/libpam-modules.deb [ 85s] exit ... [ 85s] ### VM INTERACTION START ### [ 85s] [ 67.697163][ T1] sysrq: Power Off [ 85s] [ 67.700673][ T16] reboot: Power down [ 85s] ### VM INTERACTION END ### [ 85s] [ 85s] lamb28 failed "build osmo-hnodeb_0.1.0.2.9c2c.202210060052.dsc" at Thu Oct 6 11:04:53 UTC 2022. [ 85s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

1 0

2025

2024

2023

2022

gerrit-log October 2022