October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bts[master]: l1sap: do not call msgb_l2hlen without checking

by dexter

Attention is currently required from: osmith, laforge, fixeria, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29650 ) Change subject: l1sap: do not call msgb_l2hlen without checking ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/29650/comment/d9268d1a_fdb7d6c7 PS1, Line 9: zsing > typo: using Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29650 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie13d0724f183ff240714dcdbd24e5a21b4276bfe Gerrit-Change-Number: 29650 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Oct 2022 08:29:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bts[master]: l1sap: do not call msgb_l2hlen without checking

by Jenkins Builder

Attention is currently required from: osmith, laforge, fixeria, pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29650 ) Change subject: l1sap: do not call msgb_l2hlen without checking ...................................................................... Patch Set 3: Verified+1 19 passed: [build] https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-bts-build/BTS_MODEL=lc1… [build] https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-bts-build/BTS_MODEL=trx… [build] https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-bts-build/BTS_MODEL=oct… [build] https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-bts-build/BTS_MODEL=sys… [build] https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-bts-build/BTS_MODEL=oc2… [build] https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-bts-build/BTS_MODEL=oct… [build] https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-bts-build/BTS_MODEL=trx… [build] https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-bts-build/BTS_MODEL=sys… [build] https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-bts-build/BTS_MODEL=oc2… [build] https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-bts-build/BTS_MODEL=lc1… [build] https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-bts-build/BTS_MODEL=sys… [build] https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-bts-build/BTS_MODEL=lc1… [build] https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-bts-build/BTS_MODEL=sys… [build] https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-bts-build/BTS_MODEL=oc2… [build] https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-bts-build/BTS_MODEL=sys… [build] https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-bts-build/BTS_MODEL=sys… [rpm] https://jenkins.osmocom.org/jenkins/job/gerrit-binpkgs-rpm/32/consoleFull [lint] https://jenkins.osmocom.org/jenkins/job/gerrit-lint/48/consoleFull [deb] https://jenkins.osmocom.org/jenkins/job/gerrit-binpkgs-deb/30/consoleFull Build Successful -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29650 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie13d0724f183ff240714dcdbd24e5a21b4276bfe Gerrit-Change-Number: 29650 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Oct 2022 08:22:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bts[master]: l1sap: do not call msgb_l2hlen without checking

by dexter

Attention is currently required from: osmith, laforge, fixeria, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29650 ) Change subject: l1sap: do not call msgb_l2hlen without checking ...................................................................... Patch Set 3: (1 comment) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/29650/comment/735fc239_529ad013 PS2, Line 352: *len = 0; > Ack Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29650 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie13d0724f183ff240714dcdbd24e5a21b4276bfe Gerrit-Change-Number: 29650 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Oct 2022 08:13:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bts[master]: l1sap: do not call msgb_l2hlen without checking

by dexter

Attention is currently required from: osmith, laforge, fixeria, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/29650 to look at the new patch set (#3). Change subject: l1sap: do not call msgb_l2hlen without checking ...................................................................... l1sap: do not call msgb_l2hlen without checking We request the length using msgb_l2len() in two locations where whe cannot be sure that l2h is populated. Lets check this first. Change-Id: Ie13d0724f183ff240714dcdbd24e5a21b4276bfe Related: OS#5645 --- M src/common/l1sap.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/50/29650/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29650 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie13d0724f183ff240714dcdbd24e5a21b4276bfe Gerrit-Change-Number: 29650 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: mgw: Introduce test TC_crcx_osmux_257

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29661 ) Change subject: mgw: Introduce test TC_crcx_osmux_257 ...................................................................... Patch Set 4: Code-Review+2 (1 comment) File mgw/expected-results.xml: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29661/comment/271d79f9_34aa… PS3, Line 94: <testcase classname='MGCP_Test' name='TC_crcx_osmux_257' time='MASKED'/> > This line should be moved after the TC_crcx_osmux_fixed_twice, to prevent shuffling when re-generati […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29661 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I74e6c760e076fe2547b6297a54524255fb8bc41b Gerrit-Change-Number: 29661 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Oct 2022 07:58:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: respond to tx-attenuation config in real time.

by fixeria

Attention is currently required from: keith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29649 ) Change subject: osmo-bts-trx: respond to tx-attenuation config in real time. ...................................................................... Patch Set 4: (1 comment) File src/osmo-bts-trx/trx_vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/29649/comment/7e0f7955_5a3e69b2 PS4, Line 397: DEFUN So this command now applies immediately. It should be reflected in the interactive VTY help and in documentation. Both can be achieved by changing to DEFUN_ATTR with CMD_ATTR_IMMEDIATE. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29649 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1fa5e8130202fb509593db4132863b762b0f40b7 Gerrit-Change-Number: 29649 Gerrit-PatchSet: 4 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Wed, 12 Oct 2022 04:56:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Build failure of network:osmocom:nightly/osmo-bsc in Raspbian_11/armv7l

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-bsc failed to build in Raspbian_11/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 212s] [408/486] installing texlive-plain-generic-2020.20210202-3 [ 225s] [409/486] installing python3.9-3.9.2-1+rpi1 [ 228s] [410/486] installing texlive-latex-base-2020.20210202-3 [ 229s] [411/486] installing libc6-dev-2.31-13+rpi1+deb11u3 [ 230s] [412/486] installing texlive-lang-greek-2020.20210202-2 [ 248s] [413/486] installing texlive-luatex-2020.20210202-3 [ 252s] [414/486] installing libpangocairo-1.0-0-1.46.2-3 [ 252s] [415/486] installing passwd-1:4.8.1-1 [ 253s] Shadow passwords are now on. [ 254s] [416/486] installing adduser-3.118 [ 255s] [417/486] installing libsctp-dev-1.0.18+dfsg-1 [ 255s] [418/486] installing python3-3.9.2-3 [ 256s] [419/486] installing tipa-2:1.3-20.1 [ 258s] [420/486] installing libstdc++-10-dev-10.2.1-6+rpi1 [ 260s] [421/486] installing texlive-bibtex-extra-2020.20210202-3 [ 267s] dpkg-deb (subprocess): decompressing archive '.init_b_cache/texlive-bibtex-extra.deb' (size=67193052) member 'data.tar': lzma error: compressed data is corrupt [ 267s] dpkg-deb: error: <decompress> subprocess returned error exit status 2 [ 267s] dpkg: error processing archive .init_b_cache/texlive-bibtex-extra.deb (--install): [ 267s] cannot copy extracted data for './usr/share/doc/texlive-doc/latex/biblatex-chicago/cms-notes-sample.pdf' to '/usr/share/doc/texlive-doc/latex/biblatex-chicago/cms-notes-sample.pdf.dpkg-new': unexpected end of file or stream [ 267s] Errors were encountered while processing: [ 267s] .init_b_cache/texlive-bibtex-extra.deb [ 267s] exit ... [ 267s] ### VM INTERACTION START ### [ 268s] [ 216.946836] sysrq: SysRq : Power Off [ 268s] [ 216.948578] reboot: Power down [ 268s] ### VM INTERACTION END ### [ 268s] [ 268s] armbuild02 failed "build osmo-bsc_1.9.0.55.f9e5f.202210120053.dsc" at Wed Oct 12 04:52:05 UTC 2022. [ 268s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

2 years, 8 months

1
0
0 0

Build failure of network:osmocom:nightly/osmo-smlc in Raspbian_11/armv7l

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-smlc failed to build in Raspbian_11/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-smlc Last lines of build log: [ 359s] [465/474] installing glib-networking-2.66.0-2 [ 359s] Processing triggers for libglib2.0-0:armhf (2.66.8-1) ... [ 359s] [466/474] installing libsoup2.4-1-2.72.0-2 [ 359s] [467/474] installing libsoup-gnome2.4-1-2.72.0-2 [ 359s] [468/474] installing librest-0.7-0-0.8.1-1.1 [ 360s] [469/474] installing libgtk-3-0-3.24.24-4+deb11u2 [ 360s] [470/474] installing libgtkspell3-3-0-3.0.10-1 [ 361s] [471/474] installing libgdl-3-5-3.34.0-1 [ 361s] [472/474] installing libgtkmm-3.0-1v5-3.24.2-2 [ 362s] [473/474] installing inkscape-1.0.2-4 [ 365s] dpkg-deb (subprocess): decompressing archive '.init_b_cache/inkscape.deb' (size=14513564) member 'control.tar': lzma error: compressed data is corrupt [ 365s] tar: Unexpected EOF in archive [ 365s] tar: Unexpected EOF in archive [ 365s] tar: Error is not recoverable: exiting now [ 365s] dpkg-deb: error: tar subprocess returned error exit status 2 [ 365s] dpkg: error processing archive .init_b_cache/inkscape.deb (--install): [ 365s] dpkg-deb --control subprocess returned error exit status 2 [ 365s] Errors were encountered while processing: [ 365s] .init_b_cache/inkscape.deb [ 365s] exit ... [ 365s] ### VM INTERACTION START ### [ 365s] Failed to write wtmp record, ignoring: Read-only file system [ 365s] Failed to write utmp record: Read-only file system [ 365s] Powering off. [ 365s] [ 283.316182] reboot: Power down [ 366s] ### VM INTERACTION END ### [ 366s] [ 366s] armbuild02 failed "build osmo-smlc_0.2.2.3.5185.202210120053.dsc" at Wed Oct 12 04:47:08 UTC 2022. [ 366s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: vlr: implement fallback to no-auth

by Jenkins Builder

Attention is currently required from: neels. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29699 ) Change subject: vlr: implement fallback to no-auth ...................................................................... Patch Set 1: Verified-1 1 failed: [lint] https://jenkins.osmocom.org/jenkins/job/gerrit-lint/47/consoleFull 4 passed: [build] https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-msc-build/IU=--enable-i… [build] https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-msc-build/IU=--disable-… [rpm] https://jenkins.osmocom.org/jenkins/job/gerrit-binpkgs-rpm/31/consoleFull [deb] https://jenkins.osmocom.org/jenkins/job/gerrit-binpkgs-deb/29/consoleFull Please fix the linting errors. More information: https://osmocom.org/projects/cellular-infrastructure/wiki/Linting Build Failed -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29699 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I5feda196fa481dd8a46b0e4721c64b7c6600f0d1 Gerrit-Change-Number: 29699 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Oct 2022 22:43:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: vlr: implement fallback to no-auth

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29699 ) Change subject: vlr: implement fallback to no-auth ...................................................................... Patch Set 1: (2 comments) File src/libvlr/vlr_access_req_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-47): https://gerrit.osmocom.org/c/osmo-msc/+/29699/comment/7aab9355_c4f4aa4e PS1, Line 458: proc_arq_fsm_done(fi, cause? *cause : GSM48_REJECT_NETWORK_FAILURE); spaces required around that '?' (ctx:VxW) File src/libvlr/vlr_lu_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-47): https://gerrit.osmocom.org/c/osmo-msc/+/29699/comment/426137d5_ca29661b PS1, Line 1165: lu_fsm_failure(fi, res? *res : GSM48_REJECT_NETWORK_FAILURE); spaces required around that '?' (ctx:VxW) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29699 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I5feda196fa481dd8a46b0e4721c64b7c6600f0d1 Gerrit-Change-Number: 29699 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 11 Oct 2022 22:38:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022