lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

January 2022

  • 3 participants
  • 781 discussions
Change in libosmo-netif[master]: amr: Introduce APIs to convert BE to IuUP/IuFP format
by laforge 04 Jan '22

04 Jan '22
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26717 ) Change subject: amr: Introduce APIs to convert BE to IuUP/IuFP format ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26717 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Id2bd32d5f2060abe581730996dc4251381bf7d4f Gerrit-Change-Number: 26717 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Jan 2022 13:25:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
Change in libosmo-netif[master]: export osmo_amr_bits
by laforge 04 Jan '22

04 Jan '22
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26716 ) Change subject: export osmo_amr_bits ...................................................................... Patch Set 1: Code-Review+1 it's not really exporting anything, it's just adding a declaration for an existing export? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26716 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ic03653b2a885c5d9419c6c75a718b550fc30b86e Gerrit-Change-Number: 26716 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Jan 2022 13:23:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
Change in libosmo-netif[master]: amr: don't rely on pad bits to be zero
by laforge 04 Jan '22

04 Jan '22
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26715 ) Change subject: amr: don't rely on pad bits to be zero ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26715 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I354fbbcbaf7ff7e7d498b22c175a57a79b6b8856 Gerrit-Change-Number: 26715 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Jan 2022 13:23:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
Change in osmo-iuh[master]: mgw_fsm: add MGW support to osmo-hnbgw
by laforge 04 Jan '22

04 Jan '22
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26725 ) Change subject: mgw_fsm: add MGW support to osmo-hnbgw ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-iuh/+/26725/1/configure.ac File configure.ac: https://gerrit.osmocom.org/c/osmo-iuh/+/26725/1/configure.ac@52 PS1, Line 52: PKG_CHECK_MODULES(LIBOSMOMGCPCLIENT, libosmo-mgcp-client >= 1.9.0) > We should really move osmo-hnbgw to its own repo to avoid this kind of dependencies. […] makes sense. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26725 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ib9b62e0145184b91c56ce5d8870760bfa49cc5a4 Gerrit-Change-Number: 26725 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Jan 2022 13:22:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment
1 0
0 0
Change in osmo-iuh[master]: iu_helpers: make new_transp_info_(rtp|gtp) public
by laforge 04 Jan '22

04 Jan '22
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26722 ) Change subject: iu_helpers: make new_transp_info_(rtp|gtp) public ...................................................................... Patch Set 1: yes, let's make the functions (or new functions) AF-agnostic before exporting them. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26722 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1e369718de8c4c7db1f1af1e6864562164ada6cf Gerrit-Change-Number: 26722 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Jan 2022 13:19:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
1 0
0 0
Change in osmo-mgw[master]: mgcp_client: add new codec IUFP as VND.3GPP.IUFP
by laforge 04 Jan '22

04 Jan '22
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26651 ) Change subject: mgcp_client: add new codec IUFP as VND.3GPP.IUFP ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/26651/4/src/libosmo-mgcp-client/mgc… File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26651/4/src/libosmo-mgcp-client/mgc… PS4, Line 62: { CODEC_IUFP, "VND.3GPP.IUFP/16000/1" }, > I think more than irrelevant it's wrong specifying it here, since that's actually negotiated/announc […] yes, it is dynamically specified during the SDP handshake. THat's what the 'rtpmap' is all about. So the MGW must deal with it based on whatever the rtpmap says. I'm not sure where / how exactly this table is used, -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26651 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifd1210a897743396899f34457c96e6fd2109c6b3 Gerrit-Change-Number: 26651 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Jan 2022 13:18:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment
1 0
0 0
Change in osmo-iuh[master]: mgw_fsm: add MGW support to osmo-hnbgw
by pespin 04 Jan '22

04 Jan '22
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26725 ) Change subject: mgw_fsm: add MGW support to osmo-hnbgw ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-iuh/+/26725/1/configure.ac File configure.ac: https://gerrit.osmocom.org/c/osmo-iuh/+/26725/1/configure.ac@52 PS1, Line 52: PKG_CHECK_MODULES(LIBOSMOMGCPCLIENT, libosmo-mgcp-client >= 1.9.0) We should really move osmo-hnbgw to its own repo to avoid this kind of dependencies. Otherwise in order to build osmo-hnodeb one also needs to build osmo-mgw prior to it. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26725 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ib9b62e0145184b91c56ce5d8870760bfa49cc5a4 Gerrit-Change-Number: 26725 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Jan 2022 13:16:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
1 0
0 0
Change in osmo-bsc[master]: om2000: Don't print "should not generate any message" on FAULT_REP
by laforge 04 Jan '22

04 Jan '22
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26713 ) Change subject: om2000: Don't print "should not generate any message" on FAULT_REP ...................................................................... om2000: Don't print "should not generate any message" on FAULT_REP Change-Id: I65184ef5aa90a993491f9393614bb499c6998169 Closes: OS#4643 --- M src/osmo-bsc/abis_om2000.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-bsc/abis_om2000.c b/src/osmo-bsc/abis_om2000.c index 4523555..fc40cc4 100644 --- a/src/osmo-bsc/abis_om2000.c +++ b/src/osmo-bsc/abis_om2000.c @@ -2970,7 +2970,8 @@ case OM2K_MSGT_FAULT_REP: display_fault_maps(msg->l2h, msgb_l2len(msg), &o2h->mo); rc = abis_om2k_tx_simple(bts, &o2h->mo, OM2K_MSGT_FAULT_REP_ACK); - break; + /* we receive this from MOs without FSM (https://osmocom.org/issues/4643) */ + goto no_mo; case OM2K_MSGT_NEGOT_REQ: rc = om2k_rx_negot_req(msg); break; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26713 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I65184ef5aa90a993491f9393614bb499c6998169 Gerrit-Change-Number: 26713 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 0
0 0
Change in osmo-bsc[master]: om2000: Don't print "should not generate any message" on FAULT_REP
by laforge 04 Jan '22

04 Jan '22
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26713 ) Change subject: om2000: Don't print "should not generate any message" on FAULT_REP ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26713 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I65184ef5aa90a993491f9393614bb499c6998169 Gerrit-Change-Number: 26713 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Jan 2022 13:15:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
Change in osmo-iuh[master]: ranap_rab_ass: add decoder and rewrite functions for RAB-AssignmentRe...
by pespin 04 Jan '22

04 Jan '22
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26724 ) Change subject: ranap_rab_ass: add decoder and rewrite functions for RAB-AssignmentRequest/Response ...................................................................... Patch Set 1: (4 comments) Sounds like we should be creating src/hnbgw/ soon and move all hnbgw files there, since we'll be adding more code there. Even maybe thinking about splitting it to a new repository, specially since we'll now depend on libosmo-mgcp in osmo-hnbgw. https://gerrit.osmocom.org/c/osmo-iuh/+/26724/1/include/osmocom/iuh/ranap_r… File include/osmocom/iuh/ranap_rab_ass.h: https://gerrit.osmocom.org/c/osmo-iuh/+/26724/1/include/osmocom/iuh/ranap_r… PS1, Line 1: #pragma once This file in hnbgw specific afaict, so it must not go into osmo-iuh (libosmo-ranap/rua/sabp) include directory imho, but rather to include/osmocom/hnbgw/ https://gerrit.osmocom.org/c/osmo-iuh/+/26724/1/include/osmocom/iuh/ranap_r… PS1, Line 3: int ranap_rab_ass_req_decode(RANAP_RAB_AssignmentRequestIEs_t * rab_assignment_request_ies, const uint8_t *data, please put the "*" attached to the right. https://gerrit.osmocom.org/c/osmo-iuh/+/26724/1/src/ranap_rab_ass.c File src/ranap_rab_ass.c: https://gerrit.osmocom.org/c/osmo-iuh/+/26724/1/src/ranap_rab_ass.c@241 PS1, Line 241: * \ptmap[out] addr buffer to store extraced RTP stream IP address (length at least INET6_ADDRSTRLEN). extracted (same immediately below) https://gerrit.osmocom.org/c/osmo-iuh/+/26724/1/src/ranap_rab_ass.c@242 PS1, Line 242: * \ptmap[out] port pointer to store extraced RTP stream IP port number. worth mentioning whether it's network-byte order or host-byte-ordering. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26724 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I58b542bf23ff5e1db2ccf6833fec91d9ba332837 Gerrit-Change-Number: 26724 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Jan 2022 13:15:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 75
  • 76
  • 77
  • 78
  • 79
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.