January 2022 - gerrit-log - lists.osmocom.org

Change in osmo-iuh[master]: mgw_fsm: add MGW support to osmo-hnbgw

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26725 ) Change subject: mgw_fsm: add MGW support to osmo-hnbgw ...................................................................... Patch Set 2: (7 comments) https://gerrit.osmocom.org/c/osmo-iuh/+/26725/2/configure.ac File configure.ac: https://gerrit.osmocom.org/c/osmo-iuh/+/26725/2/configure.ac@52 PS2, Line 52: PKG_CHECK_MODULES(LIBOSMOMGCPCLIENT, libosmo-mgcp-client >= 1.9.0) Please also make sure that both: * 'contrib/osmo-iuh.spec.in' and * debian/control are updated to reflect the new dependency. https://gerrit.osmocom.org/c/osmo-iuh/+/26725/2/src/hnbgw.c File src/hnbgw.c: https://gerrit.osmocom.org/c/osmo-iuh/+/26725/2/src/hnbgw.c@376 PS2, Line 376: LOGL_DEBUG Why debug? All other categories are set to LOGL_NOTICE. https://gerrit.osmocom.org/c/osmo-iuh/+/26725/2/src/hnbgw.c@379 PS2, Line 379: ws https://gerrit.osmocom.org/c/osmo-iuh/+/26725/2/src/hnbgw_cn.c File src/hnbgw_cn.c: https://gerrit.osmocom.org/c/osmo-iuh/+/26725/2/src/hnbgw_cn.c@349 PS2, Line 349: uint8_t *msg_data; const https://gerrit.osmocom.org/c/osmo-iuh/+/26725/2/src/hnbgw_cn.c@362 PS2, Line 362: /* Intercept RAB Assignment Request, Setup MGW FSM */ I am not saying the current approach is wrong, just an alternative variant: if (!map->is_ps && msgb_l2len(oph->msg) > 2) { switch (msgb_l2(oph->msg)[1]) { case RANAP_ProcedureCode_id_RAB_Assignment: return mgw_fsm_alloc_and_handle_rab_ass_req(map, oph); case RANAP_ProcedureCode_id_Iu_Release: /* Any IU Release will terminate the MGW FSM */ mgw_fsm_handle_iu_release(map); } } IMO, it's shorter and easier to read. https://gerrit.osmocom.org/c/osmo-iuh/+/26725/2/src/hnbgw_rua.c File src/hnbgw_rua.c: https://gerrit.osmocom.org/c/osmo-iuh/+/26725/2/src/hnbgw_rua.c@192 PS2, Line 192: uint8_t *msg_data; const https://gerrit.osmocom.org/c/osmo-iuh/+/26725/2/src/mgw_fsm.c File src/mgw_fsm.c: https://gerrit.osmocom.org/c/osmo-iuh/+/26725/2/src/mgw_fsm.c@189 PS2, Line 189: switch (event) { weird formatting -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26725 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ib9b62e0145184b91c56ce5d8870760bfa49cc5a4 Gerrit-Change-Number: 26725 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jan 2022 07:21:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in libosmo-abis[master]: ipaccess.c: register RSL/OML related osmo_fds for monitoring

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/26455 ) Change subject: ipaccess.c: register RSL/OML related osmo_fds for monitoring ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/26455 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I42ca4e9257eee2857784dd4f5b17a83220e2be9e Gerrit-Change-Number: 26455 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jan 2022 05:57:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: logging: Fix Not enough tailroom msgb_put in _output_buf callers

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26726 ) Change subject: logging: Fix Not enough tailroom msgb_put in _output_buf callers ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26726 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8d71bd1a0dad37606acb8302b05c2ae338112e57 Gerrit-Change-Number: 26726 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 05 Jan 2022 05:51:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in libosmo-abis[master]: ipaccess.c: register RSL/OML related osmo_fds for monitoring

by dexter

Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/26455 to look at the new patch set (#4). Change subject: ipaccess.c: register RSL/OML related osmo_fds for monitoring ...................................................................... ipaccess.c: register RSL/OML related osmo_fds for monitoring The osmo_fds used for ipaccess based E1 traffic should be registered for monitoring to get tcp_stats for all RSL/OML links. Change-Id: I42ca4e9257eee2857784dd4f5b17a83220e2be9e depends: libosmocore I64b288174ae3dd22d50a701ce7cbf9e623246479 Related: SYS#5701 --- M src/input/ipaccess.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/55/26455/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/26455 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I42ca4e9257eee2857784dd4f5b17a83220e2be9e Gerrit-Change-Number: 26455 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 5 months

1
0
0 0

Change in libosmo-abis[master]: ipaccess.c: register RSL/OML related osmo_fds for monitoring

by dexter

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/26455 ) Change subject: ipaccess.c: register RSL/OML related osmo_fds for monitoring ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/libosmo-abis/+/26455/3/src/input/ipaccess.c File src/input/ipaccess.c: https://gerrit.osmocom.org/c/libosmo-abis/+/26455/3/src/input/ipaccess.c@676 PS3, Line 676: rsl > oml Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/26455 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I42ca4e9257eee2857784dd4f5b17a83220e2be9e Gerrit-Change-Number: 26455 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Jan 2022 15:58:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: RTP_Emulation: Several fixes and improvements for IuUP streams

by dexter

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26719 ) Change subject: RTP_Emulation: Several fixes and improvements for IuUP streams ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26719 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id4f8b02a8123bb30b659c40148c8ab4c7c2078a1 Gerrit-Change-Number: 26719 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 04 Jan 2022 15:22:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: mgw: Introduce test TC_two_crcx_mdcx_and_iuup

by dexter

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26720 ) Change subject: mgw: Introduce test TC_two_crcx_mdcx_and_iuup ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26720 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0866fb499c6d426386d9811d075a7fe8386c5cb1 Gerrit-Change-Number: 26720 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 04 Jan 2022 15:19:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in libosmo-netif[master]: amr: Introduce APIs to convert BE to IuUP/IuFP format

by dexter

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26717 ) Change subject: amr: Introduce APIs to convert BE to IuUP/IuFP format ...................................................................... Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmo-netif/+/26717/3/src/amr.c File src/amr.c: https://gerrit.osmocom.org/c/libosmo-netif/+/26717/3/src/amr.c@65 PS3, Line 65: Shouldn't we add API doc strings here too? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26717 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Id2bd32d5f2060abe581730996dc4251381bf7d4f Gerrit-Change-Number: 26717 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Jan 2022 15:17:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in osmo-mgw[master]: mgcp_client: add new codec IUFP as VND.3GPP.IUFP

by dexter

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26651 ) Change subject: mgcp_client: add new codec IUFP as VND.3GPP.IUFP ...................................................................... Patch Set 6: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/26651/5/src/libosmo-mgcp-client/mgc… File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26651/5/src/libosmo-mgcp-client/mgc… PS5, Line 62: { CODEC_IUFP, "VND.3GPP.IUFP/16000" }, > Why do you say it's called IuFP? See 3GPP TS 29.414 6.3.3.5 "Media Attributes": […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26651 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifd1210a897743396899f34457c96e6fd2109c6b3 Gerrit-Change-Number: 26651 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Jan 2022 14:56:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in osmo-iuh[master]: ranap_common: add decoder for RAB SetupOrModifyItemFirst

by dexter

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/26723 to look at the new patch set (#2). Change subject: ranap_common: add decoder for RAB SetupOrModifyItemFirst ...................................................................... ranap_common: add decoder for RAB SetupOrModifyItemFirst The RAB SetupOrModifyItemFirst is contained in the RAB Assignment Request. We currently have no decoder for it, so lets add one. Change-Id: Id7293c1035cf6de34b7a416fa9265a5a32ed3216 Related: OS#5152 --- M include/osmocom/ranap/ranap_common.h M src/ranap_common.c 2 files changed, 29 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/23/26723/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26723 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Id7293c1035cf6de34b7a416fa9265a5a32ed3216 Gerrit-Change-Number: 26723 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2022