Hi,
libasan reports heap overflow in tetra-rx
To reproduce:
checkout latest osmo-tetra
optionally modify Makefile to add -DDEBUG to CFLAGS
make debug (compiling this on debian 12 using the prepackaged
libosmocore)
dd if=/dev/zero of=testbits.bin bs=1k count=4
mkdir r
./tetra-rx -d r testbits.bin
[...]
burst_sync_in: 64 bits, state 0
-> trying to find training sequence between bit 0 and 4032
burst_sync_in: 64 bits, state 0
-> trying to find training sequence between bit 0 and 4096
=================================================================
==169038==ERROR: AddressSanitizer: heap-buffer-overflow on address
0x621000001178 at pc 0x55e8c5b1acd0 bp 0x7ffee4666cf0 sp 0x7ffee4666ce8
READ of size 1 at 0x621000001178 thread T0
#0 0x55e8c5b1accf in tetra_find_train_seq phy/tetra_burst.c:294
#1 0x55e8c5b19d30 in tetra_burst_sync_in phy/tetra_burst_sync.c:75
#2 0x55e8c5b19917 in main
/home/sq5bpf/tetra2/osmo-tetra-orig/src/tetra-rx.c:94
#3 0x7fc9714461c9 in __libc_start_call_main
../sysdeps/nptl/libc_start_call_main.h:58
#4 0x7fc971446284 in __libc_start_main_impl ../csu/libc-start.c:360
#5 0x55e8c5b19540 in _start
(/home/sq5bpf/tetra2/osmo-tetra-orig/src/tetra-rx+0xc540)
0x621000001178 is located 0 bytes to the right of 4216-byte region
[0x621000000100,0x621000001178)
allocated by thread T0 here:
#0 0x7fc9716b89cf in __interceptor_malloc
../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:69
#1 0x7fc971cb0d53 (/lib/x86_64-linux-gnu/libtalloc.so.2+0x5d53)
SUMMARY: AddressSanitizer: heap-buffer-overflow phy/tetra_burst.c:294 in
tetra_find_train_seq
Shadow bytes around the buggy address:
0x0c427fff81d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c427fff81e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c427fff81f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c427fff8200: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c427fff8210: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x0c427fff8220: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00[fa]
0x0c427fff8230: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c427fff8240: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c427fff8250: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c427fff8260: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c427fff8270: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
This is some off-by-one bug but not obvious to me while looking at the
code.
Jacek
hello everyone, I installed osmo-tetra, along with telive, and audio codec, but when I open telive and receiver1udp everything seems to be working ok, but telive doesn't display anything as if there is no connection, and if I have the tetra key, the -k function where it should be, a tutorial would help many of us, thank you very much
hello everyone, I recently installed osmo-tetra, and I saw that it has the function of adding -k key, but I don't know where to put -k, if I have the key available, Thank you very much
Hi
I've published a receiver and demodulator using gnuradio 3.10 for
osmo-tetra (and maybe other python3 gnuradio versions, but this was not
tested).
The pull request was sent to https://github.com/osmocom/osmo-tetra, which
i now know won't work.
I will figure out how to send the patch, when i get some time to read the
docs, but in the meantime, maybe you would just like to grab the files
from here:
https://github.com/sq5bpf/osmo-tetra-temporary-fork
73
Jacek / SQ5BPF
Good evening Sir/Mam
Myself Avinash and I'm currently working on a project wherein I am required
to implement TETRA using SDRs.
It will be a great help for me to have your guidance for the same.
Looking forward to hear from you.
Regards
Hi all!
[please follow-up-to the openbsc(a)lists.osmocom.org mailing list, if
there is any discussion, we don't want to drag it over tons of mailing
lists in parallel]
Some weeks ago, I created https://osmocom.org/issues/5397 but it seems nobody
noticed the ticket or had any comments to it.
So let me post this as RFC here on the mailing list:
In the past, we had a gitolite/gitosis setup, which was fine in the
early days of git, but it means that people cannot easily create new
repositories, see who has permissions, and we cannot delegate ownership.
Even updating SSH keys requires manual interaction of a sysadmin like
me.
I would therefore suggest to migrate git.osmocom.org to gitea[1]
This would allow the following features:
* users can self-create any number of personal repositories (like gitlab/github)
* we can create 'organizations' along the line of reasonably independent
osmocom member projects like op25, who can then manage their own
repos/permissions/...
* gitea can link to redmine wiki and redmine issue trackers (rather than
using its own built-in)
For those repositories hosted in gerrit (mainly CNI), we would still
keep git.osmocom.org a read-only mirror, like we do it right now.
For those repositories not hosted in gerrit, users/projects could then
accept merge requests in gitea. Coupling this with 3rd party
authentication via github/gitlab/etc should make it easier for the
occasional contributor to submit changes.
There is a downside, of course; A lot of repo URLs have to change. Most
of our current repositories are at git.osmocom.org/project.git while
gitea follows a git.osmocom.org/organization/project.git scheme. I'm not
sure there is any way to help to mitigate this...
Any thoughts, comments?
[1] https://gitea.io/
--
- Harald Welte <laforge(a)osmocom.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)
Dear fellow Osmocom developers,
as you all know, we've sadly had to skip OsmoDevCon 2020 and 2021,
trying to compensate it at least to some extent with our OsmoDevCall
every two weeks.
The COVID-19 pandemic is far from over, and we don't know what the
upcoming winter season will bring.
Nevertheless, I think it would be a good idea to start a discussion of
whether we should plan for an OsmoDevCon in 2022.
I personally would say let's plan for the usual late April 2022 time frame,
and if the pandemic situation deteriorates, we can still cancel it with
something like one month lead time.
I would also personally suggest to limit attendance to people who are fully
vaccinated, and in addition do a self-test for all participants every
morning.
In terms of venue, we might also consider to move to a venue that allows better
ventilation. Irrespective of the above we can also bring the air filters from
the sysmocom office.
So with that as an input statement, I would like to hear your opinion
on the above proposals. Who would want to attend? Any complaints against
the "vaccinated only plus daily self-tests in the morning" approach?
Regards,
Harald
--
- Harald Welte <laforge(a)osmocom.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)
Dear Osmocom community,
today our mailing list server lists.osmocom.org has finally been migrated
from mailman2-on-freebsd to mailman3-on-linux. This also included a variety
of changes to DNS. I'll spare you the details, but everything _should_ be up
and running now.
* The List-Id headers should not have changed.
* all list subscriptions + user accounts have been converted.
* old 'static html' archives are still available (read only) at URLs like
https://lists.osmocom.org/pipermail/baseband-devel/
* old List URLs like https://lists.osmocom.org/mailman/listinfo/baseband-devel
are redirected to their respective modern counterparts
In case you notice any mailing list related problem, please don't hesitate to
contact me.
Happy hacking,
Harald
--
- Harald Welte <laforge(a)osmocom.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)
would permit try transmitting.<br><br>So if you either find a legal way to =
include the ETSI code at build time, or<br>preferable write a GPL compatibl=
e audio decoder, I think we would be happy to<br>include it in the git repo=
sitory.<br><br>cheers<br> holger<br><br><br>Hello
Pepijn,<br><br>On Sat, 24 Sep 2011 15:49:37 +0200, "Pepijn van den Berkhof=
" <<a ymailto=3D"mailto:vandenberkhof.pepijn@gmail.com" href=3D"mailto:v=
andenberkhof.pepijn(a)gmail.com">vandenberkhof.pepijn(a)gmail.com</a>> wrote=
:<br>> <br>> But do you actually hear output from a real life network=
? Because I<br>> tried the examples attached to the ETSI document regard=
ing the testing<br>> of the codec. They work very nicely, but no luck on=
real life networks<br>> so far. (yes, no encryption)<br><br>I know that=
others have used the current code to decode speech, maybe<br>someone can c=
onfirm it.<br><br>I haven't worked with the code for a while and so can't c=
onfirm it,<br>but it has worked for me in the past.<br><br>Maybe I find the=
time to try it within the next few weeks, if possible<br>I will also try t=
o provide a sample capture from a test TETRA network<br>so everyone can try=
the sample. "Test TETRA Network" means from a<br>network under our
control run in a faraday cage so that there are<br>no legal issues providi=
ng the capture.<br><br>Best regards,<br> Dieter<br>-- <br>Dieter Spaa=
r, Germany &n=
bsp; <a ymailto=3D"mailto:spaar@mirider.augusta.de" h=
ref=3D"mailto:spaar@mirider.augusta.de">spaar(a)mirider.augusta.de</a><br><br=
><br><div id=3D"yiv1108789824">is that could help us for voice decoding : ?=
<br><br><a rel=3D"nofollow" target=3D"_blank" href=3D"http://www.joys99.com=
/d-4784.html">http://www.joys99.com/d-4784.html</a><br clear=3D"all"><br>--=
<br><br>=0A</div><br>_______________________________________________<br>te=
tra mailing list<br><a ymailto=3D"mailto:tetra@lists.osmocom.org" href=3D"m=
ailto:tetra@lists.osmocom.org">tetra(a)lists.osmocom.org</a><br><a href=3D"ht=
tps://lists.osmocom.org/mailman/listinfo/tetra" target=3D"_blank">https://l=ists.osmocom.org/mailman/listinfo/tetra</a><br><br><br></div></div></div></=
body></html>
--1668814050-976982791-1316890565=:17022--
