This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 08fe76a89334ddc4ee906bd30a00d908745b2b7b (commit) via 5e9f40d3d9c29446ca1386f2198057fb8a914370 (commit) via 18fef1064162ee23fe839d4b890a6736ec54fd31 (commit) from f5c97476de68ac7ce2fba48be1e7502c1c794606 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=08fe76a89334ddc4ee906bd30a00d90… commit 08fe76a89334ddc4ee906bd30a00d908745b2b7b Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Feb 23 15:10:20 2015 +0100 tbf: Fix dangling m_new_tbf pointer Currently if a 'new' TBF is freed before the 'old' one (where old_tbf->m_new_tbf == new_tbf), the old_tbf->m_new_tbf is not cleared and can be accessed later on. This can lead to inconsistencies or segmentation faults. This commit adds m_old_tbf which points back from new_tbf to old_pdf. m_new_tbf and m_old_tbf are either both set to NULL or one is the reverse pointer of the other (tbf->m_new_tbf->m_old_tbf == tbf and tbf->m_old_tbf->m_new_tbf == tbf). It extends set_new_tbf and tbf_free to update the pointee accordingly. The TBF test is extended to check this invariant at several places. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=5e9f40d3d9c29446ca1386f2198057f… commit 5e9f40d3d9c29446ca1386f2198057fb8a914370 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Feb 23 14:26:59 2015 +0100 tbf/test: Modify test to create a dangling TBF pointer When new_tbf is freed before dl_tbf in test_tbf_final_ack, dl_tbf still contains a pointer to it in m_new_tbf. This patch changes the test to accept a test mode parameter and runs it twice which a different order of tbf_free in each run. Consistency checks are added, to check for a danglilng m_new_tbf pointer in both cases. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=18fef1064162ee23fe839d4b890a673… commit 18fef1064162ee23fe839d4b890a6736ec54fd31 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Feb 23 14:17:01 2015 +0100 tests: Fix library link order Currently libgprs.la is listed after libosmocore.so which leads to link errors when compiling under Ubuntu with the system build tools (no cross compiling). This patch moves libgprs.la in front of the external libs. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: src/tbf.cpp | 37 +++++++++++++++++++++++++++ src/tbf.h | 1 + tests/Makefile.am | 8 +++--- tests/tbf/TbfTest.cpp | 36 +++++++++++++++++++++++---- tests/tbf/TbfTest.err | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 142 insertions(+), 9 deletions(-) hooks/post-receive -- UNNAMED PROJECT