This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, radisys/egprs_features has been created at 9ddc3c7845b094911b3eba1d17e6a74d7e7503ee (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=9ddc3c7845b094911b3eba1d... commit 9ddc3c7845b094911b3eba1d17e6a74d7e7503ee Author: aravind sirsikar <arvind.sirsikar@radisys.com> Date: Fri Dec 30 12:24:38 2016 +0530 PDCH allocation across two TRX Implementation: PCU keeps track of number PDCH across all the TRXs at BTS context and also keeps number of active PDCHs in each TRX context. This ratio gives the CAPACITY of each TRX. 1st Phase: While selection of TRX, functions get_possible_trxs(for multiple TS) and get_possible_trxs_sba(Single block allocation, Ex: during RACH) gets possible TRXs based on TFIs availability. 2nd Phase: outcome of TRXs(from get_possible_trxs, get_possible_trxs_sba) will be fed to get_suitable_trx function. Which does actual load balancing on each TRX. And selects the best fit TRX, based on below equation PROBABILITY = MAX_PROBABILITY – ((LOAD * 100)/CAPACITY); If same PROBABILITY Select the one with higher capacity Else Find the TRX with higher PROBABILITY MAX_PROBABILITY = 65535; LOAD: Initialized to 0, Later gets incremented with number of TS allocated. and decremented whle TBF deletion, based on number of TS allocated Below are the test executed on Unit test environment 1) 2 TRXs, with same Capacity 2) 2 TRX with ½ capacity 3) 2 TRXs with ¼ capacity 4) 2 TRX with UL and DL allocation to ensure Tbfs on both direction is hosted on same TRX 5) 2 TRX with same Capacity and DL TBF creation and deletion scenarios to ensure proper load balancing criteria for actual Load. Below are the Test executed on Integration setup with Ettus B200 setup with 2 TRXs with same CAPACITY. 1) TRX allocation during RACH procedure(SBA allocation) 2) TRX allocation during DL TBF creation with multi time slots(4 time slots) 3) TRX allocation while Ping Test 4) TRX allocation while UDP test 5) TRX allocation for web browsing. 6) 2 MS test with each TRX sharing 1 MS. Received aggregate throughput of 446 kbps(223 Kbps each) Limitation: 1) BSSGP flow control needs to be tuned since test with 2 MS with each MS on different TRX runs for 20 mins 2) USF resource availibility is not checked while selecting the TRX as existing implementation Change-Id: Ifb61a7862d55af828383b6dfe728628e546ed12b Related: OS# 1775 http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=d3ae14c18f44d24c0a5c592f... commit d3ae14c18f44d24c0a5c592fa9bdc9350b90cfd3 Author: aravind sirsikar <arvind.sirsikar@radisys.com> Date: Fri Dec 30 11:15:08 2016 +0530 Sanitizer build fix for invalid value of egprs_puncturing_values This patch is probable fix for "tbf_dl.cpp:766:65: runtime error: load of value 32766, which is not a valid value for type 'egprs_puncturing_values'" Change-Id: Ice54edc7e4a936eb2f2dd8a243673a30dceef542 http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=fcf2af400a83cfa80dc203aa... commit fcf2af400a83cfa80dc203aad0438b74fce25d91 Author: aravind sirsikar <arvind.sirsikar@radisys.com> Date: Fri Dec 30 11:05:00 2016 +0530 Handle packet access reject during packet resource request When Packet resource request is received, PCU will generate the packet access reject if no resources are present. The encoding is done based on section 7.1.3.2.1 and 8.1.2.5 of 44.060 version 7.27.0 Release 7. This patch also includes the test case to validate the generated packet access reject message. This patch is integration tested on Osmo-trx setup with Ettus B210 board and LG F70 MS with some simulation code changes in Osmo-pcu. Change-Id: I05ff25124b58905586caa0c0c37023d69724f121 http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=f595a4eadb340b225f2308fd... commit f595a4eadb340b225f2308fd1c33b8760958f365 Author: Pravin Kumarvel <pmanohar@radisys.com> Date: Thu Dec 29 20:23:15 2016 +0530 Update README with working commit versions for openbsc. Necessary changes for enabling new feature in openbsc. http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=ac82ca15e631c6e75f193542... commit ac82ca15e631c6e75f1935422434a89f59356ecd Author: Pravin Kumarvel <pmanohar@radisys.com> Date: Thu Dec 29 20:14:00 2016 +0530 Array indexing for SPB counters in bts statistics. Array indexing mismatch is corrected for SPB counters. (bts_ctr_description with the bts counter declaration). http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=1b465dbadd58fc185e6fb6f7... commit 1b465dbadd58fc185e6fb6f773eb28d2861df3db Author: Pravin Kumarvel <pmanohar@radisys.com> Date: Thu Dec 29 20:12:16 2016 +0530 Will enable padding support for MCS8 to MCS6/MCS3 transition in EGPRS DL. http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=77b5da51ac3430f4e4326956... commit 77b5da51ac3430f4e432695679e057248e7d5345 Author: Pravin Kumarvel <pmanohar@radisys.com> Date: Thu Dec 29 20:10:51 2016 +0530 Update README with working commit versions of osmo components Necessary changes for build this pcu. http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=22529354e1037d5e5cf26566... commit 22529354e1037d5e5cf265661a0738c874390c32 Author: Pravin Kumarvel <pmanohar@radisys.com> Date: Thu Dec 29 20:09:32 2016 +0530 Add test case for testing PUAN This test case is for testing generation of EGPRS PUAN. Corresponding log files .ok and .err are modified. http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=17ee61703200271cfe86486c... commit 17ee61703200271cfe86486c007b1d2d03ba24ee Author: Pravin Kumarvel <pmanohar@radisys.com> Date: Thu Dec 29 20:05:28 2016 +0530 Add compression support in EGPRS PUAN This adds compression of bitmap in PUAN. The compressed bitmap is used only if the number of bits in the bitmap does not fit in the message and there is a gain after compression. The algorithm is part of libosmocore and so there is dependency on the libosmocore for compilation. The algorithm is tested on integration setup by forcing compression. http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=366931baa646a7e7fb74e902... commit 366931baa646a7e7fb74e9021f37d5de1c0df033 Author: Pravin Kumarvel <pmanohar@radisys.com> Date: Thu Dec 29 19:55:22 2016 +0530 Refactoring write_packet_ack_nack_desc_egprs to prepare for CRBB support http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=ee78bf0882d982ed69a98a02... commit ee78bf0882d982ed69a98a0207dec1a1d00de32a Author: sivasankari <Sivasankari.Theerthagiri@radisys.com> Date: Thu Dec 15 17:39:14 2016 +0530 Adds rate_ctr_init in the startup of osmo-pcu Issue:Though the rate_ctr framework is used in osmo-pcu for bts statistics, the interval counters are always 0. Fix:rate_ctr_init is added in the startup which arms the timer and hence the rate ctr intervals is displayed with proper values. Change-Id: Ib0f33d2de9406aa7436aa9aeb6a8dabdff96383b http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=da7250ad2c1cd5ddc7d3c6e1... commit da7250ad2c1cd5ddc7d3c6e10435a00b357ef8f7 Author: sivasankari <Sivasankari.Theerthagiri@radisys.com> Date: Fri Dec 16 12:57:18 2016 +0530 Add counter at BTS level And statistics at TBF/MS level. Adds spb counters at BTS level(show bts statistics). Adds RLC/MAC downlink control msg at ms level(show ms imsi <imsi_val>). Adds the number of coding schemes counter for UL at TBF level. Change-Id: Icbe4ba95e34bea89ee36f532d099db68204b7c38 http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=963cdaffd5d2ba698010c7c4... commit 963cdaffd5d2ba698010c7c4000792487e07a2e8 Author: Harald Welte <laforge@gnumonks.org> Date: Sat Nov 26 15:24:06 2016 +0100 Fix uninitialized members in pcu_l1_meas() Change-Id: I76a03c9f54be474ab9ece908ef782807d555c6ac Fixes: Coverity CID 57952 http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=1f2bb6e93e71b64f0dce6d64... commit 1f2bb6e93e71b64f0dce6d64420c5b62a6847e85 Author: Harald Welte <laforge@gnumonks.org> Date: Sat Nov 26 15:22:08 2016 +0100 struct pcu_l1_meas_ts: initialize ms_i_level Change-Id: I93de7589d746b91ba26b1b36bf2690f125277cd0 Fixes: Coverity CID 57953 http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=5395073fff9870e823587211... commit 5395073fff9870e82358721126062d501ea4ad31 Author: sivasankari <Sivasankari.Theerthagiri@radisys.com> Date: Thu Dec 8 17:15:17 2016 +0530 Add statistics in the ms and tbf level. Adds DL throughput in show ms imsi <imsi_value>. Adds the number of coding schemes counter and rlc nacked counter at TBf level. Change-Id: Ia95b0404989b00db0e7ba416bc40d09ef41fde1c http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=cc4214a4290a1d764d511b90... commit cc4214a4290a1d764d511b90beb48d55332b2bd1 Author: aravind sirsikar <arvind.sirsikar@radisys.com> Date: Fri Dec 9 16:12:42 2016 +0530 Sanitizer build fix for TbfTest Change-Id: Ia6993fd6f89c9d9ed00ec6cb4b27953e72fa1f52 http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=0e63644d14b1e4513241739c... commit 0e63644d14b1e4513241739ca67f3bf88d5093db Author: Mrinal Mishra <mrinal.mishra@radisys.com> Date: Mon Nov 28 19:46:50 2016 +0530 Add debugging log for RLC data block decoding Added debugging log for RLC UL Data Block decoding for both GPRS/EGPRS cases. Change-Id: I8c197bdc4cd1330cbab0adfd188336d27682cec4 http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=34bfbdaf9e94bc22e2516f32... commit 34bfbdaf9e94bc22e2516f32b9f5c8c088a19628 Author: Neels Hofmeyr <nhofmeyr@sysmocom.de> Date: Wed Nov 30 00:37:32 2016 +0100 debian: fix: add pcuif_proto.h to osmo-pcu.install Following 68fc12775fac03e5e26a008dfa68c92498bfb772 'Install the pcuif_proto.h header file' we need to add pcuif_proto.h to the debian install file. Change-Id: Ib8e185900826baadcc96fcde1491903dbaf85f8b http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=168911b43855247916ec9e05... commit 168911b43855247916ec9e05fd61fe96ba3c9fcf Author: sivasankari <Sivasankari.Theerthagiri@radisys.com> Date: Fri Nov 25 19:53:36 2016 +0530 Add new BTS level counters Adds counters for Immediate Assignment Reject, Packet Access Reject, Channel Request Description and Final Block resend. Change-Id: I23e326d4ea489aa4967e452fe02773b44ab146f7 http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=68fc12775fac03e5e26a008d... commit 68fc12775fac03e5e26a008dfa68c92498bfb772 Author: Harald Welte <laforge@gnumonks.org> Date: Wed Nov 16 22:48:33 2016 +0100 Install the pcuif_proto.h header file So far, we used to keep a copy of the header file around in both osmo-pcu and osmo-bts projects. Before we start introducing a third copy in openbsc, let's have the osmo-pcu install the header file and make the other programs use that. Change-Id: I60976c9be5488256d1ff55fdc5aa548e3705400d http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=5d93f0f4eceda7bef29e27e6... commit 5d93f0f4eceda7bef29e27e6ec521c1e56640c25 Author: Harald Welte <laforge@gnumonks.org> Date: Thu Nov 17 21:07:56 2016 +0100 Fix GSMTAP logging in case direct PHY access is enabled In the existing code, GSMTAP messages were only generated in case no direct PHY access was being used (i.e. in the case all user traffic goes over the PCU socket). I'm not quite sure what the reason is for that would be and conclud this is not intentional. Let's first send the message to GSMTAP and then decide whether to send it via the direct PHY access or via the PCU socket into the BTS/BSC. Change-Id: I5d2e018f7009cb947abc874881c0c440feca3ade http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=bb47d957a8931669b8f2ab59... commit bb47d957a8931669b8f2ab59b20cb0beef629b38 Author: Harald Welte <laforge@gnumonks.org> Date: Thu Nov 17 18:40:02 2016 +0100 pcu_l1_if: get rid of magic numbers and use ARRAY_SIZE() for array iteration Change-Id: I61d00950b4eb0b8bcbaf386d5081be84580dac75 http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=f86307e1e4dfa11dd5bedf74... commit f86307e1e4dfa11dd5bedf74395382a0774a9ba6 Author: Mrinal Mishra <mrinal.mishra@radisys.com> Date: Thu Nov 10 18:16:30 2016 +0530 Add BTS level counters Adds counters for MCS blocks, 11 bit Rach counters and others. Change-Id: I605b0d66eb217decd35cbb8f87abfa577760245a http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=ed3413e39740c78148719696... commit ed3413e39740c78148719696b0903874add580e2 Author: aravind sirsikar <arvind.sirsikar@radisys.com> Date: Fri Nov 11 17:15:10 2016 +0530 Handle packet access reject during EPDAN/PDAN with channel description When PDAN/EPDAN with channel description is received, PCU will generate the packet access reject if no resources are present. The encoding is done based on section 7.1.3.2.1 and 8.1.2.5 of 44.060 version 7.27.0 Release 7. This patch also includes the test case to validate the generated packet access reject message. This patch is integration tested on Osmo-trx setup with Ettus B210 board and LG F70 MS with some simulation code changes in Osmo-pcu. Change-Id: I096a3bb44a65533b9e9b091925dd5f70a8696d6 http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=c0c3afd0794c217e6fc33b18... commit c0c3afd0794c217e6fc33b18eb9366c8cfe8b020 Author: aravind sirsikar <arvind.sirsikar@radisys.com> Date: Wed Nov 9 16:27:00 2016 +0530 Handle Immediate assignment reject When RACH is received, PCU will generate the Immediate assignment reject message if no resources are present. The encoding is done based on section 9.1.20 of 44.018 version 11.7.0 Release 11. This patch also includes the test case to validate the generated Immediate assignment reject message. This patch is integration tested on Osmo-trx setup with Ettus B210 board and LG F70 MS with some simulation code changes in Osmo-pcu. Change-Id: I3d33e2b9746fa4f338fad0e6b63b1c5f07de6f9b http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=ae4838101a58feb512e88325... commit ae4838101a58feb512e88325efcae79f46af8e32 Author: Max <msuraev@sysmocom.de> Date: Thu Jul 28 12:03:08 2016 +0200 Handle Timing Advance IE properly Move writing Timing Advance IE and Timing Advance Index into separate functions to simplify adding PTCCH support. This also fixes previous incorrect (and unused) code for writing Packet TA IE which has not set TS for TA. Change-Id: I786bf7fc999d401cc3d9e7f1e7a1fba953b5d458 Related: OS#1545 http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=fb41afaaf69f1abeb56b1d95... commit fb41afaaf69f1abeb56b1d95c0c707448e209b70 Author: aravind sirsikar <arvind.sirsikar@radisys.com> Date: Wed Nov 2 15:48:00 2016 +0530 EGPRS: fix for EPDAN out of window Fix alignment of EPDAN outside the RLC transmit window, according to section 9.1.8.2.4 in 44.060 version 7.27.0 Release 7. The specification explains that a bit within the uncompressed bitmap whose corresponding BSN is not within the transmit window shall be ignored. Without this fix PCU was dropping the EPDAN message and not updating the status of BSNs which are inside the RLC window. This patch updates the status of the BSNs which are inside the window and ignores the remaining bits. Related: OS#1789 Change-Id: Id07d178970f168f5389016c1eea31eb6b82057b6 http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=9434e52af988cf724b1974a3... commit 9434e52af988cf724b1974a3911f46d14e6f4846 Author: aravind sirsikar <arvind.sirsikar@radisys.com> Date: Wed Nov 2 15:41:48 2016 +0530 Modify return type of gprs_rlc_dl_window::distance to uint16_t Since there is a "&mod_sns()" present in this function, the outcome is always unsigned. Change-Id: I66f3db4dc27a6cbef146c832bf8b43f1492358a4 http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=f276138202d528ecdd62cbae... commit f276138202d528ecdd62cbae5d28d1768de4c349 Author: aravind sirsikar <arvind.sirsikar@radisys.com> Date: Tue Oct 25 12:45:24 2016 +0530 EGPRS: add test case to show EPDAN BSN out of window bug This patch adds a test case test_tbf_epdan_out_of_rx_window, which expects a current bug with EPDAN for interpretation of the bitmap explained in section 9.1.8.2.4 in 44.060 version 7.27.0 Release 7. The specification explains that a bit within the uncompressed bitmap whose corresponding BSN is not within the transmit window shall be ignored. But current PCU implementation drops the EPDAN and does not update status of the BSN which are inside the window. The test's expectation is corrected along with the bug fix in a subsequent commit. Related: OS#1789 Change-Id: If32b67f5c05707155281128b776a90a1e3d587b2 http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=d453eaa788e10b04772de1b1... commit d453eaa788e10b04772de1b1efd857c1e7275753 Author: Mrinal Mishra <mrinal.mishra@radisys.com> Date: Wed Oct 26 15:41:56 2016 +0530 Add logging support This commit adds the TRX_ID in the output of VTY command "show tbf all". Change-Id: Ia5412dddb899e20963f884e02bdf796b6ea7ee6c http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=f868bdbe76c71abc602f0e8e... commit f868bdbe76c71abc602f0e8e3fc6ea48fe5c3e7f Author: Neels Hofmeyr <nhofmeyr@sysmocom.de> Date: Mon Oct 10 00:55:12 2016 +0200 jenkins.sh: use osmo-build-dep.sh, output testlogs Also make cosmetically similar to the other jenkins.sh scripts in various osmo repositories. Change-Id: I34c19ed7c80aa56bd131f738f37324aed1cd73db http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=d71e8b32e3e2f9c3856997e9... commit d71e8b32e3e2f9c3856997e945df2eb3afe2937c Author: Max <msuraev@sysmocom.de> Date: Mon Sep 19 16:17:06 2016 +0200 Use qbit-TA to update Timing Advance Separate qbit-TA to TA conversion into separate function and use it for computing and updating Timing Advance. Note: the code was tested with TA=0 only to make sure it does not introduce regressions. Change-Id: I96fdbb20b09fb85fdd9fb6dcf3c25f6bee7f80e4 Fixes: OS#1531 http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=4ea452689d545c455cf9c3ad... commit 4ea452689d545c455cf9c3ade87a3e2c86bf7771 Author: Neels Hofmeyr <neels@hofmeyr.de> Date: Wed Jun 8 15:27:40 2016 +0200 Revert "tbf: Add state WAIT_ASSIGN" This reverts commit f1a7b8fc6651f92a8b7f3f27b7ca05d07f4e44e0. Conflicts: tests/tbf/TbfTest.err The commit broke GPRS service at least for osmo-bts-sysmo on a SysmoBTS 1002 with current master of osmo-bts (ef30f50d5d6d5f863fc147d05ccdceb89284934e). The error observed is the following log output (was viewing both osmo-bts-sysmo and osmo-pcu logs interleaved): <0002> tbf.cpp:874 TBF(TFI=0 TLLI=0x00000000 DIR=UL STATE=WAIT ASSIGN) T3169 timeout during transsmission <0002> tbf.cpp:893 - Assignment was on CCCH <0002> tbf.cpp:899 - No uplink data received yet <0007> l1sap.c:904 RACH for packet access <0001> pcu_l1_if.cpp:311 RACH request received: sapi=1 qta=0, ra=121, fn=13653 [repeat] When removing this single commit from current osmo-pcu master, GPRS service works well on SysmoBTS, with current osmo-bts master. The TbfTest.err expected output needed adjustment after the revert. Disclaimer: I am not aware of adverse effects this commit may have. I have no idea what the WAIT_ASSIGN state is used for -- further review is required. Change-Id: I1532f8e93194368cdc1e3846f82afa6d68cd5fbd http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=e4727a3591c4c4d769d89080... commit e4727a3591c4c4d769d890806b159ade9af3f6aa Author: Alexander Couzens <lynxis@fe80.eu> Date: Tue Jun 7 14:31:29 2016 +0200 llc: remove NULL-pointer check of gprs_llc_queue::size()/octets() All callers now check the pointer before calling it. gcc6 is optimizing `if (!this) {CODE}` as this is assumed to never be a std::nullptr here. Change-Id: I918a094e0dc59098a9eb00d152c9ae42d36b3a99 http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=d38b92e972be130df3e6c908... commit d38b92e972be130df3e6c908fb7e7bf1729ab7fb Author: Alexander Couzens <lynxis@fe80.eu> Date: Sun Aug 21 19:38:30 2016 +0200 tbf: add llc_queue_size() to check llc_queue is valid before calling size() gcc6 is optimizing if (!this) {CODE} as this is assumed to never be a std::nullptr here. Move the null check to the caller. In preparation of removing the check within llc_queue->size(), all callers must check the object before calling it. Make sure of that: make the llc_queue() access function protected and offer only a public llc_queue_size() function that incorporates the NULL check. All current callers are only interested in the llc_queue_size(). Tweaked-by: nhofmeyr Change-Id: I88cc3180f8f86785e3f07981895dabddf50b60a2 http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=0a4a6c120040c8dd0744f745... commit 0a4a6c120040c8dd0744f745e08f24624df62647 Author: Pravin Kumarvel <pmanohar@radisys.com> Date: Mon Oct 17 11:00:57 2016 +0530 EGPRS: Add EPDAN CRBB Tree based decoding Implemented tree based algorithm to decode compressed bitmap in EPDAN as described in section 9.1.10 of 3GPP 44.060. This algorithm intends to improve the performance over existing method. New Regression test is added under bitcomp directory. Test case is added to validate decompressed result of the bitmap Present in EPDAN. Test is done for multiple bitmaps of varying length. Invalid inputs are also part of the test vector. Change-Id: Ieae1992ed4b02bb1e09eec2d3de1a030eabd16ce http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=6348aea6a2cdc753021e5324... commit 6348aea6a2cdc753021e5324a0dd2aecf8791f10 Author: Neels Hofmeyr <nhofmeyr@sysmocom.de> Date: Fri Sep 30 16:25:16 2016 +0200 build: add -Wall I noticed that unused variables are not complained about by the build. Let's add -Wall. I also noticed that the Makefile.ams include STD_DEFINES_AND_INCLUDES, which is never set in configure.ac, so using that to add -Wall to all build contexts. Change-Id: I16711cf5a1ef8bd611074b3dd486ed7a0ae9df64 http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=da66f71ffeee47575d0fc0c3... commit da66f71ffeee47575d0fc0c3c2c6fb304d50e3cc Author: Neels Hofmeyr <nhofmeyr@sysmocom.de> Date: Sat Oct 1 00:52:10 2016 +0200 configure: check for pkg-config presence Change-Id: Iaaeb2a926fc3832793dfb3f02e4ced2500950997 http://cgit.osmocom.org/radisys/osmo-pcu/commit/?id=da933e0ff8a63943a1f738c7... commit da933e0ff8a63943a1f738c7172a9c7ede972849 Author: Neels Hofmeyr <nhofmeyr@sysmocom.de> Date: Sat Oct 1 00:35:06 2016 +0200 build: be robust against install-sh files above the root dir Explicitly set AC_CONFIG_AUX_DIR. To reproduce the error avoided by this patch: rm install-sh # in case it was already generated. touch ../install-sh # yes, outside this source tree autoreconf -fi This will produce an error like ... configure.ac:16: error: required file '../ltmain.sh' not found configure.ac:5: installing '../missing' src/Makefile.am: installing '../depcomp' autoreconf: automake failed with exit status: 1 See also automake (vim `which automake`) and look for 'sub locate_aux_dir'. Change-Id: Ie9a10f14c5e8c5e9b6ea4910b4b9abb7e70f5e04 ----------------------------------------------------------------------- hooks/post-receive -- UNNAMED PROJECT