openbsc.git branch neels/auth_tests_wip updated. 0.15.0-201-g7b97f90

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, neels/auth_tests_wip has been updated discards 7d8ea8bb5abad91c1d5aeb8d447fd92fe6bcb652 (commit) discards 131b6f2ee5ad820fd0a3c715b26eacd71673d509 (commit) discards 95b8adbd5ea2010b24807cdc89895bbab0f6bf0e (commit) discards bd7dd6ba922bf87d9a2a5e8b8a499e0dce6f5b3d (commit) discards 1f2c4ba3cefeef9dede5fae19de88fa0f896574b (commit) discards 0bdd1fda17a36567ea9b1b3073adedea4c2f5780 (commit) discards 23b1bc36045c2bbdb3cb6ddab0e7ee87b2fcbfcc (commit) via 7b97f901f0894bcc75f696a4e67a8bb4f90a9541 (commit) via fbf5e6f94f67694f03142e51773d3e50b1746a9b (commit) via 9f81ebad8c2a618a87b1e521a839d54e22eecd73 (commit) via 41d661d2ea91df076b165be9fa5fcfe952f67130 (commit) via 4631b5185cfcae8435f35c0cd56b282609a0952e (commit) via a7732be36d264d0775da82e6c78ec0183314653a (commit) via 2c6d4883d6beca6b252676112fce884389ebb57e (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (7d8ea8bb5abad91c1d5aeb8d447fd92fe6bcb652) \ N -- N -- N (7b97f901f0894bcc75f696a4e67a8bb4f90a9541) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=7b97f901f0894bcc75f696a4e67a8bb4… commit 7b97f901f0894bcc75f696a4e67a8bb4f90a9541 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Mar 26 14:01:57 2016 +0100 Fix MM Auth: zero-initialize auth tuple before first use Make sure a new auth tuple is initialized after db_get_lastauthtuple_for_subscr() returns an error, i.e. if no tuple is present for the subscriber yet. Before this patch, the first key_seq depended on the typically uninitialized value that was present in auth tuple's key_seq upon calling auth_get_tuple_for_subscr(). The very first key_seq used for a new subscriber will now always be 0. Before, it used to be mostly 1 ("(0 + 1) % 7"), but depended on whether the key_seq was indeed initialized with 0, actually by random. http://cgit.osmocom.org/openbsc/commit/?id=fbf5e6f94f67694f03142e51773d3e50… commit fbf5e6f94f67694f03142e51773d3e50b1746a9b Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Mar 26 13:44:38 2016 +0100 Fix MM Auth: disallow key_seq mismatch In auth_get_tuple_for_subscr(), add missing condition to match incoming key_seq with stored key_seq, so that re-authentication is requested for mismatching key_seqs. Add test for this issue. http://cgit.osmocom.org/openbsc/commit/?id=9f81ebad8c2a618a87b1e521a839d54e… commit 9f81ebad8c2a618a87b1e521a839d54e22eecd73 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Mar 26 01:41:08 2016 +0100 MM Auth: return AUTH_NOT_AVAIL instead of hardcoded zero AUTH_NOT_AVAIL == 0, so this is no functional change. http://cgit.osmocom.org/openbsc/commit/?id=41d661d2ea91df076b165be9fa5fcfe9… commit 41d661d2ea91df076b165be9fa5fcfe952f67130 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Mar 26 01:39:47 2016 +0100 MM Auth: introduce AUTH_ERROR constant. Instead of using hardcoded -1 for errors, include -1 in the enum auth_action type; apply its use. In the mm_auth test, the string output changes from '(internal error)' to 'AUTH_ERROR', since now the proper enum value is used in auth_action_names[]. http://cgit.osmocom.org/openbsc/commit/?id=4631b5185cfcae8435f35c0cd56b2826… commit 4631b5185cfcae8435f35c0cd56b282609a0952e Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Mar 26 12:10:48 2016 +0100 MM Auth test: add test to re-use existing auth http://cgit.osmocom.org/openbsc/commit/?id=a7732be36d264d0775da82e6c78ec018… commit a7732be36d264d0775da82e6c78ec0183314653a Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Mar 26 01:26:09 2016 +0100 MM Auth test: add two tests for AUTH_THEN_CIPH Test two situations for AUTH_DO_AUTH_THEN_CIPH: - when no auth tuple is available - when the key sequence from LU is marked invalid Add convenience auth tuple comparison function using stringification. http://cgit.osmocom.org/openbsc/commit/?id=2c6d4883d6beca6b252676112fce8843… commit 2c6d4883d6beca6b252676112fce884389ebb57e Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Mar 26 01:21:00 2016 +0100 Add MM Auth test; add auth_action_str() function Add basic MM Authentication test setup, with fake DB access and RAND_bytes(). So far implement simple tests for IO error during DB access and missing auth entry. To print the auth action during tests, add struct auth_action_names and auth_action_str() inline function in auth.[hc]. ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/auth.h | 17 ++++------------- openbsc/src/libmsc/auth.c | 9 +++++++++ 2 files changed, 13 insertions(+), 13 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)