16 Dec
2016
16 Dec
'16
4:12 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, lynxis/rbs2000 has been updated
via b0a32e58d11f7dd79272a178eef838980b980d41 (commit)
from 74cf9351db7997996b9b0b0886796c3aead712cd (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=b0a32e58d11f7dd79272a178eef83898…
commit b0a32e58d11f7dd79272a178eef838980b980d41
Author: Philipp <pmaier(a)sysmocom.de>
Date: Fri Dec 16 16:03:28 2016 +0100
sndcp: Allow empty SNDCP-XID indications
In some rare cases the modem might send a xid indication that does
not contain anything except the version number field. The sgsn
ignors such SNDCP-XID indications by stripping the entire field
from the response. We found a modem in the wild that started to
act problematic when the empty SNDCP-XID was missing in the
response. This patch changes the XID negotiation behaviour in
a way that if a modem should send empty SNDCP-XID indications,
the reply will also contain an empty SNDCP-XID indication. Apart
from that the SNDCP-XID version number is now parsed and echoed
in the response. This ensures that we always reply with the version
number that the modem expects. (The version was 0 in all cases we
observed so far)
-----------------------------------------------------------------------
Summary of changes:
openbsc/include/openbsc/gprs_sndcp_xid.h | 14 +++++----
openbsc/src/gprs/gprs_llc.c | 14 ++++-----
openbsc/src/gprs/gprs_sndcp.c | 25 +++++++--------
openbsc/src/gprs/gprs_sndcp_xid.c | 54 +++++++++++++++++++++-----------
openbsc/tests/sndcp_xid/sndcp_xid_test.c | 10 +++---
5 files changed, 68 insertions(+), 49 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)