This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "OpenBTS' transceiver retro-fit".
The branch, fairwaves/master has been deleted
was 2fb62ea45e8287821175558e1d75209b46355348
-----------------------------------------------------------------------
2fb62ea45e8287821175558e1d75209b46355348 Transceier52M: Make error response to an unknown command on UDP command interface more understandable.
-----------------------------------------------------------------------
hooks/post-receive
--
OpenBTS' transceiver retro-fit
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".
The branch, jerlbeck/master has been updated
discards 01f5df9589e83f97f9b15e31b06a53cfe4192e6d (commit)
discards d6108ac1e13b9701b4bc2c5b2dba360ac231b589 (commit)
discards 5a7dd909fe51a9925ca844cdfcba48e0a890fb56 (commit)
discards cfdd37fa164f8918fe6dea33b0212d01133f98e5 (commit)
discards e3859a113af4d7865831a7f778574f830de8b23f (commit)
via 57cf69a18ccceac4b250dceb56c4e0d5f0018a95 (commit)
via dd08ac86e6fa1ea69e78c344424d72fc9d79d6d7 (commit)
via bae33a70019e2344053eae3798856364cdb8aa12 (commit)
via 5e46a20e030a71816a20935befadf232968e1ff6 (commit)
via c135b878cd7a155431b4f000e9c00be07e157222 (commit)
via 1139ec1d0f20014bb17ea5d5cb65478b4489a8e7 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (01f5df9589e83f97f9b15e31b06a53cfe4192e6d)
\
N -- N -- N (57cf69a18ccceac4b250dceb56c4e0d5f0018a95)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
-----------------------------------------------------------------------
Summary of changes:
src/sba.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
hooks/post-receive
--
UNNAMED PROJECT
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".
The branch, jerlbeck/wip/pdch-alloc has been updated
discards aa148d0a0734d1cec5d588b20f81e1702c4014b9 (commit)
discards 0a6e06388875adb859d33712e68b583e77e5b7bb (commit)
discards 378d5075a42e6f3185f858a0b5b04dd8e42bafda (commit)
discards a64aa7a65defed38baf2b344240ddf16095a9051 (commit)
discards 5f16b96df993c8f44ed8ab64a39c20b9b2904db3 (commit)
discards f78593d6e83dd9f26bd1f9cc0e97dabf792a6d8a (commit)
discards cf01665b6bd4cc79276cb331ec20f9141c622eee (commit)
discards d31560624cd55371fc9d0a3f7b8d023f5dda3558 (commit)
discards 48d01a8e2fe77fa13d4f846ba730f43fa3166319 (commit)
discards c86d1933900fdf4c1a296fe6fba72512fe025958 (commit)
discards 0c8ebf5f511826419c37e04dd1363357c2b4ec35 (commit)
discards ec4f21ddec40a9091083c23ec1f040fd52525df9 (commit)
discards 0062976f9ba526c67544184f19e7d1216b3d5fcd (commit)
discards 4da768b26976cd10f20be32b460d374051b20b81 (commit)
discards 0023fbde402832765f083cd79a3e2fe382e8b8fe (commit)
discards 01f5df9589e83f97f9b15e31b06a53cfe4192e6d (commit)
discards d6108ac1e13b9701b4bc2c5b2dba360ac231b589 (commit)
discards 5a7dd909fe51a9925ca844cdfcba48e0a890fb56 (commit)
discards cfdd37fa164f8918fe6dea33b0212d01133f98e5 (commit)
discards e3859a113af4d7865831a7f778574f830de8b23f (commit)
via 27d9f3e9d45a7f7be15cd1b602cb94f8ab057c3e (commit)
via 563f35eb49be3d7f1ecdc3d230c81fe28315e607 (commit)
via 96a33c74849c8e92fd6e101fc633fdd27891f25e (commit)
via 58070d62c88586fda707b88df6d442b480137f78 (commit)
via ac4084f0c09fb3df0b1ff4cd0c406cf14b588d7d (commit)
via 8a99b7a87a7fb2940333a45e17fdb452fe485ae1 (commit)
via b4f2b917c24fe051d05366f78db7d2ccd22bd7ae (commit)
via 4095a641fed649f3a08873963253c2ab262f0281 (commit)
via 69c9bfa0897c63b8a220bdb8db6658dc5021e5da (commit)
via b2439bbb8a73f00873efd7f744f70be535496e90 (commit)
via 3a10dbd56428cf0e79b738f62748509bbd04aa68 (commit)
via e0853cdf42e60acd7759acd4869c84756eb1fa27 (commit)
via 5879c6493f74aecddc81abbd785065325bf2e117 (commit)
via 47a57f6f869f19704bbb993fc157a86fd0c85e58 (commit)
via 61205a7e6539b3926c3039e8dcabda6aa9b408ef (commit)
via 57cf69a18ccceac4b250dceb56c4e0d5f0018a95 (commit)
via dd08ac86e6fa1ea69e78c344424d72fc9d79d6d7 (commit)
via bae33a70019e2344053eae3798856364cdb8aa12 (commit)
via 5e46a20e030a71816a20935befadf232968e1ff6 (commit)
via c135b878cd7a155431b4f000e9c00be07e157222 (commit)
via 1139ec1d0f20014bb17ea5d5cb65478b4489a8e7 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (aa148d0a0734d1cec5d588b20f81e1702c4014b9)
\
N -- N -- N (27d9f3e9d45a7f7be15cd1b602cb94f8ab057c3e)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-pcu/commit/?id=27d9f3e9d45a7f7be15cd1b602cb94f…
commit 27d9f3e9d45a7f7be15cd1b602cb94f8ab057c3e
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jul 14 14:29:34 2015 +0200
pcu: Use alloc_algorithm_dynamic by default
The dynamic algorithm behaves like B until there are no TFI left.
This commit changes the default algorithm to to former.
Ticket: #1934
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=563f35eb49be3d7f1ecdc3d230c81fe…
commit 563f35eb49be3d7f1ecdc3d230c81fe28315e607
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jul 14 14:02:41 2015 +0200
alloc: Add counters for successful algo A/B allocations
This adds counters for algorithm A and B with count successful
allocation combined for UL and DL.
Ticket: #1934
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=96a33c74849c8e92fd6e101fc633fdd…
commit 96a33c74849c8e92fd6e101fc633fdd27891f25e
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jul 14 13:31:48 2015 +0200
alloc: Add 'dynamic' allocation algorithm
The idea behind this meta algorithm is to automatically select one of
the other algorithms based on the system state. Basically algorithm B
will be selected if the PDCH usage is low to improve throughput and
latency. Algorithm A will be selected to support more concurrent MS.
This commit adds a first simple state-less version of this algorithm
that always tries B first and only if that fails A is tried
afterwards.
The following VTY command is added to the 'pcu' node:
- alloc-algorithm dynamic
Ticket: #1934
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=58070d62c88586fda707b88df6d442b…
commit 58070d62c88586fda707b88df6d442b480137f78
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jul 14 12:57:07 2015 +0200
alloc: Remove disabled code fragment for multi-UL allocation
This part of algorithm_b has already been disabled. Further work may
depend on this, but it is going out of sync. So this commit removes
it completely.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=ac4084f0c09fb3df0b1ff4cd0c406cf…
commit ac4084f0c09fb3df0b1ff4cd0c406cf14b588d7d
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jul 14 11:35:21 2015 +0200
alloc: Refactor alloc algorithms to only apply changes on success
Currently these algorithms modify other objects (MS, TBF, PDCH) even
if the allocation will fail later on. To implement an algorithm that
dynamically tries another algorithm on failure (e.g. A after B), the
first (failing) algorithm should not change or damage anything.
This commit refactors algorithm A and B to delay the actual allocation
until it is known that the allocation will not fail.
Ticket: #1934
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=8a99b7a87a7fb2940333a45e17fdb45…
commit 8a99b7a87a7fb2940333a45e17fdb452fe485ae1
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jul 14 08:26:17 2015 +0200
alloc: Optionally enforce first common TS in find_multi_slots (TODO)
TODO:
- This isn't probably triggered at all currently, so this commit
can possibly be dropped
http://cgit.osmocom.org/osmo-pcu/commit/?id=b4f2b917c24fe051d05366f78db7d2c…
commit b4f2b917c24fe051d05366f78db7d2ccd22bd7ae
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jul 13 15:15:18 2015 +0200
alloc: Remove redundant first_common_ts handling
Currently this code path is only used, if an allocation has been
taken place in a former call to an allocation algorithm function.
If this was for an DL TBF, the first common TS was selected,
otherwise the least used common TS was selected for an UL TBF.
The shrinking of the UL set (to 1<<first_common_ts) is done in the
latter case.
This commit removes an additional code path that aligns the UL set to
first_common_ts, because it has no more influence on the set of
common TS after both UL and DL TBF have been allocated.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=4095a641fed649f3a08873963253c2a…
commit 4095a641fed649f3a08873963253c2ab262f0281
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jul 13 14:50:08 2015 +0200
alloc/test: Add test for interleaved TBF chains
MS iniated TCP connections generally result in a sequence
of short time UL and longer lasting DL TBFs, being interleaved
between several MS. This scenario is not covered by the existing
tests.
This commit adds a test, that allocates as man as possible TBFs
several times with different test modes without clearing the BTS (and
thus the TBF list) in between. The number of allocated DL TBFs in
each round is expected to be constant.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=69c9bfa0897c63b8a220bdb8db6658d…
commit 69c9bfa0897c63b8a220bdb8db6658dc5021e5da
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jul 13 14:38:18 2015 +0200
alloc/test: Put TBF allocation loop into alloc_many_tbfs
Currently all TBFs are deleted after the allocation loop finishes.
This make it difficult to interleave the TBF allocation like it
happens with real MS.
This commit refactors the allocation loop into alloc_many_tbfs and
adds support for TLLIs, which are derived from the counter value and
used to retrieve an old MS object if alloc_many_tbfs is called a
second time.
Note that this does not make a difference for the existing tests.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=b2439bbb8a73f00873efd7f744f70be…
commit b2439bbb8a73f00873efd7f744f70be535496e90
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jul 13 14:23:32 2015 +0200
ms: Add is_idle() method to GprsMs::Guard
Currently there is no simple way to determine, whether the MS object
protected by a guard will continue to exist after the guard object is
destroyed.
This patch adds a is_idle() method that will return true if the MS
object is just kept by the guard from being idle. In that case, the
MS object would either be deleted or return true for
GprsMs::is_idle() after the guard's destruction, provided that no
TBF attachment took place in between.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=3a10dbd56428cf0e79b738f62748509…
commit 3a10dbd56428cf0e79b738f62748509bbd04aa68
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Jul 10 19:52:37 2015 +0200
tbf: Put the TFI->TBF mapping into the PDCH objects
Currently the TBFs are registered in a TFI indexed array within the TRX
objects. TBFs can be searched globally by TFI and TRX number. This
conflicts with the use of the same TFI for different TBF on different
PDCH. This use case requires the specification of the PDCH as
additional search dimension.
This commit moves the TFI index TBF arrays into the PDCH objects. The
related methods are updated accordingly.
Ticket: #1793
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=e0853cdf42e60acd7759acd4869c847…
commit e0853cdf42e60acd7759acd4869c84756eb1fa27
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Jul 10 12:25:25 2015 +0200
alloc: Allocate TFI per slot (algorithm A)
Currently the TFI are managed per TRX, thus only a maximum of 32 TBF
per direction and per TRX are possible simultaneously.
This commit modifies algorithm_a() to allow the sharing of TFI
between different PDCH. Since algorithm A only assigns a single slot
to each TBF, the TFI of each PDCH can be assigned independently.
This increases the maximum to 32 TBF per direction and per PDCH
concerning the TFI allocation.
Ticket: #1793
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=5879c6493f74aecddc81abbd7850653…
commit 5879c6493f74aecddc81abbd785065325bf2e117
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Jul 10 10:41:36 2015 +0200
tbf: Move TFI selection into alloc_algorithm
Currently the TFI and the TRX have to be determined before the actual TBF
allocation function is called, passing TFI and TRX number as
parameters. This does fit to TFI reuse for different slots, since
this were tightly coupled with the slot selection.
This commit just moves the TFI selection into the alloc_algorithm
functions. The tfi parameter is removed from the the TFI alloc
functions. The trx parameter is changed into use_trx to optionally
limit the trx selection (same semantics like in tfi_find_free).
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=47a57f6f869f19704bbb993fc157a86…
commit 47a57f6f869f19704bbb993fc157a86fd0c85e58
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Jul 8 12:53:16 2015 +0200
pdch: Manage TFIs per direction
Currently a single bit set is used to maintain a set of used TFI
without distinguishing between uplink and downlink. Since the
namespaces of UL and DL TFI are separate, this implementation is
not correct.
This commit changes gprs_rlcmac_pdch to use a separate bit set for
each direction. It also replace the corresponding conditional fprintf
statement in check_tfi_usage (AllocTest.cpp) by an equivalent
OSMO_ASSERT.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=61205a7e6539b3926c3039e8dcabda6…
commit 61205a7e6539b3926c3039e8dcabda6aa9b408ef
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Jul 9 11:35:50 2015 +0200
alloc/test: Check for TFI conflicts
This commit adds the check_tfi_usage function that checks the TFI
usage. It iterates through all TBFs, records on which PDCH it uses
which TFI and check for conflicts. It also checks the bits returned
by pdch->assigned_tfi(). The latter suffers from an bug in that
method (no separation of uplink and downlink), so a conditional
fprintf is used instead of an assertion. The method tfi_find_free
is checked for conflicts after allocations.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=57cf69a18ccceac4b250dceb56c4e0d…
commit 57cf69a18ccceac4b250dceb56c4e0d5f0018a95
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Jul 8 12:18:33 2015 +0200
alloc: Fix MS_B/MS_C interpretation
Currently the handling of MS_B and MS_C is not compliant with TS
45.002, annex B.1. These values may only interpreted as 0, if
frequency hopping is not enabled and if there is no change from Rx to
Tx or vice-versa.
This commit sets Ttb/Trb to 1 if the table entry is MS_B/MS_C, since
only combined down/up access modes are supported.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=dd08ac86e6fa1ea69e78c344424d72f…
commit dd08ac86e6fa1ea69e78c344424d72fc9d79d6d7
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Jul 9 12:06:56 2015 +0200
alloc: Do not use masking for multislot class type 2 MS
Currently the masks are computed equally for each class type. This
does not make much sense for class type 2 MS, since those are capable
to work in full duplex mode.
This commit sets the masks to 0xff for class type 2 MS.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=bae33a70019e2344053eae379885636…
commit bae33a70019e2344053eae3798856364cdb8aa12
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jul 6 14:55:13 2015 +0200
alloc: Select applicable Tta/Tra
According to TS 45.002, 6.4.2.2 the choice whether Tta or Tra has to
be applied, depends on the medium access mode (currently always
dynamic) and the number of UL/DL slots. Currently either value can be
used which might result in combinations not covered by the spec.
This commit changes find_multi_slots() to skip non-compliant
combinations.
Note that this code will have to be extended, if other medium
access modes are implemented.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=5e46a20e030a71816a20935befadf23…
commit 5e46a20e030a71816a20935befadf232968e1ff6
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Jul 9 11:48:23 2015 +0200
alloc: Use an enum instead of numbers to select the mask
The local enums MASK_TT and MASK_TR replace the hard coded indices.
The variable m_idx is renamed to mask_sel for more clarity.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=c135b878cd7a155431b4f000e9c00be…
commit c135b878cd7a155431b4f000e9c00be07e157222
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Jul 9 13:44:18 2015 +0200
alloc: Merge find_least_busy_pdch and find_least_reserved_pdch
Both functions only differ in the computation of the value for
num_tbfs.
This commit merge both functions and adds a parameter containing a
function for that compuation.
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
src/sba.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
hooks/post-receive
--
UNNAMED PROJECT
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".
The branch, master has been updated
via 1139ec1d0f20014bb17ea5d5cb65478b4489a8e7 (commit)
from 3db617f14a0314a0e2a233b3ddaba1501213c0e5 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-pcu/commit/?id=1139ec1d0f20014bb17ea5d5cb65478…
commit 1139ec1d0f20014bb17ea5d5cb65478b4489a8e7
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Jul 15 14:17:19 2015 +0200
sba: Fix loop exit in SBAController::alloc (Coverity)
The commit 506f156f7a4aebb52dace00a760f86b2b4f5e19a has reverted the
TS search order. The outer loop exit condition was not updated
accordingly. This bug would would only lead to an error if there were
multiple TRX where the first TRX has not got any PDCH assigned.
This commit corrects the break condition.
Fixes: Coverity CID 1311776
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
src/sba.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
hooks/post-receive
--
UNNAMED PROJECT
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".
The branch, jerlbeck/wip/pdch-alloc has been updated
discards 50076d7a18e03fee84017df4066efa1429904c41 (commit)
discards ba39f92b58e69d6c1d7268bb2b8f90d0ff199a41 (commit)
discards a58d17131f2f6f7aca4f2479a0348ce04625fbfe (commit)
via aa148d0a0734d1cec5d588b20f81e1702c4014b9 (commit)
via 0a6e06388875adb859d33712e68b583e77e5b7bb (commit)
via 378d5075a42e6f3185f858a0b5b04dd8e42bafda (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (50076d7a18e03fee84017df4066efa1429904c41)
\
N -- N -- N (aa148d0a0734d1cec5d588b20f81e1702c4014b9)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-pcu/commit/?id=aa148d0a0734d1cec5d588b20f81e17…
commit aa148d0a0734d1cec5d588b20f81e1702c4014b9
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jul 14 14:29:34 2015 +0200
pcu: Use alloc_algorithm_dynamic by default
The dynamic algorithm behaves like B until there are no TFI left.
This commit changes the default algorithm to to former.
Ticket: #1934
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=0a6e06388875adb859d33712e68b583…
commit 0a6e06388875adb859d33712e68b583e77e5b7bb
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jul 14 14:02:41 2015 +0200
alloc: Add counters for successful algo A/B allocations
This adds counters for algorithm A and B with count successful
allocation combined for UL and DL.
Ticket: #1934
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=378d5075a42e6f3185f858a0b5b04dd…
commit 378d5075a42e6f3185f858a0b5b04dd8e42bafda
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jul 14 13:31:48 2015 +0200
alloc: Add 'dynamic' allocation algorithm
The idea behind this meta algorithm is to automatically select one of
the other algorithms based on the system state. Basically algorithm B
will be selected if the PDCH usage is low to improve throughput and
latency. Algorithm A will be selected to support more concurrent MS.
This commit adds a first simple state-less version of this algorithm
that always tries B first and only if that fails A is tried
afterwards.
The following VTY command is added to the 'pcu' node:
- alloc-algorithm dynamic
Ticket: #1934
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
hooks/post-receive
--
UNNAMED PROJECT
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".
The branch, zecke/wip has been created
at 410d98e5d0c0eae76221a2d62a837b962f082506 (commit)
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-pcu/commit/?id=410d98e5d0c0eae76221a2d62a837b9…
commit 410d98e5d0c0eae76221a2d62a837b962f082506
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Jul 2 15:48:25 2015 +0200
alloc: Use least reserved PDCH for algo A (TODO)
TODO:
- unify find_least_reserved_pdch and find_least_busy_pdch or
- force find_multi_slots to single slot reservation
http://cgit.osmocom.org/osmo-pcu/commit/?id=eff0c350c848c642efad7ebe478a52c…
commit eff0c350c848c642efad7ebe478a52c2c8c351ce
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Jul 2 15:10:20 2015 +0200
Revert "ms: Delay the call to set_reserved_slots(NULL, 0,0) (EXPERIMENTAL)"
This reverts commit 341c9189caf00c077ef73138d087bf29e3ae12d1.
http://cgit.osmocom.org/osmo-pcu/commit/?id=a0ea29a5968308224b24b8718a8baa0…
commit a0ea29a5968308224b24b8718a8baa09806ad645
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Jul 2 14:35:57 2015 +0200
FIXUP bts: Add Poll Timeout counter (TODO)
http://cgit.osmocom.org/osmo-pcu/commit/?id=bdcfb71161aed1dd882ec7f9dcc4880…
commit bdcfb71161aed1dd882ec7f9dcc4880146175155
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Jul 2 13:19:49 2015 +0200
sba: Reverse TS search order (TODO)
- when using multiple TS the first TS cannot be used for UL
eventually if a TBF is still active or releasing.
- Currently RACH requests are often accompanied by poll timeouts
- This cannot prevent them completely (especially with multiple TRX
in the future)
http://cgit.osmocom.org/osmo-pcu/commit/?id=70960fb90cf4ab5efa2851f6927e53b…
commit 70960fb90cf4ab5efa2851f6927e53bb14878512
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Jul 2 12:54:26 2015 +0200
bts: Add Poll Timeout counter (TODO)
http://cgit.osmocom.org/osmo-pcu/commit/?id=9eb88f2348ce449deac1022950998ec…
commit 9eb88f2348ce449deac1022950998ecef372a67b
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Jul 2 12:34:26 2015 +0200
tbf: Remove call to update() in reuse_tbf (TODO)
http://cgit.osmocom.org/osmo-pcu/commit/?id=5ef6a6028a1ed8aa59d3b2a701d53e4…
commit 5ef6a6028a1ed8aa59d3b2a701d53e4737c15478
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Jul 2 12:04:20 2015 +0200
tbf: Set ms in call to tbf_alloc_dl_tbf (TODO)
- reuse
- alloc didn't know slot reservation
TODO:
- cm
http://cgit.osmocom.org/osmo-pcu/commit/?id=341c9189caf00c077ef73138d087bf2…
commit 341c9189caf00c077ef73138d087bf29e3ae12d1
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Jul 2 10:48:09 2015 +0200
ms: Delay the call to set_reserved_slots(NULL, 0,0) (EXPERIMENTAL)
TODO:
- Check whether this fixes the issues.
http://cgit.osmocom.org/osmo-pcu/commit/?id=f5082f9372efa00090519a1b133b7ee…
commit f5082f9372efa00090519a1b133b7eee88ea0d61
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Jul 2 10:47:37 2015 +0200
ms: Clear the reserved slots in the destructor (FIXUP)
http://cgit.osmocom.org/osmo-pcu/commit/?id=6b3a27be054a2cc4667a22a4c435cd5…
commit 6b3a27be054a2cc4667a22a4c435cd5d7ecb59ce
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jun 30 14:48:13 2015 +0200
alloc: Disable inner loop debugging by default (TODO)
Callgrind: 42%-> 25%
http://cgit.osmocom.org/osmo-pcu/commit/?id=596f547a378786b2a9dea5a3b1e6182…
commit 596f547a378786b2a9dea5a3b1e6182abf794e60
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jun 30 14:34:24 2015 +0200
alloc: Optimize find_free_usf
According to callgrind, this function consumes 33% CPU when running
the AllocTest program.
This commit uses the assigned_usf() method to get the USFs allocated
by a PDCH instead of traversing the TBFs.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=eb22ef5c755a3bacda653185f4ce634…
commit eb22ef5c755a3bacda653185f4ce63402bd95d93
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jun 30 14:10:13 2015 +0200
tbf: Keep a set of used TFI and USF per PDCH (TODO)
http://cgit.osmocom.org/osmo-pcu/commit/?id=1e64bdbe3f7304fe5c5098ae0738d1f…
commit 1e64bdbe3f7304fe5c5098ae0738d1ff06f14ad1
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jun 30 13:43:52 2015 +0200
FIXUP tbf: Maintain the number of TBF per PDCH
http://cgit.osmocom.org/osmo-pcu/commit/?id=4d4fb6597592dc16795868ab24cb906…
commit 4d4fb6597592dc16795868ab24cb9063765c5fb9
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jun 30 13:40:18 2015 +0200
alloc: Skip common TS without free USF when rating (TODO)
http://cgit.osmocom.org/osmo-pcu/commit/?id=8cee5c6d06ebc743414df3b3d8ea4af…
commit 8cee5c6d06ebc743414df3b3d8ea4af462db0851
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Jul 1 13:10:41 2015 +0200
alloc: Only reserve 1 UL slot with algorithm B (TODO)
Since currently the algorithm B will only allocate a single UL slot
and will have to stick to it (first common TS), the other possible UL
slots will not be allocated while the reservation is kept.
This commit adds code to update the reserved set of UL slots to the
single common TS when the UL TBF is allocated.
TODO:
- test it
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=53cf1d4da78852cc168246cca1f4caa…
commit 53cf1d4da78852cc168246cca1f4caa7e9acf837
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Jul 1 12:27:30 2015 +0200
alloc: Set minimum slot capacity to 1 (TODO)
- < 0 can only happen rarely (if at all ATM)
- doesn't change anything
TODO:
- test it anyway
http://cgit.osmocom.org/osmo-pcu/commit/?id=3ac16ddac029d00f71bfe722cb25d66…
commit 3ac16ddac029d00f71bfe722cb25d66c26961fc7
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Jul 1 12:19:40 2015 +0200
alloc: Only use common UL slots when calculating the capacity
Currently al possible UL slots are included in the capacity
calculation which is the base of the slot selection. Nevertheless
UL-only slots will never be used, since only one uplink slot (which
must be a common slot) will be used.
This patch changes the code to only include common slots in the
capacity sum.
Note that this might not be optimal if algorithm B supported
multiple uplink slots.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=0bb98075f4046e55c48478520752b09…
commit 0bb98075f4046e55c48478520752b09f71b545e0
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jun 22 16:14:23 2015 +0200
WIP Algorithm B UL (TODO)
Select UL slot based on slot usage (similar to algorithm A)
- Ensure to keep the first common TS
TODO:
- cm
http://cgit.osmocom.org/osmo-pcu/commit/?id=3c9fcfadc825256987ecb259b793c2f…
commit 3c9fcfadc825256987ecb259b793c2f85ed5d21c
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jun 30 10:24:37 2015 +0200
alloc: Base algo A on reserved PDCHs
Currently algorithm A bases its time slots selection on the number of
TBF actively using the PDCHs. This statistically prefers the first
time slots, especially with short living TBFs. So when the first TBF
is triggered by an uplink transfer (which generally results in a
short-lived TBF) the potentially longer living DL TBF will be bound
to the same slot. When another MS then requests an uplink TBF, it
will get the same slot (no UL TBF currently active).
This commit changes the algorithm to base its selection on reserved
slots instead.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=ea061943e0d4179822224d7830d0f14…
commit ea061943e0d4179822224d7830d0f147ce90ba2c
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jun 30 09:44:05 2015 +0200
alloc: Ignore slots with differing TSC if multiple slots are requested
According to TS 45.002, 6.4.2 the training sequence (TSC) must be the
same for all slots in a multi-slot set.
This commit updates find_possible_pdchs() to only consider slots with
the same TSC if more that 1 slot shall be assigned.
Note that the first PDCH's TSC will be used as reference, so if two
or more groups with a common TSC are configured, only the first will
be used. This restriction does not apply to algorithm A, since it
will not assign more than one slot and therefore sets the max_slots
parameter to 1.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=bbdca1b43caaa47ae71e35872909c25…
commit bbdca1b43caaa47ae71e35872909c25ffc091900
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jun 30 09:18:30 2015 +0200
ms: Get the set of slots currently active
This commits adds methods to GprsMs and gprs_rlcmac_tbf to retrieve
the slots that are actively used.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=b70f7ca553b4747618383b5c631f702…
commit b70f7ca553b4747618383b5c631f7023dc0b2f84
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jun 30 08:52:54 2015 +0200
ms: Add support for slot reservation
In contrast to the slots currently used by existing TBFs, the
reserved slots refer to the time slots that can be used for newly
allocated TBFs without causing conflicts (given that the first common
TS does not change). They correspond to the potential use of the
PDCHs and can be used to achieve a more uniform slot allocation.
This commit adds bit set based methods to GprsMs and gprs_rlcmac_trx
and a counter to gprs_rlcmac_pdch. The current TRX will also be
stored in the MS object.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=7e32903033af3f93dfe397e55de5498…
commit 7e32903033af3f93dfe397e55de549870747d62c
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Jun 19 16:35:38 2015 +0200
alloc: Load balancing for algo A
Currently only the first enabled PDCH will be used. Beside the
throughput this will also limit the number of TBFs:
- number of UL TBFs <= 7
- number of DL TBFs <= 32
This commit changes the allocation algorithm to use the PDCH with the
least number of attached TBFs. This will improve the troughput in
both directions and the UL limits:
- number of UL TBFs <= min(32, N_PDCH * 7) UL TBFs
Ticket: #1794
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=3e4ac92f79446378fc4c4697d8f31ea…
commit 3e4ac92f79446378fc4c4697d8f31ea1cdb6eafb
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jun 29 14:18:46 2015 +0200
ms: Add tbf() method to get the TBF based on the direction
To avoid the need for a switch or conditional statement when needing
a TBF from an MS object in direction independant code, this method
contains that case distinction. For additional flexibility, a
reverse() function is added to get the opposite direction.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=6f9587bd091ff95c7150646920bc3c8…
commit 6f9587bd091ff95c7150646920bc3c8b1ea14d3b
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jun 29 14:05:55 2015 +0200
ms: Add first_common_ts method to GprsMs
This method gets the index (0 based) of first common time slot used
by the TBFs attach to it. It expects that all of them have the same
notion of this. If no TBF is attached, -1 will be returned.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=6eca14991030ee87c9370c46d719e22…
commit 6eca14991030ee87c9370c46d719e22763a65609
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jun 29 13:45:05 2015 +0200
tbf: Maintain the number of TBF per PDCH
Currently the PDCH object do not know anything about the TBFs using
them. To make the slot allocation load dependant, at least some
numbers are required.
This commit adds TBF counters (one per direction) and the related methods
attach_tbf, detach_tbf, and num_tbfs to gprs_rlcmac_pdch.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=8fb193a04767967350fd63501f2f46e…
commit 8fb193a04767967350fd63501f2f46e8da3f1a66
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jun 29 13:30:43 2015 +0200
tbf: Update the new TBF in tbf_reuse (TODO)
Currently the old TBF is updated for reallocation in tbf_reuse().
This commit changes this to update the new TBF instead.
TODO:
- does this make sense?
- does this fix anything?
- should the call to update() be removed completely there?
http://cgit.osmocom.org/osmo-pcu/commit/?id=6ec4b962ba8be347708f3c4c3d3f106…
commit 6ec4b962ba8be347708f3c4c3d3f1062ba1ffc91
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jun 29 13:03:46 2015 +0200
tbf/test: Add assertions
These assertions check for the TBF allocation result before the tbf
object is dereferenced the first time.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=8b5add11527ee7108d0f11cf55d9726…
commit 8b5add11527ee7108d0f11cf55d972651a4a0eb1
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jun 29 13:00:20 2015 +0200
alloc/test: Use LOGL_DEBUG environment variable
When this environment variable is set, the logging level is set to
LOGL_DEBUG to help debugging without putting everything into
AllocTest.err.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=8f37bfe3abfaeda30de7f1f2f813c7b…
commit 8f37bfe3abfaeda30de7f1f2f813c7b9b20f39ac
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jun 29 12:45:11 2015 +0200
alloc/test: Enhance test_alloc_a
This commit adds:
- an assertion to check that count is valid,
- an assertion the verify that tbf_alloc did not fail
- a slots parameter to specify the enabled slots
- additional test invocations with more slots enabled
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=edcab1a0be452d8c977e35783ce489b…
commit edcab1a0be452d8c977e35783ce489beb82da099
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jun 29 12:19:52 2015 +0200
alloc/test: Add test for successive allocation
This test allocates as many as possible UL/DL TBF pairs, shows their
PDCH usage, and checks how many of them has been created
successfully.
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
hooks/post-receive
--
UNNAMED PROJECT
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".
The branch, jerlbeck/wip/pdch-alloc has been updated
discards 520c2919f4bf5d0d0d6dd254e8d76a6876b3b481 (commit)
discards 509fdb69a9e2036b55cac7f954f9343b6c77d5af (commit)
discards 8b7c196e9047073de6c7d4ff2857562ce0368303 (commit)
discards 03ecaff5834c949058dd128a9e4f4a549db9bcf5 (commit)
discards cb80e6abb755bb6711a56388eb709f0995de9b1c (commit)
discards f297ac8e06506ddce1ab629bbc36f4fa402af915 (commit)
discards 17ac3f7a1bd67aad0e0682d29d5356f193403f02 (commit)
discards acbf887cf8fcbd56fa3fd620cb46978210398bc9 (commit)
discards a8af58d7d5e44b175749290ef2a76f47fb714ac2 (commit)
discards 3a0635c0145e5c814945b30d7eea50d3fd76b851 (commit)
discards 9a2c6655686fb773550b6e1050f60c821eee70b4 (commit)
via 50076d7a18e03fee84017df4066efa1429904c41 (commit)
via ba39f92b58e69d6c1d7268bb2b8f90d0ff199a41 (commit)
via a58d17131f2f6f7aca4f2479a0348ce04625fbfe (commit)
via a64aa7a65defed38baf2b344240ddf16095a9051 (commit)
via 5f16b96df993c8f44ed8ab64a39c20b9b2904db3 (commit)
via f78593d6e83dd9f26bd1f9cc0e97dabf792a6d8a (commit)
via cf01665b6bd4cc79276cb331ec20f9141c622eee (commit)
via d31560624cd55371fc9d0a3f7b8d023f5dda3558 (commit)
via 48d01a8e2fe77fa13d4f846ba730f43fa3166319 (commit)
via c86d1933900fdf4c1a296fe6fba72512fe025958 (commit)
via 0c8ebf5f511826419c37e04dd1363357c2b4ec35 (commit)
via ec4f21ddec40a9091083c23ec1f040fd52525df9 (commit)
via 0062976f9ba526c67544184f19e7d1216b3d5fcd (commit)
via 4da768b26976cd10f20be32b460d374051b20b81 (commit)
via 0023fbde402832765f083cd79a3e2fe382e8b8fe (commit)
via 01f5df9589e83f97f9b15e31b06a53cfe4192e6d (commit)
via d6108ac1e13b9701b4bc2c5b2dba360ac231b589 (commit)
via 5a7dd909fe51a9925ca844cdfcba48e0a890fb56 (commit)
via cfdd37fa164f8918fe6dea33b0212d01133f98e5 (commit)
via e3859a113af4d7865831a7f778574f830de8b23f (commit)
via 3db617f14a0314a0e2a233b3ddaba1501213c0e5 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (520c2919f4bf5d0d0d6dd254e8d76a6876b3b481)
\
N -- N -- N (50076d7a18e03fee84017df4066efa1429904c41)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-pcu/commit/?id=50076d7a18e03fee84017df4066efa1…
commit 50076d7a18e03fee84017df4066efa1429904c41
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jul 14 14:29:34 2015 +0200
pcu: Use alloc_algorithm_dynamic by default
The dynamic algorithm behaves like B until there are no TFI left.
This commit changes the default algorithm to to former.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=ba39f92b58e69d6c1d7268bb2b8f90d…
commit ba39f92b58e69d6c1d7268bb2b8f90d0ff199a41
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jul 14 14:02:41 2015 +0200
alloc: Add counters for successful algo A/B allocations
This adds counters for algorithm A and B with count successful
allocation combined for UL and DL.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=a58d17131f2f6f7aca4f2479a0348ce…
commit a58d17131f2f6f7aca4f2479a0348ce04625fbfe
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jul 14 13:31:48 2015 +0200
alloc: Add 'dynamic' allocation algorithm
The idea behind this meta algorithm is to automatically select one of
the other algorithms based on the system state. Basically algorithm B
will be selected if the PDCH usage is low to improve throughput and
latency. Algorithm A will be selected to support more concurrent MS.
This commit adds a first simple state-less version of this algorithm
that always tries B first and only if that fails A is tried
afterwards.
The following VTY command is added to the 'pcu' node:
- alloc-algorithm dynamic
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=a64aa7a65defed38baf2b344240ddf1…
commit a64aa7a65defed38baf2b344240ddf16095a9051
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jul 14 12:57:07 2015 +0200
alloc: Remove disabled code fragment for multi-UL allocation
This part of algorithm_b has already been disabled. Further work may
depend on this, but it is going out of sync. So this commit removes
it completely.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=5f16b96df993c8f44ed8ab64a39c20b…
commit 5f16b96df993c8f44ed8ab64a39c20b9b2904db3
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jul 14 11:35:21 2015 +0200
alloc: Refactor alloc algorithms to only apply changes on success
Currently these algorithms modify other objects (MS, TBF, PDCH) even
if the allocation will fail later on. To implement an algorithm that
dynamically tries another algorithm on failure (e.g. A after B), the
first (failing) algorithm should not change or damage anything.
This commit refactors algorithm A and B to delay the actual allocation
until it is known that the allocation will not fail.
Ticket: #1934
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=f78593d6e83dd9f26bd1f9cc0e97dab…
commit f78593d6e83dd9f26bd1f9cc0e97dabf792a6d8a
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jul 14 08:26:17 2015 +0200
alloc: Optionally enforce first common TS in find_multi_slots (TODO)
TODO:
- This isn't probably triggered at all currently, so this commit
can possibly be dropped
http://cgit.osmocom.org/osmo-pcu/commit/?id=cf01665b6bd4cc79276cb331ec20f91…
commit cf01665b6bd4cc79276cb331ec20f9141c622eee
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jul 13 15:15:18 2015 +0200
alloc: Remove redundant first_common_ts handling
Currently this code path is only used, if an allocation has been
taken place in a former call to an allocation algorithm function.
If this was for an DL TBF, the first common TS was selected,
otherwise the least used common TS was selected for an UL TBF.
The shrinking of the UL set (to 1<<first_common_ts) is done in the
latter case.
This commit removes an additional code path that aligns the UL set to
first_common_ts, because it has no more influence on the set of
common TS after both UL and DL TBF have been allocated.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=d31560624cd55371fc9d0a3f7b8d023…
commit d31560624cd55371fc9d0a3f7b8d023f5dda3558
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jul 13 14:50:08 2015 +0200
alloc/test: Add test for interleaved TBF chains
MS iniated TCP connections generally result in a sequence
of short time UL and longer lasting DL TBFs, being interleaved
between several MS. This scenario is not covered by the existing
tests.
This commit adds a test, that allocates as man as possible TBFs
several times with different test modes without clearing the BTS (and
thus the TBF list) in between. The number of allocated DL TBFs in
each round is expected to be constant.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=48d01a8e2fe77fa13d4f846ba730f43…
commit 48d01a8e2fe77fa13d4f846ba730f43fa3166319
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jul 13 14:38:18 2015 +0200
alloc/test: Put TBF allocation loop into alloc_many_tbfs
Currently all TBFs are deleted after the allocation loop finishes.
This make it difficult to interleave the TBF allocation like it
happens with real MS.
This commit refactors the allocation loop into alloc_many_tbfs and
adds support for TLLIs, which are derived from the counter value and
used to retrieve an old MS object if alloc_many_tbfs is called a
second time.
Note that this does not make a difference for the existing tests.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=c86d1933900fdf4c1a296fe6fba7251…
commit c86d1933900fdf4c1a296fe6fba72512fe025958
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jul 13 14:23:32 2015 +0200
ms: Add is_idle() method to GprsMs::Guard
Currently there is no simple way to determine, whether the MS object
protected by a guard will continue to exist after the guard object is
destroyed.
This patch adds a is_idle() method that will return true if the MS
object is just kept by the guard from being idle. In that case, the
MS object would either be deleted or return true for
GprsMs::is_idle() after the guard's destruction, provided that no
TBF attachment took place in between.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=0c8ebf5f511826419c37e04dd136335…
commit 0c8ebf5f511826419c37e04dd1363357c2b4ec35
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Jul 10 19:52:37 2015 +0200
tbf: Put the TFI->TBF mapping into the PDCH objects
Currently the TBFs are registered in a TFI indexed array within the TRX
objects. TBFs can be searched globally by TFI and TRX number. This
conflicts with the use of the same TFI for different TBF on different
PDCH. This use case requires the specification of the PDCH as
additional search dimension.
This commit moves the TFI index TBF arrays into the PDCH objects. The
related methods are updated accordingly.
Ticket: #1793
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=ec4f21ddec40a9091083c23ec1f040f…
commit ec4f21ddec40a9091083c23ec1f040fd52525df9
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Jul 10 12:25:25 2015 +0200
alloc: Allocate TFI per slot (algorithm A)
Currently the TFI are managed per TRX, thus only a maximum of 32 TBF
per direction and per TRX are possible simultaneously.
This commit modifies algorithm_a() to allow the sharing of TFI
between different PDCH. Since algorithm A only assigns a single slot
to each TBF, the TFI of each PDCH can be assigned independently.
This increases the maximum to 32 TBF per direction and per PDCH
concerning the TFI allocation.
Ticket: #1793
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=0062976f9ba526c67544184f19e7d12…
commit 0062976f9ba526c67544184f19e7d1216b3d5fcd
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Jul 10 10:41:36 2015 +0200
tbf: Move TFI selection into alloc_algorithm
Currently the TFI and the TRX have to be determined before the actual TBF
allocation function is called, passing TFI and TRX number as
parameters. This does fit to TFI reuse for different slots, since
this were tightly coupled with the slot selection.
This commit just moves the TFI selection into the alloc_algorithm
functions. The tfi parameter is removed from the the TFI alloc
functions. The trx parameter is changed into use_trx to optionally
limit the trx selection (same semantics like in tfi_find_free).
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=4da768b26976cd10f20be32b460d374…
commit 4da768b26976cd10f20be32b460d374051b20b81
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Jul 8 12:53:16 2015 +0200
pdch: Manage TFIs per direction
Currently a single bit set is used to maintain a set of used TFI
without distinguishing between uplink and downlink. Since the
namespaces of UL and DL TFI are separate, this implementation is
not correct.
This commit changes gprs_rlcmac_pdch to use a separate bit set for
each direction. It also replace the corresponding conditional fprintf
statement in check_tfi_usage (AllocTest.cpp) by an equivalent
OSMO_ASSERT.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=0023fbde402832765f083cd79a3e2fe…
commit 0023fbde402832765f083cd79a3e2fe382e8b8fe
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Jul 9 11:35:50 2015 +0200
alloc/test: Check for TFI conflicts
This commit adds the check_tfi_usage function that checks the TFI
usage. It iterates through all TBFs, records on which PDCH it uses
which TFI and check for conflicts. It also checks the bits returned
by pdch->assigned_tfi(). The latter suffers from an bug in that
method (no separation of uplink and downlink), so a conditional
fprintf is used instead of an assertion. The method tfi_find_free
is checked for conflicts after allocations.
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
src/bts.cpp | 2 +
src/bts.h | 6 +
src/gprs_ms.cpp | 8 +
src/gprs_ms.h | 2 +
src/gprs_rlcmac.h | 5 +
src/gprs_rlcmac_ts_alloc.cpp | 311 +++++----
src/pcu_main.cpp | 2 +-
src/pcu_vty.c | 13 +-
tests/alloc/AllocTest.cpp | 163 ++++-
tests/alloc/AllocTest.err | 1502 +++++++++++++++++++++++++++++++++++++++++-
tests/alloc/AllocTest.ok | 1261 +++++++++++++++++++++++++++++++++++
11 files changed, 3124 insertions(+), 151 deletions(-)
hooks/post-receive
--
UNNAMED PROJECT
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, zecke/features/no-tmsi has been updated
discards 55a3e676047651d7487aba50e7e9a1437d3f519a (commit)
via 32ee7f9840c373bd51761cc5af6a39b261f2e1e1 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (55a3e676047651d7487aba50e7e9a1437d3f519a)
\
N -- N -- N (32ee7f9840c373bd51761cc5af6a39b261f2e1e1)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=32ee7f9840c373bd51761cc5af6a39b2…
commit 32ee7f9840c373bd51761cc5af6a39b261f2e1e1
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Jul 13 20:33:08 2015 +0200
nitb: Add a mode to not use TMSI for normal operation
In case foreign simcards are used we can not do authentication
and ciphering. In case a TMSI is re-used too early and we do
page using TMSI we can't know which of the two MS is responding
to us. We could change the "secure channel" routine to ask for
the IMSI and only then stop the paging.
As we don't have ciphering there is not much use in using the
TMSI. Add a mode "no assign-tmsi" that will not assign the TMSI
during LU. Now CM Service Request and Paging Response will
work using the IMSI. There can't be a clash with that.
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/libmsc/gsm_04_08.c | 22 ++++++++++++++--------
1 file changed, 14 insertions(+), 8 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom BTS-side code (Abis, scheduling, ...)".
The branch, master has been updated
via a7c276b72b07b8b713c5d9af869159690e073441 (commit)
from f869a95f3b81d281405e3fc3026e1d0d53174082 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-bts/commit/?id=a7c276b72b07b8b713c5d9af8691596…
commit a7c276b72b07b8b713c5d9af869159690e073441
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Tue Jul 14 09:44:19 2015 +0200
meas: Do not send incomplete measurement reports
The RSL_IE_MEAS_RES_NR is mandatory element with a minimum
of 5 octets (two for TL and three for the value). When we
establish a new channel we might not have had enough time
in a TDMA frame to calculate the average. The issue is not
easy to reproduce. At the point we receive the measurement
report we have two uplink measurements queued. As it is not
easy to reproduce and only occurs when a channel is new
I have decided to drop the message instead of sending made
up uplink measurement reports.
As of now lchan_build_rsl_ul_meas will always return 3 and
the condition will never be false.
Avoids: SYS#1781
-----------------------------------------------------------------------
Summary of changes:
src/common/rsl.c | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)
hooks/post-receive
--
Osmocom BTS-side code (Abis, scheduling, ...)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".
The branch, jerlbeck/master has been updated
via 01f5df9589e83f97f9b15e31b06a53cfe4192e6d (commit)
via d6108ac1e13b9701b4bc2c5b2dba360ac231b589 (commit)
via 5a7dd909fe51a9925ca844cdfcba48e0a890fb56 (commit)
via cfdd37fa164f8918fe6dea33b0212d01133f98e5 (commit)
via e3859a113af4d7865831a7f778574f830de8b23f (commit)
from 3db617f14a0314a0e2a233b3ddaba1501213c0e5 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-pcu/commit/?id=01f5df9589e83f97f9b15e31b06a53c…
commit 01f5df9589e83f97f9b15e31b06a53cfe4192e6d
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Jul 8 12:18:33 2015 +0200
alloc: Fix MS_B/MS_C interpretation
Currently the handling of MS_B and MS_C is not compliant with TS
45.002, annex B.1. These values may only interpreted as 0, if
frequency hopping is not enabled and if there is no change from Rx to
Tx or vice-versa.
This commit sets Ttb/Trb to 1 if the table entry is MS_B/MS_C, since
only combined down/up access modes are supported.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=d6108ac1e13b9701b4bc2c5b2dba360…
commit d6108ac1e13b9701b4bc2c5b2dba360ac231b589
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Jul 9 12:06:56 2015 +0200
alloc: Do not use masking for multislot class type 2 MS
Currently the masks are computed equally for each class type. This
does not make much sense for class type 2 MS, since those are capable
to work in full duplex mode.
This commit sets the masks to 0xff for class type 2 MS.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=5a7dd909fe51a9925ca844cdfcba48e…
commit 5a7dd909fe51a9925ca844cdfcba48e0a890fb56
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jul 6 14:55:13 2015 +0200
alloc: Select applicable Tta/Tra
According to TS 45.002, 6.4.2.2 the choice whether Tta or Tra has to
be applied, depends on the medium access mode (currently always
dynamic) and the number of UL/DL slots. Currently either value can be
used which might result in combinations not covered by the spec.
This commit changes find_multi_slots() to skip non-compliant
combinations.
Note that this code will have to be extended, if other medium
access modes are implemented.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=cfdd37fa164f8918fe6dea33b0212d0…
commit cfdd37fa164f8918fe6dea33b0212d01133f98e5
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Jul 9 11:48:23 2015 +0200
alloc: Use an enum instead of numbers to select the mask
The local enums MASK_TT and MASK_TR replace the hard coded indices.
The variable m_idx is renamed to mask_sel for more clarity.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=e3859a113af4d7865831a7f778574f8…
commit e3859a113af4d7865831a7f778574f830de8b23f
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Jul 9 13:44:18 2015 +0200
alloc: Merge find_least_busy_pdch and find_least_reserved_pdch
Both functions only differ in the computation of the value for
num_tbfs.
This commit merge both functions and adds a parameter containing a
function for that compuation.
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
src/gprs_rlcmac_ts_alloc.cpp | 175 ++++++++--------
tests/alloc/AllocTest.ok | 480 +++++++++++++++++++++----------------------
2 files changed, 334 insertions(+), 321 deletions(-)
hooks/post-receive
--
UNNAMED PROJECT