This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".
The branch, master has been updated
via 657c5b6cadcef470c7ff9bffed3caab227026e6a (commit)
via 0b723f6a6cdc4171ee67ddd8d8c1bb812fb4cf06 (commit)
from b022c867e86333ceaad9027e2e7ee621ab3891e5 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=657c5b6cadcef470c7ff9bffed3c…
commit 657c5b6cadcef470c7ff9bffed3caab227026e6a
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Mon Sep 18 16:42:06 2017 +0200
vty: derive node name from prompt, use as XML ids
The 'show online-help' produces XML output with <node id="..."> ids. We
reference those from the osmo-gsm-manuals.
Instead of numeric IDs coming from internal code, rather use a human-readable
node ID -- referencing id='config-msc' is much easier than referencing id='23'.
Add a char name[] to struct cmd_node, to hold this name. This may be provided
upon struct definition.
Since callers of the VTY API so far don't have a name yet, we would need to add
names everywhere to get meaningful node IDs. There is a way to get node ID
names without touching dependent code:
My first idea was to find out which command entered the node, i.e. command
'msc' enters the MSC_NODE. But it is impossible to derive which command entered
which node from data structs, it's hidden in the vty command definition.
But in fact all (TM) known API callers indeed provide a prompt string that
contains a logical and human readable string name. Thus, if the name is unset
in the struct, parse the prompt string and strip all "weird" characters to
obtain a node name from that. We can still set names later on, but for now will
have meaningful node IDs (e.g. 'config-msc' from '%s(config-msc)# ') without
touching any dependent code.
When VTY nodes get identical node names, which is quite possible, the XML
export de-dups these by appending _2, _3,... suffixes. The first occurence is
called e.g. 'name', the second 'name_2', then 'name_3', and so forth.
If a node has no name (even after parsing the prompt), it will be named merely
by the suffix. The first empty node will become id='_1', then '_2', '_3', and
so forth. This happens for nodes like VIEW_NODE or AUTH_NODE.
If this is merged, we need to adjust the references in osmo-gsm-manuals.git.
This can happen in our own time though, because we manually create the vty
reference xml and copy it to the osmo-gsm-manuals.git and then update the
references from the vty_additions.xml. This anyway has to happen because
currently the references tend to be hopelessly out of sync anyway, placing
comments at wildly unrelated VTY commands.
Change-Id: I8fa555570268b231c5e01727c661da92fad265de
http://cgit.osmocom.org/libosmocore/commit/?id=0b723f6a6cdc4171ee67ddd8d8c1…
commit 0b723f6a6cdc4171ee67ddd8d8c1bb812fb4cf06
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Mon Sep 18 17:10:36 2017 +0200
vty: use internal node id for xml ids
The 'show online-help' produces XML output with <node id="..."> ids. We
reference those from the osmo-gsm-manuals, but until now, these ids fall out of
sync when the amount of VTY nodes changes.
Change these ids to use the internal node ID constant (as in enum bsc_vty_node)
instead of a simple counter.
If this is merged, we need to adjust the references in osmo-gsm-manuals.git.
Change-Id: Ib07fb9d9106e19f5be6539493e82b5d5991f8bc2
-----------------------------------------------------------------------
Summary of changes:
include/osmocom/vty/command.h | 5 +++++
src/vty/command.c | 47 ++++++++++++++++++++++++++++++++++++++++++-
2 files changed, 51 insertions(+), 1 deletion(-)
hooks/post-receive
--
An utility library for Open Source Mobile Communications
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "MNCC <-> SIP bridge".
The branch, master has been updated
via 535df15bc5a2fc0119e6f3c9d2eeec20944aabfa (commit)
from b6032727870ab2b98372b697d91f7256da4f32b3 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-sip-connector/commit/?id=535df15bc5a2fc0119e6f…
commit 535df15bc5a2fc0119e6f3c9d2eeec20944aabfa
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Tue Sep 19 03:29:48 2017 +0200
vty: install default commands for SIP,MNCC,APP_NODE
Change-Id: Iee51881cc07d56209647fb4f505f8f6be6b885f0
-----------------------------------------------------------------------
Summary of changes:
src/vty.c | 3 +++
1 file changed, 3 insertions(+)
hooks/post-receive
--
MNCC <-> SIP bridge
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom BTS-side code (Abis, scheduling, ...)".
The branch, master has been updated
via 9605b695fab690682024128cd580b288906fbb24 (commit)
from ae134f896a77eb5b79c81601cabd821d5b993358 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-bts/commit/?id=9605b695fab690682024128cd580b28…
commit 9605b695fab690682024128cd580b288906fbb24
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Tue Sep 19 03:27:29 2017 +0200
vty: mgr: sysmobts, lc15: install default commands for ACT_NORM_NODE
Change-Id: Ia1b3d5e010c5b6ea8e655b79d9b36b08cd1ef4c4
-----------------------------------------------------------------------
Summary of changes:
src/osmo-bts-litecell15/misc/lc15bts_mgr_vty.c | 1 +
src/osmo-bts-sysmo/misc/sysmobts_mgr_vty.c | 1 +
2 files changed, 2 insertions(+)
hooks/post-receive
--
Osmocom BTS-side code (Abis, scheduling, ...)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Manuals for Osmocom GSM components".
The branch, master has been updated
via 0e3e4c217add2744307b81d3e8c715c3ddc2c119 (commit)
via 60ccbe55c534c533779d816187d838339cfdce86 (commit)
from 56f77a3b6436eab71c42fd0ad3233a15148eafed (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
-----------------------------------------------------------------------
Summary of changes:
INSTALL.txt | 24 +++++++++++++++++++++++-
build/Makefile.asciidoc.inc | 5 +----
2 files changed, 24 insertions(+), 5 deletions(-)
hooks/post-receive
--
Manuals for Osmocom GSM components
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".
The branch, master has been updated
via b022c867e86333ceaad9027e2e7ee621ab3891e5 (commit)
via 00b5ed3d921f2f39e60ed372809c33b8bce78ad8 (commit)
from 430636328c2fbd9fffc0eac5114462c200b7f2cb (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=b022c867e86333ceaad9027e2e7e…
commit b022c867e86333ceaad9027e2e7ee621ab3891e5
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Wed Sep 20 01:49:11 2017 +0200
vty_test: add artificial node levels for better testing
In vty_test, add three levels of parent nodes (level1, level2, level3) with
each having a leaf child (child1, child2, child3).
Use these to enhance the vty_test cfg files and test more diverse situations.
The current VTY code expects a go_parent_cb() to be present, otherwise it will
bump right back to the CONFIG_NODE, which will not work with more than one node
level below the CONFIG_NODE. Hence provide a minimal go_parent_cb().
Change-Id: Ib9bcf58b655fbd85e196f363fb7d8305d7dfc997
http://cgit.osmocom.org/libosmocore/commit/?id=00b5ed3d921f2f39e60ed372809c…
commit 00b5ed3d921f2f39e60ed372809c33b8bce78ad8
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Wed Sep 20 00:46:03 2017 +0200
comment: describe indent_cmp()
Change-Id: Ia58c16d995f6751bdd69defe8a46665aee163f3d
-----------------------------------------------------------------------
Summary of changes:
src/vty/command.c | 4 +
tests/vty/fail_not_de-indented.cfg | 6 +-
tests/vty/fail_tabs_and_spaces.cfg | 8 +-
tests/vty/fail_too_much_indent.cfg | 6 +-
tests/vty/ok.cfg | 31 +++++++-
tests/vty/ok_empty_parent.cfg | 24 +++++-
tests/vty/ok_ignore_blank.cfg | 15 +++-
tests/vty/ok_ignore_comment.cfg | 9 ++-
tests/vty/ok_indented_root.cfg | 8 +-
tests/vty/ok_more_spaces.cfg | 32 +++++++-
tests/vty/ok_tabs.cfg | 32 +++++++-
tests/vty/ok_tabs_and_spaces.cfg | 32 +++++++-
tests/vty/vty_test.c | 120 +++++++++++++++++++++++++++-
tests/vty/vty_test.ok | 156 +++++++++++++++++++++++++++++++++++++
14 files changed, 444 insertions(+), 39 deletions(-)
hooks/post-receive
--
An utility library for Open Source Mobile Communications
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".
The branch, master has been updated
via 430636328c2fbd9fffc0eac5114462c200b7f2cb (commit)
from 4a31ffa2f0097d96201f80305a0495c57552f0ad (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=430636328c2fbd9fffc0eac51144…
commit 430636328c2fbd9fffc0eac5114462c200b7f2cb
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Tue Sep 19 23:54:01 2017 +0200
fix vty regression: empty parent node
The recent exit-by-indent patch breaks a VTY case where a node is entered but
directly followed by a sibling or ancestor without listing any child nodes.
Regression introduced by I24cbb3f6de111f2d31110c3c484c066f1153aac9.
An example is a common usage in osmo-bts, where 'phy N' / 'instance N' is a
parent node that is commonly left empty:
phy 0
instance 0
bts 0
band 1800
Before this patch, this case produces the error:
There is no such command.
Error occurred during reading the below line:
bts 0
Fix indentation parsing logic in command.c to accomodate this case.
Add a unit test for empty parent node.
Change-Id: Ia0880a17ae55accb092ae8585cc3a1bec9986891
-----------------------------------------------------------------------
Summary of changes:
src/vty/command.c | 39 +++++++++++++++++++++++++------
tests/Makefile.am | 1 +
tests/vty/{ok.cfg => ok_empty_parent.cfg} | 1 -
tests/vty/vty_test.c | 1 +
tests/vty/vty_test.ok | 2 ++
5 files changed, 36 insertions(+), 8 deletions(-)
copy tests/vty/{ok.cfg => ok_empty_parent.cfg} (66%)
hooks/post-receive
--
An utility library for Open Source Mobile Communications
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".
The branch, neels/vty_indent_debug has been created
at ade800e1018bc8960559baef314e0266b3598769 (commit)
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=ade800e1018bc8960559baef314e…
commit ade800e1018bc8960559baef314e0266b3598769
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Tue Sep 12 04:06:50 2017 +0200
NOT FOR MERGE: vty indentation debug
Change-Id: I48f2d7c34ea160a8ca36ab83f462ffd7e660065e
http://cgit.osmocom.org/libosmocore/commit/?id=d0de6ab897249ac9a0a8f9bf46d3…
commit d0de6ab897249ac9a0a8f9bf46d3508bea55d93e
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Tue Sep 19 23:54:01 2017 +0200
fix vty regression: empty parent node
The recent exit-by-indent patch breaks a VTY case where a node is entered but
directly followed by a sibling or ancestor without listing any child nodes.
Regression introduced by I24cbb3f6de111f2d31110c3c484c066f1153aac9.
An example is a common usage in osmo-bts, where 'phy N' / 'instance N' is a
parent node that is commonly left empty:
phy 0
instance 0
bts 0
band 1800
Before this patch, this case produces the error:
There is no such command.
Error occurred during reading the below line:
bts 0
Fix indentation parsing logic in command.c to accomodate this case.
Add a unit test for empty parent node.
Change-Id: Ia0880a17ae55accb092ae8585cc3a1bec9986891
-----------------------------------------------------------------------
hooks/post-receive
--
An utility library for Open Source Mobile Communications
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Radio block for interfacing with various radio hardware".
The branch, plutokernel has been created
at 226e690d105e1ab878a235cfd1384895a494ce4a (commit)
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/gr-osmosdr/commit/?id=226e690d105e1ab878a235cfd1384…
commit 226e690d105e1ab878a235cfd1384895a494ce4a
Author: Hoernchen <la(a)tfc-server.de>
Date: Sun Sep 17 22:47:45 2017 +0200
Add support for experimental plutosdr kernel driver
-----------------------------------------------------------------------
hooks/post-receive
--
GNU Radio block for interfacing with various radio hardware
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Repository for Realtek RTL2832U based SDR software".
The branch, master has been updated
via b04c2f9f035c5aede43d731e5d58e4725d2f8bb4 (commit)
from 18bf26989c926a5db4fca29e7d859af42af1437c (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/rtl-sdr/commit/?id=b04c2f9f035c5aede43d731e5d58e472…
commit b04c2f9f035c5aede43d731e5d58e4725d2f8bb4
Author: Hoernchen <la(a)tfc-server.de>
Date: Tue Sep 19 19:23:00 2017 +0200
fix for msvc14
-----------------------------------------------------------------------
Summary of changes:
CMakeLists.txt | 3 +++
1 file changed, 3 insertions(+)
hooks/post-receive
--
Repository for Realtek RTL2832U based SDR software