osmocom-commitlog March 2017

osmocom-commitlog@lists.osmocom.org

1 participants
284 discussions

openbsc.git branch users/daniel/ow-nat-msc-conns updated. 0.15.0-94-gd8429fbe1

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, users/daniel/ow-nat-msc-conns has been updated discards fe52250dd1651d4615f4c4c1744b873758e01681 (commit) discards c20900d5832324786b536b95ceb035f8b5abf376 (commit) discards 6d726d0baa6d5e9f73c3d1e77bb88667586c6041 (commit) discards aa7d574012062d05fe1b772538d41fff0a19490e (commit) discards 8f655c184c373a143d548bd6f95a87a2e76a3246 (commit) discards c9687b543da8cfa160607fb31a2103d1dd9eb6e3 (commit) discards 9df49a969dd932d1394700ebf61db77d771233ef (commit) discards 2f83944850281b78297f3797c0bda30fdf7c5140 (commit) discards ef7d803e640dd5e01fa3bbce23e7d52ed06e7828 (commit) discards a33fa2605dd8644d298375cf9de0feada0aa80dd (commit) discards 6b703f09faefbcdbf1c068001b4f31cdb28de9b4 (commit) discards 5502b8211a28c34503237df64d5eaf25c8b0b982 (commit) via d8429fbe1e6da857ad8ba6ada14c078ca18f3779 (commit) via 29da136347c0ad88d03e98b998fdea25691cdab4 (commit) via b5b68f02f76d4663bac2b788a46424b866e816af (commit) via 75152e662f0ace393505314b8b727a8cda6619b9 (commit) via 96279f9cc81dcb41e6b3dd5ed0918588d122dab0 (commit) via fafecb5e50b3efd6fcd0f9060fee1c9af87ceee1 (commit) via 1aa60bd1f530e859ac9c2b2d853c4e9442e0ca2f (commit) via c2c327ed50c5ab17152228bacd028bc829850dae (commit) via a6294bc54fe1755de506cbd3b05f0e46e5f66fb3 (commit) via a4344af7ac79e002241b05d115a0659a6063c3a7 (commit) via ee605f731a7f8a3a58a1f90b4ecc594397fa662b (commit) via 634eca0f75d468f5c6d18df320c84c16d31cc69b (commit) via d2f1d3aa0774bdb093feff76b7010b3d784b892c (commit) via bab82e3e9d6efa747a5a95c617d31d43165784e8 (commit) via 3e09ad035a035e0bf03e3739d8096255c930986f (commit) via 1fb44633e062c608ed7dd620e00d765f916a4405 (commit) via d19e7deb23622c1bdb3cc21e7719af80369a731a (commit) via ea98503fbc0d666adaee1dea645f3a049c6dc019 (commit) via c616c54d5f669d99f74bd68a3cf8c24e1e95be82 (commit) via 95cce409584a0543f982df7e997720a3054d456d (commit) via 92f089732148bd6676d9663ed14d1c0799284b73 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (fe52250dd1651d4615f4c4c1744b873758e01681) \ N -- N -- N (d8429fbe1e6da857ad8ba6ada14c078ca18f3779) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=d8429fbe1e6da857ad8ba6ada14c078c… commit d8429fbe1e6da857ad8ba6ada14c078ca18f3779 Author: Daniel Willmann <dwillmann(a)sysmocom.de> Date: Thu Mar 2 17:26:32 2017 +0100 WIP Change-Id: If40b0bd51773b1658f744063be418c024a781e11 http://cgit.osmocom.org/openbsc/commit/?id=29da136347c0ad88d03e98b998fdea25… commit 29da136347c0ad88d03e98b998fdea25691cdab4 Author: Daniel Willmann <dwillmann(a)sysmocom.de> Date: Thu Mar 2 17:25:37 2017 +0100 osmo-bsc_nat: Remove unused MSC elements in struct bsc_nat Change-Id: Ied1bdead94ba2737293fb1ac2411771a8b8ffd68 Ticket: SYS#3208 Sponsored-by: On-Waves ehf. http://cgit.osmocom.org/openbsc/commit/?id=b5b68f02f76d4663bac2b788a46424b8… commit b5b68f02f76d4663bac2b788a46424b866e816af Author: Daniel Willmann <dwillmann(a)sysmocom.de> Date: Thu Mar 2 17:13:03 2017 +0100 osmo-bsc_nat: Change the way bsc_nat_msc_is_connected() works The function now takes a struct msc_config and returns true if that MSC is connected. The vty command show msc connection now shows a line per connected MSC. In bsc_nat.c where osmo-bsc_nat previously hung up on a BSC connection if the (one) MSC was not connected it now checks for the default MSC connection. Change-Id: I95fbe1b8ad6621aba9b4bd6b581abfde0cb31fd0 Ticket: SYS#3208 Sponsored-by: On-Waves ehf. http://cgit.osmocom.org/openbsc/commit/?id=75152e662f0ace393505314b8b727a8c… commit 75152e662f0ace393505314b8b727a8cda6619b9 Author: Daniel Willmann <dwillmann(a)sysmocom.de> Date: Thu Mar 2 16:37:03 2017 +0100 osmo-bsc_nat: Have a default MSC for messages from BSC Change-Id: I343e6d9d17bcde6dbdf8f48b7b51e998a296680c Ticket: SYS#3208 Sponsored-by: On-Waves ehf. http://cgit.osmocom.org/openbsc/commit/?id=96279f9cc81dcb41e6b3dd5ed0918588… commit 96279f9cc81dcb41e6b3dd5ed0918588d122dab0 Author: Daniel Willmann <dwillmann(a)sysmocom.de> Date: Wed Mar 1 18:56:38 2017 +0100 tests: Test IMSI routing with multiple MSCs Change-Id: Iab46d45aa8ba708282debcd7b9d704fc40e6ff1f Ticket: SYS#3208 Sponsored-by: On-Waves ehf. http://cgit.osmocom.org/openbsc/commit/?id=fafecb5e50b3efd6fcd0f9060fee1c9a… commit fafecb5e50b3efd6fcd0f9060fee1c9af87ceee1 Author: Daniel Willmann <dwillmann(a)sysmocom.de> Date: Tue Feb 28 19:09:25 2017 +0100 osmo-bsc_nat: Implement access lists for MSC conns Change-Id: Iedcf492ff8bb86e7ac68d8909634525e7b0648ea Ticket: SYS#3208 Sponsored-by: On-Waves ehf. http://cgit.osmocom.org/openbsc/commit/?id=1aa60bd1f530e859ac9c2b2d853c4e94… commit 1aa60bd1f530e859ac9c2b2d853c4e9442e0ca2f Author: Daniel Willmann <dwillmann(a)sysmocom.de> Date: Tue Feb 28 18:25:46 2017 +0100 osmo-bsc_nat: Change some functions to work with multiple MSC conns Change-Id: Iab6f23f6f010f34876e37852cafa53e3a641478e Ticket: SYS#3208 Sponsored-by: On-Waves ehf. http://cgit.osmocom.org/openbsc/commit/?id=c2c327ed50c5ab17152228bacd028bc8… commit c2c327ed50c5ab17152228bacd028bc829850dae Author: Daniel Willmann <dwillmann(a)sysmocom.de> Date: Tue Feb 28 18:23:31 2017 +0100 osmo-bsc_nat: Support multiple MSCs in VTY/config Change-Id: I2e9009b52c6ecc17fc2da8402736412b9093ce19 Ticket: SYS#3208 Sponsored-by: On-Waves ehf. http://cgit.osmocom.org/openbsc/commit/?id=a6294bc54fe1755de506cbd3b05f0e46… commit a6294bc54fe1755de506cbd3b05f0e46e5f66fb3 Author: Daniel Willmann <dwillmann(a)sysmocom.de> Date: Tue Feb 28 18:05:01 2017 +0100 osmo-bsc_nat: Add functions to alloc/find/free MSC config Change-Id: I5879d4d9ee0e1a0a6424ee3e9b214afb07319071 Ticket: SYS#3208 Sponsored-by: On-Waves ehf. http://cgit.osmocom.org/openbsc/commit/?id=a4344af7ac79e002241b05d115a0659a… commit a4344af7ac79e002241b05d115a0659a6063c3a7 Author: Daniel Willmann <dwillmann(a)sysmocom.de> Date: Tue Feb 28 18:07:17 2017 +0100 osmo-bsc_nat: Add variables for multiple MSC conns to struct bsc_nat Change-Id: I0b959431140b1e48ca3dd85a8d8985cf967073e2 Ticket: SYS#3208 Sponsored-by: On-Waves ehf. http://cgit.osmocom.org/openbsc/commit/?id=ee605f731a7f8a3a58a1f90b4ecc5943… commit ee605f731a7f8a3a58a1f90b4ecc594397fa662b Author: Daniel Willmann <dwillmann(a)sysmocom.de> Date: Tue Feb 28 18:00:50 2017 +0100 osmo-bsc_nat: Add infrastructure for multiple MSC connections Add some common defines and structs Change-Id: I9cdfc5b32f2500f47be8caaa281bcca3231db5ea Ticket: SYS#3208 Sponsored-by: On-Waves ehf. http://cgit.osmocom.org/openbsc/commit/?id=634eca0f75d468f5c6d18df320c84c16… commit 634eca0f75d468f5c6d18df320c84c16d31cc69b Author: Daniel Willmann <dwillmann(a)sysmocom.de> Date: Tue Feb 28 17:55:36 2017 +0100 osmo-bsc_nat: Remove MSC IP cmdline option. This no longer makes sense for multiple MSCs Change-Id: I6f348dd5c7bdb2530081a1d609d03a6b0d13d0b2 Ticket: SYS#3208 Sponsored-by: On-Waves ehf. http://cgit.osmocom.org/openbsc/commit/?id=d2f1d3aa0774bdb093feff76b7010b3d… commit d2f1d3aa0774bdb093feff76b7010b3d784b892c Author: Daniel Willmann <dwillmann(a)sysmocom.de> Date: Mon Nov 14 17:28:46 2016 +0100 debian: Release new version with a fix for gbproxy Change-Id: I966c27f683763c976a93effda1aa4326b80b4856 http://cgit.osmocom.org/openbsc/commit/?id=bab82e3e9d6efa747a5a95c617d31d43… commit bab82e3e9d6efa747a5a95c617d31d43165784e8 Author: Daniel Willmann <dwillmann(a)sysmocom.de> Date: Tue Nov 8 15:29:30 2016 +0100 test/gbproxy: Test for possible memory corruption when link_info is freed This test is to trigger the use-after free issue in commit bff7b0d80972. If compiled with address-sanitizer the test will abort without the fix. Change-Id: I5e8c6626ba43342740f08d699383bdded739079f Ticket: OW#3049 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=3e09ad035a035e0bf03e3739d8096255… commit 3e09ad035a035e0bf03e3739d8096255c930986f Author: Daniel Willmann <dwillmann(a)sysmocom.de> Date: Mon Nov 7 17:54:29 2016 +0100 gbproxy: Check whether gbproxy_update_link_state_after() deletes the link_info In case the link_info is deleted we have to stop handling the stored messages inside link_info. Not doing so can lead to invalid memory being accessed. Change-Id: Ieb8503e9e94e7a5ac450ad8aa1713ec4f21cdea5 Ticket: OW#3049 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=1fb44633e062c608ed7dd620e00d765f… commit 1fb44633e062c608ed7dd620e00d765f916a4405 Author: Daniel Willmann <dwillmann(a)sysmocom.de> Date: Wed Nov 2 13:03:30 2016 +0100 Release new version with fix for msisdn in pdp context activation Change-Id: Ia17ea5daaeb89d100bb673165dd7d2acabaf9b0f http://cgit.osmocom.org/openbsc/commit/?id=d19e7deb23622c1bdb3cc21e7719af80… commit d19e7deb23622c1bdb3cc21e7719af80369a731a Author: Harald Welte <laforge(a)gnumonks.org> Date: Tue Nov 1 03:32:50 2016 +0100 SGSN: Use dummy all-zero MSISDN value in PDP Context Act on GTP The GTP protocol specification requires us to include the MSISDN IE in all non-secondary PDP context activations. However, when no real HLR is used (e.g. via GSUP), we do not have the MSISDN information available and so far simply sent a zero-length MSISDN IE in GTP. The latter is a violation of the spec. So to resolve this, we now send a 15-digit all-zero dummy MSISDN IE, as described in TS 23.003. Change-Id: I8d0a5d52d6cd2a00b5dda060bd41d45056dfa84d ----------------------------------------------------------------------- Summary of changes: debian/changelog | 25 +++++ openbsc/include/openbsc/gb_proxy.h | 2 +- openbsc/include/openbsc/osmux.h | 1 + openbsc/src/gprs/gb_proxy.c | 22 +++- openbsc/src/gprs/gb_proxy_tlli.c | 16 ++- openbsc/src/gprs/sgsn_libgtp.c | 15 ++- openbsc/src/libmgcp/mgcp_protocol.c | 6 +- openbsc/src/osmo-bsc_nat/bsc_mgcp_utils.c | 5 +- openbsc/src/osmo-bsc_nat/bsc_nat_filter.c | 2 +- openbsc/tests/bsc-nat/bsc_nat_test.c | 3 + openbsc/tests/gbproxy/gbproxy_test.c | 95 ++++++++++++++++ openbsc/tests/gbproxy/gbproxy_test.ok | 181 ++++++++++++++++++++++++++++++ 12 files changed, 353 insertions(+), 20 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

8 years, 3 months

libosmocore.git branch master updated. 0.9.6-140-g49daf56

by gitosis＠osmocom.org

8 years, 3 months

openbsc.git branch master updated. 0.15.0-718-ge7379fe65

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via e7379fe6570b97c7adea0b74b624adbcd4e56b35 (commit) from 99c9707d1c8261727048ae9b4d2fcb693020f1a7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=e7379fe6570b97c7adea0b74b624adbc… commit e7379fe6570b97c7adea0b74b624adbcd4e56b35 Author: Max <msuraev(a)sysmocom.de> Date: Tue Mar 14 16:15:59 2017 +0100 examples: remove logging level * everything Option "logging level ... everything" is broken for quite some time and might be deprecated in future. Replace it with "logging level ... debug" in config examples. Change-Id: I828ef7671b4fb38717526a18ff8e9a5428cd511e Related: OS#71 ----------------------------------------------------------------------- Summary of changes: openbsc/doc/examples/osmo-bsc_nat/osmo-bsc_nat.cfg | 12 ++++++------ openbsc/doc/examples/osmo-gbproxy/osmo-gbproxy-legacy.cfg | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

8 years, 3 months

openbsc.git branch master updated. 0.15.0-717-g99c9707d1

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 99c9707d1c8261727048ae9b4d2fcb693020f1a7 (commit) from 11368118c91eb2a94224d494558b38d05414d3c3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=99c9707d1c8261727048ae9b4d2fcb69… commit 99c9707d1c8261727048ae9b4d2fcb693020f1a7 Author: Philipp Maier <pmaier(a)sysmocom.de> Date: Tue Mar 14 17:32:35 2017 +0100 cosmetic: Add commandline option to display version The -V option to display the Version and the copyright info is missing. Change-Id: I0c848fd42c13f473807caf3478d32c6ce5e43e31 ----------------------------------------------------------------------- Summary of changes: openbsc/src/gprs/sgsn_main.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

8 years, 3 months

libosmo-abis.git branch master updated. 0.3.2-60-g027e119

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom A-bis protcol interface library". The branch, master has been updated via 027e11936385a38bd331ea29f4f47a7b443c0932 (commit) via d75bac40d1b51a702cd14b35add6ff51d38d3994 (commit) from beb10ef02a10d73537a97f6f21aad36664c9b266 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmo-abis/commit/?id=027e11936385a38bd331ea29f4f… commit 027e11936385a38bd331ea29f4f47a7b443c0932 Author: Philipp Maier <pmaier(a)sysmocom.de> Date: Thu Dec 8 17:17:33 2016 +0100 lapd: log pointer addresses Add pointer address output to the sap alloc/free functions in order to track the objects later in the debug output (we have three of them) Change-Id: I9b961d5e36967cfd953551b24696849541257a1c http://cgit.osmocom.org/libosmo-abis/commit/?id=d75bac40d1b51a702cd14b35add… commit d75bac40d1b51a702cd14b35add6ff51d38d3994 Author: Philipp Maier <pmaier(a)sysmocom.de> Date: Wed Feb 1 13:51:03 2017 +0100 lapd: Reduce N200 (SABM retransmission count) N200, which controls the maxium number of LAPD retransmissions, is set to 300. This will cause a long waiting time until LAPD detects a failed link. This commit reduces the retransmission count to 50 in order to get a faster link re-establishment in case of link failure. This patch will only affect the ericsson LAPD profile, all other lapd profiles will not be touched. Change-Id: I4f56f9d00520adc0c0a4497547762cd054030867 ----------------------------------------------------------------------- Summary of changes: src/input/lapd.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) hooks/post-receive -- Osmocom A-bis protcol interface library

8 years, 3 months

libosmocore.git branch master updated. 0.9.6-139-g4cb0c8b

by gitosis＠osmocom.org

8 years, 3 months

openbsc.git branch master updated. 0.15.0-716-g11368118c

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 11368118c91eb2a94224d494558b38d05414d3c3 (commit) from 2459f9fb5ab0aa8a8396da3c567fef6a8704e893 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=11368118c91eb2a94224d494558b38d0… commit 11368118c91eb2a94224d494558b38d05414d3c3 Author: Alexander Couzens <lynxis(a)fe80.eu> Date: Mon Nov 28 23:26:50 2016 +0100 libbsc: add chreq type for CHREQ_T_PDCH_ONE_PHASE & CHREQ_T_PDCH_TWO_PHASE When using a BSC located PCU the BSC must understand PDCH requests. Change-Id: Ie7f4ed000cf1b40d269873cf0ddf5ff9f5bbc18a ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gsm_data.h | 2 +- openbsc/include/openbsc/gsm_data_shared.h | 1 + openbsc/src/libbsc/gsm_04_08_utils.c | 16 ++++++++++++++-- 3 files changed, 16 insertions(+), 3 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

8 years, 3 months

libosmocore.git branch master updated. 0.9.6-138-g45e778d

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 45e778d397a525956e377567d5f9af6318a5343e (commit) via bb6f7b7becb138da78c0f677d6340065f91d0067 (commit) via 82c9a0ec198d83452a4232f288e230b59fa1eaf8 (commit) via 5fe3d1b0f7d40bd80733b23575e40b9544652fc4 (commit) via d3b58730d5c86db96ee51e458ad35596617bebe9 (commit) via 8e1b598c8ae408f0dd15a4460920a4d82eb05a27 (commit) from c733d1421aff288e4ede3a532085104217c27370 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=45e778d397a525956e377567d5f9… commit 45e778d397a525956e377567d5f9af6318a5343e Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Mar 14 02:53:56 2017 +0100 milenage_test: enhance to verify new SQN increments After the legacy mode incrementing with ind_bitlen == 0 is through, do another AUTS run with sensible ind_bitlen and ind, and then two more normal vector generations to verify proper SQN increments. Related: OS#1968 Change-Id: Id6947899ff7b1c82b939f969e163e51ce282bce2 http://cgit.osmocom.org/libosmocore/commit/?id=bb6f7b7becb138da78c0f677d634… commit bb6f7b7becb138da78c0f677d6340065f91d0067 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Mar 13 17:27:17 2017 +0100 osmo_auth_gen_vec: UMTS auth: fix SQN as SEQ || IND So far we incremented SQN by 1, which doesn't match the procedures described in 3GPP TS 33.102. An IND (index) denotes a non-significant part of SQN, and the significant SEQ part needs to be incremented. In OsmoHLR we furthermore want to use the "exception" suggested in annex C.3.4, so that each HLR's client has a fixed IND index. In other words, we will not assign IND cyclically, but keep IND unchanged per auth vector consumer. Add 'ind_bitlen' and 'ind' to the osmo_sub_auth_data.u.umts structure and increment SQN accordingly. Add a comment explaining the details. Because 'ind_bitlen' is still passed as zero, the milenage_test does not change its behavior, which is a feature I want to clearly show in this patch. The test will be expanded for the newly implemented SQN scheme in a subsequent patch. Adjust osmo-auc-gen.c to still show the right SQN and SQN.MS -- because it is passing ind_bitlen == 0, osmo-auc-gen can rely on single increments and know SQN.MS is sqn - 1. Note that osmo-auc-gen_test output remains unchanged. Related: OS#1968 Change-Id: Ibc97e1736a797ffcbf8c1f7d41c5c4518f4e41bf http://cgit.osmocom.org/libosmocore/commit/?id=82c9a0ec198d83452a4232f288e2… commit 82c9a0ec198d83452a4232f288e230b59fa1eaf8 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Mar 13 17:36:17 2017 +0100 osmo_auth_gen_vec: UMTS auth: store last used SQN, not next Prepare for the implementation of splitting SQN increments in SEQ and an IND part; particularly to clearly show where the changes in auth/milenage_test's expectations originate. Rationale: the source of UMTS auth vectors, for us usually OsmoHLR, typically stores the last used SQN, not the next one to be used. Particularly with the upcoming fix of the SQN scheme, this change is important: the next SQN will depend on which entity asks for it, because each auth consumer may have a particular slot in the IND part of SQN. It does not make sense to store the next SQN, because we will not know which consumer that will be for. The milenage_test has always calculated a tuple for SQN == 34. To account for the increment now happening before calculating a tuple, lower the test_aud->sqn by one to 0x21 == 33, so that it is still calculating for SQN == 34. Because we are no longer incrementing SQN after the tuple is generated, milenage_test's expected output after doing an AUTS resync to 31 changes to the next SQN = 32, the SQN used for the generated tuple. (BTW, a subsequent patch will illustrate AUTS in detail.) osmo-auc-gen now needs to pass the user requested SQN less one, because the SQN will be incremented befor generating the auth vector. Also the SQN remains the same after generating, so SQN output needs less decrementing. Note that the expected output for osmo-auc-gen_test remains unchanged, hence the same input arguments (particularly -s <sqn> and -A <auts>) still produce the same results. Note: osmo-hlr regression tests will require adjustments when this patch is merged, because it must now pass desired_sqn - 1 instead of just desired_sqn. See osmo-hlr change-id I4ec5a578537acb1d9e1ebfe00a72417fc3ca5894 . Related: OS#1968 Change-Id: Iadf43f21e0605e9e85f7e8026c40985f7ceff1a3 http://cgit.osmocom.org/libosmocore/commit/?id=5fe3d1b0f7d40bd80733b23575e4… commit 5fe3d1b0f7d40bd80733b23575e40b9544652fc4 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Mar 15 01:16:43 2017 +0100 osmo-auc-gen: clarify SQN output, prepare for SQN changes Upcoming patches will change the way SQN are incremented. Change the SQN related output by osmo-auc-gen so that it also makes sense after these changes, and so that its output is proven to remain unchanged for the same arguments: Always show the SQN used for vector generation when a UMTS vector was generated. Don't show the next SQN, it will not make sense anymore (see later patches). The adjustments of expected output of osmo-auc-gen_test illustrates how the output changes. Related: OS#1968 Change-Id: I35d9c669002ff3e8570e07b444cca34ce57c3b0c http://cgit.osmocom.org/libosmocore/commit/?id=d3b58730d5c86db96ee51e458ad3… commit d3b58730d5c86db96ee51e458ad35596617bebe9 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Mar 15 01:52:58 2017 +0100 add osmo-auc-gen_test Add test for osmo-auc-gen invocations to ensure stability across upcoming SQN increment scheme changes. The test comprises of a shell script that invokes the osmo-auc-gen binary with various milenage parameters, of which the stdout/stderr are verified. More osmo-auc-gen invocations could be added, but my main focus is on the SEQ changes. Instead of manually testing that it still works for each SQN patch, I want this test to do it for me. To make sure that osmo-auc-gen is build before the tests are launched, place 'utils' before 'tests' in the root Makefile.am. Related: OS#1968 Change-Id: Ib4af34201cd2e7d76037bcd31dd89ef18c1a9aec http://cgit.osmocom.org/libosmocore/commit/?id=8e1b598c8ae408f0dd15a4460920… commit 8e1b598c8ae408f0dd15a4460920a4d82eb05a27 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Mar 13 17:36:36 2017 +0100 milenage_test: cosmetic fix: shown value is not SEQ.MS In the milenage_test, the console output printed "SEQ.MS = 33", but 33 is a) the SQN, not SEQ; b) the SQN *after* the next auth generation, i.e. SQN.MS would have been 31. While at it also use the proper PRIu64 from inttypes.h to output the sqn value. This prepares for upcoming sparation of SQN incrementing by SEQ and IND, particularly to clearly show where the changes in auth/milenage_test's expectations originate. Related: OS#1968 Change-Id: Ie83201f1362f3d793ada774f3fc5f89cc0b3fbb7 ----------------------------------------------------------------------- Summary of changes: Makefile.am | 2 +- include/osmocom/crypt/auth.h | 2 + src/gsm/auth_milenage.c | 77 ++++++++++++++++- tests/Makefile.am | 5 +- tests/auth/milenage_test.c | 40 ++++++++- tests/auth/milenage_test.ok | 5 +- .../osmo-auc-gen/osmo-auc-gen_test.err | 0 tests/osmo-auc-gen/osmo-auc-gen_test.ok | 99 ++++++++++++++++++++++ tests/osmo-auc-gen/osmo-auc-gen_test.sh | 30 +++++++ tests/testsuite.at | 7 ++ utils/osmo-auc-gen.c | 27 +++--- 11 files changed, 271 insertions(+), 23 deletions(-) copy debian/libosmocore.install => tests/osmo-auc-gen/osmo-auc-gen_test.err (100%) create mode 100644 tests/osmo-auc-gen/osmo-auc-gen_test.ok create mode 100755 tests/osmo-auc-gen/osmo-auc-gen_test.sh hooks/post-receive -- An utility library for Open Source Mobile Communications

8 years, 3 months

libosmocore.git branch master updated. 0.9.6-132-gc733d14

by gitosis＠osmocom.org

8 years, 3 months

sim-tools.git branch master updated. 85ebb9bc68497e6a059d15484a53449168a94f43

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "ShadyTel SIM Tools for the sysmoUSIM-SJS1". The branch, master has been updated via 85ebb9bc68497e6a059d15484a53449168a94f43 (commit) from 51889889e41f7e3f5864ceb940691daa161a6fde (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/sim/sim-tools/commit/?id=85ebb9bc68497e6a059d15484a… commit 85ebb9bc68497e6a059d15484a53449168a94f43 Author: Harald Welte <laforge(a)gnumonks.org> Date: Wed Mar 15 11:42:19 2017 +0100 update README.md to reflect the modifications for sysmoUSIM-SJS1 (authentication) while the code in this repo has changed in 68cdcdb88bd648fad677686dfd7006ffa8c3516f to support KIC/KID authentication, the README wasn't updated. ----------------------------------------------------------------------- Summary of changes: README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- ShadyTel SIM Tools for the sysmoUSIM-SJS1

8 years, 3 months

← Newer
1
...
16
17
18
19
20
21
22
...
29
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

osmocom-commitlog March 2017