This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom BTS-side code (Abis, scheduling, ...)".
The branch, neels/trx_double_init has been created
at 8195b8d27da5700b003fadabcccb49dbe6ce9a83 (commit)
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-bts/commit/?id=8195b8d27da5700b003fadabcccb49d…
commit 8195b8d27da5700b003fadabcccb49dbe6ce9a83
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Fri Jul 8 02:21:54 2016 +0200
osmo-bts-trx: init OML only once by sending AVSTATE_OK with OPSTATE_ENABLED
When receiving an OPSTART for the BTS object, also set the availability state
to OK. (Note, osmo-bts-trx so far has a hackish implementation of OML. It
simply sends the ->Enabled state changes directly upon receiving an OPSTART.)
Before, the availability would remain at NM_AVSTATE_DEPENDENCY, which caused an
unfortunate chain reaction resulting in osmo-bts-trx going through the
initialization sequence twice:
BTS BSC
|<-----| SITE_MANAGER OPSTART
n |----->| BTS state change: OPSTATE_DISABLED, AVSTATE_DEPENDENCY
o | | This signals to nm_statechg_event() in bts_ipaccess_nanobts.c
r | | to (a) Set BTS Attributes and (b) send BTS OPSTART
m |<-----| Set BTS Attributes (a)
a | | When osmo-bts-trx receives a Set BTS Attributes, it sends
l |----->| CHANNEL state change: OPSTATE_DISABLED x8
| | This signals the BSC to Set CHANNEL Attributes and OPSTART
i |<-----| Set CHANNEL Attributes x8
n |<-----| CHANNEL OPSTART x8
i |----->| CHANNEL state change: OPSTATE_ENABLED, AVSTATE_OK x8
t | |
|<-----| BTS OPSTART (b)
| | osmo-bts-trx immediately replies with:
|----->| BTS state change: OPSTATE_ENABLED, AVSTATE_DEPENDENCY
| | Unfortunately, availability is left at DEPENDENCY,
| | and the NM_OC_BTS case in nm_statechg_event() only
| | checks for availability, not for the opstate.
| | Hence nm_statechg_event() again feels inclined to
| | to (a) Set BTS Attributes and (b) send BTS OPSTART,
| |
--+------+----- This is where the second round starts
| |
s |<-----| Set BTS Attributes (a)
e | | When osmo-bts-trx receives a Set BTS Attributes, it sends
c |----->| CHANNEL state change: OPSTATE_DISABLED x8
o | | All channels are disabled again, and then re-launched:
n |<-----| Set CHANNEL Attributes x8
d |<-----| CHANNEL OPSTART x8
|----->| CHANNEL state change: OPSTATE_ENABLED, AVSTATE_OK x8
| |
i |<-----| BTS OPSTART (b)
n | | osmo-bts-trx again sets the OPSTATE_ENABLED, but since
i | | this time it was already enabled, no further state change
t | | is sent back to the BSC.
This nightmare pivots on two hinges:
1. osmo-bts-trx fails to set BTS availability to AVSTATE_OK.
2. nm_statechg_event() fails to heed the OPSTATE_ENABLED of the BTS state
change.
Note, the configured channels from the first round were not actually taken
down, only the OML OPSTATE_DISABLED were sent.
In this commit, fix the osmo-bts-trx side: send AVSTATE_OK for the BTS object
upon sending OPSTATE_ENABLED, so that only the part marked "normal init" above
is run.
This change applies the same fix to other OML objects, which should make sense
in the same manner, within the current hackish OML implementation:
* NM_OC_BTS
* NM_OC_SITE_MANAGER
* NM_OC_BASEB_TRANSC
* NM_OC_GPRS_NSE
* NM_OC_GPRS_CELL
* NM_OC_GPRS_NSVC
Change-Id: I08aa861f6100568c79750f4fbc9a32e1557b9304
-----------------------------------------------------------------------
hooks/post-receive
--
Osmocom BTS-side code (Abis, scheduling, ...)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "OpenBTS' transceiver retro-fit".
The branch, clkind has been deleted
was 596c48e224d28d79d4964c4481037d95b8dee7d7
-----------------------------------------------------------------------
596c48e224d28d79d4964c4481037d95b8dee7d7 transceiver: Limit CLK IND sending to Rx frame loop
-----------------------------------------------------------------------
hooks/post-receive
--
OpenBTS' transceiver retro-fit
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "OpenBTS' transceiver retro-fit".
The branch, ttsou/fixes has been deleted
was 68475102023be985d45698acb81b888f78db8728
-----------------------------------------------------------------------
68475102023be985d45698acb81b888f78db8728 common: Add mandatory length field to UDP receive calls
-----------------------------------------------------------------------
hooks/post-receive
--
OpenBTS' transceiver retro-fit
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "OpenBTS' transceiver retro-fit".
The branch, ms-dual has been deleted
was 538379876f22d22e6b3d2d703805b64fb080e2bd
-----------------------------------------------------------------------
538379876f22d22e6b3d2d703805b64fb080e2bd Transceiver52M: Enable SCH detection on second RF channel
-----------------------------------------------------------------------
hooks/post-receive
--
OpenBTS' transceiver retro-fit
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".
The branch, neels/pending has been deleted
was 50c696804aa3b95ca29a519ac74aa155154a1b29
-----------------------------------------------------------------------
50c696804aa3b95ca29a519ac74aa155154a1b29 Revert "tbf: Add state WAIT_ASSIGN"
-----------------------------------------------------------------------
hooks/post-receive
--
UNNAMED PROJECT
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom BTS-side code (Abis, scheduling, ...)".
The branch, neels/lc15_dyn_pdch_old_numbering has been updated
discards 636b2efe7e3636ee7cda6820ec222e3d4bd8067b (commit)
discards b0555799e24c9ef5d4296b8a658cd467a33c60c5 (commit)
discards 4cfa2728d4d73704d0dcd8c142ce92059f8954aa (commit)
discards f8d908ab333bda3fb4bff10bbb90ff414a52a4e8 (commit)
discards 1322e479226063af0a363bbbebae332b057f8602 (commit)
discards e174d20c5cfc06fecce4a861dc5f7ac52535e463 (commit)
discards 7d210770a9ef5d2e30641319dc9b304b79e80f72 (commit)
via 3eaaa18e2aa4b831ea83155c7a6fc282b17aa749 (commit)
via 1c1b0e843d50b3bc6d82bb78e09242a4d0b7b21f (commit)
via e3edc17426139e16da869ac62f80ce45bd452935 (commit)
via 7267a0d37e54321565a5388a3c8abd3efc573c74 (commit)
via d5f95c308b836dd84753edafb7a63c19a2f36e98 (commit)
via bb1e3b089b9818e9d62f5a673d31ea39ff7cec6e (commit)
via c03d3ae7af27edc035316f9d21aab5437f934b07 (commit)
via 5c0d88e69d16426d8e7af5bf4b7866aa33132064 (commit)
via 4fa641d7b22116c7b1af0bf80ebe6ab78a06cee9 (commit)
via 64e3813b060d626ae9f767238ca018e0f697adf0 (commit)
via 9797a72cd7a259a642ce776519f0d34f3e7338e6 (commit)
via 99642656a067c2e16a1b2f1e5eb34529564c584d (commit)
via c2874c4360be5692ead62f78b82d8ab962c8dc7b (commit)
via 3f919171efc52c88f54cc9140588854e14d152b5 (commit)
via a4c68023154f4ac3b3fc31e1566896f9280244a9 (commit)
via 0eaa27a6beb5136fc17d99df022d58eb410b0e5c (commit)
via 037dcfe98197e91b13bbc943d128b136355f05b5 (commit)
via 380a2e6d902fbfb00fdba9bd81abc0f0b7b2093b (commit)
via ccb11487174545672571515cf98671b0267fa141 (commit)
via 724412a49aa86ec2d2836d9ea9da0a9ce46d665c (commit)
via f0d6d6ba02eb79c2b42d0755372b773684c1f7cf (commit)
via dd084e6e57ee31ae260e8fc16d33e55cff0feeec (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (636b2efe7e3636ee7cda6820ec222e3d4bd8067b)
\
N -- N -- N (3eaaa18e2aa4b831ea83155c7a6fc282b17aa749)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-bts/commit/?id=3eaaa18e2aa4b831ea83155c7a6fc28…
commit 3eaaa18e2aa4b831ea83155c7a6fc282b17aa749
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Tue Jun 21 18:55:01 2016 +0200
Revert "LC15: Hardware changes:"
This reverts commit cbbce0be0965c3160c4916384c3d3d5303c57ae2.
-----------------------------------------------------------------------
Summary of changes:
contrib/screenrc-sysmobts | 2 +-
contrib/sysmobts.service | 2 +-
include/osmo-bts/l1sap.h | 2 +
include/osmo-bts/msg_utils.h | 1 +
src/common/l1sap.c | 4 +-
src/common/msg_utils.c | 17 +++++--
src/common/phy_link.c | 1 +
src/common/rsl.c | 8 +--
src/osmo-bts-litecell15/calib_file.c | 4 +-
src/osmo-bts-litecell15/l1_if.c | 16 ++----
src/osmo-bts-litecell15/lc15bts_vty.c | 2 +
src/osmo-bts-litecell15/tch.c | 61 ++---------------------
src/osmo-bts-octphy/l1_if.c | 16 ++----
src/osmo-bts-octphy/l1_tch.c | 38 ---------------
src/osmo-bts-sysmo/l1_if.c | 16 ++----
src/osmo-bts-sysmo/misc/sysmobts_eeprom.h | 2 +-
src/osmo-bts-sysmo/misc/sysmobts_par.c | 6 +++
src/osmo-bts-sysmo/tch.c | 62 ++---------------------
src/osmo-bts-trx/Makefile.am | 4 +-
src/osmo-bts-trx/amr.c | 81 -------------------------------
src/osmo-bts-trx/amr.h | 8 ---
src/osmo-bts-trx/l1_if.c | 9 +---
src/osmo-bts-trx/scheduler_trx.c | 51 +++++++++++--------
src/osmo-bts-trx/trx_if.c | 2 +-
24 files changed, 98 insertions(+), 317 deletions(-)
delete mode 100644 src/osmo-bts-trx/amr.c
delete mode 100644 src/osmo-bts-trx/amr.h
hooks/post-receive
--
Osmocom BTS-side code (Abis, scheduling, ...)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom BTS-side code (Abis, scheduling, ...)".
The branch, neels/lc15_dyn_pdch has been deleted
was b0555799e24c9ef5d4296b8a658cd467a33c60c5
-----------------------------------------------------------------------
b0555799e24c9ef5d4296b8a658cd467a33c60c5 dyn PDCH: lc15: complete for litecell15-bts: implement bts_model_ts_*()
-----------------------------------------------------------------------
hooks/post-receive
--
Osmocom BTS-side code (Abis, scheduling, ...)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom BTS-side code (Abis, scheduling, ...)".
The branch, neels/pending2 has been deleted
was 3ee8e7449b124ab986e88d9676dcb3fcb4bfa5ed
-----------------------------------------------------------------------
3ee8e7449b124ab986e88d9676dcb3fcb4bfa5ed fix compiler warning: remove unused variable 'i' in calib_verify()
-----------------------------------------------------------------------
hooks/post-receive
--
Osmocom BTS-side code (Abis, scheduling, ...)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom BTS-side code (Abis, scheduling, ...)".
The branch, neels/pending1 has been deleted
was 812e747b4c9ac6972283a09c1659bb121114680b
-----------------------------------------------------------------------
812e747b4c9ac6972283a09c1659bb121114680b dyn PDCH: safeguard: exit if nothing pending in dyn_pdch_ts_disconnected()
-----------------------------------------------------------------------
hooks/post-receive
--
Osmocom BTS-side code (Abis, scheduling, ...)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom BTS-side code (Abis, scheduling, ...)".
The branch, neels/pending3 has been deleted
was 740f28ef13c332386580ccd988099afac068952e
-----------------------------------------------------------------------
740f28ef13c332386580ccd988099afac068952e vty: install orphaned trx nominal power command
-----------------------------------------------------------------------
hooks/post-receive
--
Osmocom BTS-side code (Abis, scheduling, ...)