osmocom-commitlog November 2015

osmocom-commitlog@lists.osmocom.org

1 participants
158 discussions

Start a nNew thread

libosmocore.git branch jerlbeck/wip/stats updated. 0.9.0-18-gd125133
by gitosis＠osmocom.org 09 Nov '15

09 Nov '15

1 0

libosmocore.git branch jerlbeck/wip/stats updated. 0.9.0-18-g23947ee
by gitosis＠osmocom.org 09 Nov '15

09 Nov '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, jerlbeck/wip/stats has been updated discards cd7a5c069e96a747ef27536e250e582c97828863 (commit) discards 9872b4b70497773c2632931e55cc8830526b86b2 (commit) discards c79eae2c6113cca531bf19350ea11f7a84caac16 (commit) via 23947ee21e5ba0e40d97776b3fc67f8aea59793a (commit) via 36b007182d84ed0e7b318860036697dd99262de9 (commit) via b75510fda1fb7c65e65e4c7c28b2cd30abc3d035 (commit) via 01e8c91df517fbf27d769a07630ac8177cf0328d (commit) via 8a97cb911122f112a1a829f6f5d2be3922153a74 (commit) via aed7c125fdfe743a78cb3fd8123af5257a900df9 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (cd7a5c069e96a747ef27536e250e582c97828863) \ N -- N -- N (23947ee21e5ba0e40d97776b3fc67f8aea59793a) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=23947ee21e5ba0e40d97776b3fc6… commit 23947ee21e5ba0e40d97776b3fc67f8aea59793a Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Nov 9 17:25:27 2015 +0100 stats/test: Add test for reporting This tests uses a dedicated test reported to check several aspects of the value reporting. - addition/removal of stats reporter - addition/removal of counters/items - setting of max_class - initial value flush - updating single counters/items Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=36b007182d84ed0e7b3188600366… commit 36b007182d84ed0e7b318860036697dd99262de9 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Nov 9 15:48:25 2015 +0100 stats: Reorder functions in stats.c Due to prior refactoring, the functions do not have an sensible order in the file. This commit tries to improve that a little bit. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=b75510fda1fb7c65e65e4c7c28b2… commit b75510fda1fb7c65e65e4c7c28b2cd30abc3d035 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Nov 9 15:33:44 2015 +0100 stats: Move statsd related code into a separate file This commit moves the stats specific code parts into stats_statsd.c while keeping the generic parts in stats.c. The code in stats.c no longer contains references to statsd symbols. Note that the VTY code still needs to know about every stats reporter backend. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: include/osmocom/core/stats.h | 16 ++- src/Makefile.am | 2 +- src/stats.c | 268 ++++++++++++------------------------------- src/stats_statsd.c | 158 +++++++++++++++++++++++++ tests/stats/stats_test.c | 252 +++++++++++++++++++++++++++++++++++++--- tests/stats/stats_test.ok | 88 ++++++++++++++ 6 files changed, 568 insertions(+), 216 deletions(-) create mode 100644 src/stats_statsd.c hooks/post-receive -- An utility library for Open Source Mobile Communications

1 0

libosmocore.git branch master updated. 0.9.0-15-g01e8c91
by gitosis＠osmocom.org 09 Nov '15

09 Nov '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 01e8c91df517fbf27d769a07630ac8177cf0328d (commit) via 8a97cb911122f112a1a829f6f5d2be3922153a74 (commit) via aed7c125fdfe743a78cb3fd8123af5257a900df9 (commit) from 916423ef9585c7042730fdb17f55afc376565d32 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=01e8c91df517fbf27d769a07630a… commit 01e8c91df517fbf27d769a07630ac8177cf0328d Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Nov 9 14:13:23 2015 +0100 stats: Fix not reported stat item values Currently the global stat item index is being advanced in osmo_stat_item_group_handler, so that the second and further groups in the list will skip new item values. This commit moves the call to osmo_stat_item_discard_all into osmo_stats_report to a place where all groups have been processed already. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=8a97cb911122f112a1a829f6f5d2… commit 8a97cb911122f112a1a829f6f5d2be3922153a74 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Nov 9 11:39:42 2015 +0100 stats: Fix handling of multiple resporters Currently the reporter loop is aborted, if the event would be ignored due to an insufficient max_level. Thus the reporters that happen to be stored afterwards would be skipped even if their level were sufficient. This commit replaces the conditional 'return' statement by a considtional 'continue' statement to ensure the processing of the list tail. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=aed7c125fdfe743a78cb3fd8123a… commit aed7c125fdfe743a78cb3fd8123af5257a900df9 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Nov 9 11:25:12 2015 +0100 stats: Send all values on reporter update Currently only counter changes and new item values are being reported. This makes it cumbersome to configure reporting clients, since there is nothing like a list of all parameters. This commit changes this behaviour such that all currently existing counters and items that would be reported eventually, are passed to the reporter when it has been reconfigured or enabled. If a counter has not been incremented, 0 is sent. If a stat item value has not been added, the last item value (or the default value if there is none) is resent again. Note that this will not catch transient counters/items that will be created later on, e.g. triggered by new peers or subscribers. To just force this kind of dump on a running reporter, it is sufficient to invoke the 'enable' command in its configuration node. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: include/osmocom/core/stats.h | 1 + src/stats.c | 41 ++++++++++++++++++++++++++++++----------- 2 files changed, 31 insertions(+), 11 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications

1 0

openbsc.git branch neels/gtphub updated. 0.15.0-27-g3c2e957
by gitosis＠osmocom.org 09 Nov '15

09 Nov '15

1 0

libosmocore.git branch jerlbeck/wip/stats updated. 0.9.0-15-gcd7a5c0
by gitosis＠osmocom.org 09 Nov '15

09 Nov '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, jerlbeck/wip/stats has been updated discards 749952e90fd40d3a6bf17ac173d890f2fadbc4c8 (commit) discards 872d8aeea0cf3c2d12dca5d30940e02daba33562 (commit) discards 7c3f729db2c33842c2dad702dfe4251dea4a06be (commit) discards e007a9ee8bc59d04cb1672df0e3c8ab32001f0d7 (commit) discards a328503f309d8e0424d996c68c96b9e9072da230 (commit) via cd7a5c069e96a747ef27536e250e582c97828863 (commit) via 9872b4b70497773c2632931e55cc8830526b86b2 (commit) via c79eae2c6113cca531bf19350ea11f7a84caac16 (commit) via 916423ef9585c7042730fdb17f55afc376565d32 (commit) via 834819471a024a98cf6062f1e20c75a9b9e26f88 (commit) via aab4a2497c59d83c396881aaa661a054978f8f7c (commit) via eed4695d062a64c78340d24d53ae7066e6c7c1fd (commit) via 495b0dbd24627a9289e9bdb8ef2f80af6af3445f (commit) via 6e149b1f1aceb86e694e090b5ba4ccb349edcbf2 (commit) via 59b90bc44401dc0e4c5004b0fec677106bce8871 (commit) via fed2a488b94fc24df4f5548f98a71bb98920a66a (commit) via be37fb7db4651f245994fa73008b4aa92c21c14f (commit) via ca6602f476775e1b55c5a1d41bc323c49b9e4290 (commit) via ee2657f6af4b81f98cfdfd900a82d9a350ff3642 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (749952e90fd40d3a6bf17ac173d890f2fadbc4c8) \ N -- N -- N (cd7a5c069e96a747ef27536e250e582c97828863) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=cd7a5c069e96a747ef27536e250e… commit cd7a5c069e96a747ef27536e250e582c97828863 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Nov 9 14:13:23 2015 +0100 stats: Fix not reported stat item values Currently the global stat item index is being advanced in osmo_stat_item_group_handler, so that the second and further groups in the list will skip new item values. This commit moves the call to osmo_stat_item_discard_all into osmo_stats_report to a place where all groups have been processed already. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=9872b4b70497773c2632931e55cc… commit 9872b4b70497773c2632931e55cc8830526b86b2 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Nov 9 11:39:42 2015 +0100 stats: Fix handling of multiple resporters Currently the reporter loop is aborted, if the event would be ignored due to an insufficient max_level. Thus the reporters that happen to be stored afterwards would be skipped even if their level were sufficient. This commit replaces the conditional 'return' statement by a considtional 'continue' statement to ensure the processing of the list tail. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=c79eae2c6113cca531bf19350ea1… commit c79eae2c6113cca531bf19350ea11f7a84caac16 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Nov 9 11:25:12 2015 +0100 stats: Send all values on reporter update Currently only counter changes and new item values are being reported. This makes it cumbersome to configure reporting clients, since there is nothing like a list of all parameters. This commit changes this behaviour such that all currently existing counters and items that would be reported eventually, are passed to the reporter when it has been reconfigured or enabled. Note that this will not catch transient counters/items that will be created later on, e.g. triggered by new peers or subscribers. To just force this kind of dump on a running reporter, it is sufficient to invoke the 'enable' command in its configuration node. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: debian/changelog | 12 +++++++ include/osmocom/core/rate_ctr.h | 5 +++ include/osmocom/core/stat_item.h | 6 ++++ include/osmocom/core/stats.h | 1 + src/gb/gprs_ns.c | 2 ++ src/stats.c | 67 +++++++++++++++++++++++++++------------- src/vty/stats_vty.c | 1 + utils/osmo-sim-test.c | 1 + 8 files changed, 73 insertions(+), 22 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications

1 0

openbsc.git branch neels/gtphub updated. 0.15.0-26-g40f44ea
by gitosis＠osmocom.org 09 Nov '15

09 Nov '15

1 0

openbsc.git branch fairwaves/sup updated. fairwaves/0.14.0-fw.2-12-g27c9053
by gitosis＠osmocom.org 09 Nov '15

09 Nov '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, fairwaves/sup has been updated via 27c905310b039e5c7ce03c44ff9b7254c35c32f9 (commit) from 3e374dbbb4474a3429fac102baf8446f4ac5f13b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=27c905310b039e5c7ce03c44ff9b7254… commit 27c905310b039e5c7ce03c44ff9b7254c35c32f9 Author: Ivan Kluchnikov <kluchnikovi(a)gmail.com> Date: Mon Nov 9 14:44:15 2015 +0300 sup: fix handling update location result message If LUR procedure timed out, we should just skip update location result message. ----------------------------------------------------------------------- Summary of changes: openbsc/src/libmsc/gsm_sup.c | 6 ++++++ 1 file changed, 6 insertions(+) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

libosmocore.git branch master updated. 0.9.0-12-g916423e
by gitosis＠osmocom.org 09 Nov '15

09 Nov '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 916423ef9585c7042730fdb17f55afc376565d32 (commit) from 834819471a024a98cf6062f1e20c75a9b9e26f88 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=916423ef9585c7042730fdb17f55… commit 916423ef9585c7042730fdb17f55afc376565d32 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Nov 9 10:52:19 2015 +0100 stats: Fix name prefix handling Currently the having an unset prefix leads to an abort() in the statsd reporter due to an fprintf format string error. In addition the prefix cannot be reset to its initial state (NULL) by using 'no prefix', which just sets the prefix to the empty string, causing a single leading dot to appear in front of the name. This commit changes the implemenation to consistly use NULL for the unset name prefix ('no prefix') and to handle this case correctly in the statsd reporter. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: src/stats.c | 34 +++++++++++++++++++++++----------- 1 file changed, 23 insertions(+), 11 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications

1 0

openbsc.git branch neels/gtphub updated. 0.15.0-26-g44b1267
by gitosis＠osmocom.org 09 Nov '15

09 Nov '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, neels/gtphub has been updated discards 224672f8ba6cc3396dfe2a02a0faa692025f19c6 (commit) discards 0aa62ee3767ce6d9a7d9fb4a0fcea31d582533ac (commit) discards cdca81c508b2d6c1f61aa91c5cf7ab8541c23127 (commit) via 44b12671f4f811412fab2298036c83457ac6ed42 (commit) via ff2aff90be399d57e26fe2b9d60355d78b93443c (commit) via 933e2762896ec00872068e5a1d605a1bf14d8e80 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (224672f8ba6cc3396dfe2a02a0faa692025f19c6) \ N -- N -- N (44b12671f4f811412fab2298036c83457ac6ed42) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=44b12671f4f811412fab2298036c8345… commit 44b12671f4f811412fab2298036c83457ac6ed42 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sun Nov 8 23:39:57 2015 +0100 gtphub: lose the netcat test. http://cgit.osmocom.org/openbsc/commit/?id=ff2aff90be399d57e26fe2b9d60355d7… commit ff2aff90be399d57e26fe2b9d60355d78b93443c Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sun Nov 8 20:34:47 2015 +0100 gtphub: add first bits of GRX ares For the resolving function, change the function signature to return a gtphub_peer_port. In consequence, publish two functions concerned with gtphub_peer_port instances for use in test and gtphub_ext.c. Add GGSN resolution queue, callback and cache. Simple implementation: if an SGSN asks for a GGSN, it will first get no answer, and I hope it will ask again once the GGSN is in the cache. Within gtphub_ext.c, have a dummy sgsn struct, as the sgsn_ares code currently depends on it (half the functions pass an sgsn instance pointer around, but the other half use the global one). In the unit tests, wrap away the ares initialization so that they can work without a DNS server around. The netcat test breaks because of this, will remove it. Using sgsn_ares, implement the gtphub_resolve_ggsn_addr() function, I hope: untested. Minor cosmetics just to see if you're paying attention... ;) http://cgit.osmocom.org/openbsc/commit/?id=933e2762896ec00872068e5a1d605a1b… commit 933e2762896ec00872068e5a1d605a1bf14d8e80 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Sep 24 17:32:30 2015 +0200 Add GTP hub (code bomb). First steps towards a new GTP hub. The aim is to mux GTP connections, so that multiple SGSN <--> GGSN links can pass through a single point. Background: allow having more than one SGSN, possibly in various remote locations. The recent addition of OAP to GSUP is related to the same background idea. (This is a collapsed patch of various changes that do not make sense to review in chronological order anymore, since a lot of it has thorougly transmorphed after it was first committed.) Sponsored-by: On-Waves ehf gtphub: decode IE GSN addr using inet_ntop. gtphub: cosmetic: fix a name. map addresses wip gtphub: fix style: '} else {' gtphub: restructure Allow multiple addresses per peer. Allow multiple ports per address. Don't track ctrl<->user plane peers, allow any number of them. Have a single TEI map per plane, across all GGSNs and SGSNs. This is not only simpler, but necessary to establish mappings during a Create PDP Context Request <-> Response (thanks Holger!) -- during a Create PDP Context Request, we want to map TEI numbers before sending to the GGSN, but the GGSN has not announced its final tunnel endpoint addresses yet. We can't find an unused TEI for a given address if we don't know the address. The solution is to have globally unique mapped TEIs (per Ctrl / User plane). Change naming: "port" to "plane". There's now a gtphub_peer_port, so the "port" naming for the planes was confusing. Separate expiry from nr_map. It happened along the way, becoming obsolete again by the central TEI map, and now the code is there. Constify. gtphub: cosmetic Tweak comment. Rename gtphub_sep.c to gtphub_ext.c (personal preference) and add copyright header. Sort some definitions around in gtphub.c. In gtphub_from_sgsns_handle_buf, move a variable into the scope where it is used. Remove a debug peer counter. gtphub_test: cosmetic Rename seq_map_is to nr_map_is. gtphub: pull out current time to unit tests. An obsolete forward definition is dropped along the way. gtphub: publish gtphub_port_find_sa() to enhance test gtphub_test: find the GGSN peer struct and verify seq_map entries and timeouts. Also verify tei_map entries and timeouts. ----------------------------------------------------------------------- Summary of changes: openbsc/src/gprs/gtphub.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

openbsc.git branch neels/gtphub updated. 0.15.0-26-g224672f
by gitosis＠osmocom.org 08 Nov '15

08 Nov '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, neels/gtphub has been updated discards 989873f7bd632c371d1f114881794eb1345dcad2 (commit) discards c3dc638f6b02a4325046ce651628d607670a4424 (commit) via 224672f8ba6cc3396dfe2a02a0faa692025f19c6 (commit) via 0aa62ee3767ce6d9a7d9fb4a0fcea31d582533ac (commit) via cdca81c508b2d6c1f61aa91c5cf7ab8541c23127 (commit) via 32ff8aeff0fc33be8646e3a3b82f1948e6e89644 (commit) via 9270dc8ca347e775f25272aa2cd904e53c93de29 (commit) via 4316cb2f25a583ed759d6823ce9a1b7650e178a9 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (989873f7bd632c371d1f114881794eb1345dcad2) \ N -- N -- N (224672f8ba6cc3396dfe2a02a0faa692025f19c6) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=224672f8ba6cc3396dfe2a02a0faa692… commit 224672f8ba6cc3396dfe2a02a0faa692025f19c6 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sun Nov 8 23:39:57 2015 +0100 gtphub: lose the netcat test. http://cgit.osmocom.org/openbsc/commit/?id=0aa62ee3767ce6d9a7d9fb4a0fcea31d… commit 0aa62ee3767ce6d9a7d9fb4a0fcea31d582533ac Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sun Nov 8 20:34:47 2015 +0100 gtphub: add first bits of GRX ares For the resolving function, change the function signature to return a gtphub_peer_port. In consequence, publish two functions concerned with gtphub_peer_port instances for use in test and gtphub_ext.c. Add GGSN resolution queue, callback and cache. Simple implementation: if an SGSN asks for a GGSN, it will first get no answer, and I hope it will ask again once the GGSN is in the cache. Within gtphub_ext.c, have a dummy sgsn struct, as the sgsn_ares code currently depends on it (half the functions pass an sgsn instance pointer around, but the other half use the global one). In the unit tests, wrap away the ares initialization so that they can work without a DNS server around. The netcat test breaks because of this, will remove it. Using sgsn_ares, implement the gtphub_resolve_ggsn_addr() function, I hope: untested. Minor cosmetics just to see if you're paying attention... ;) http://cgit.osmocom.org/openbsc/commit/?id=cdca81c508b2d6c1f61aa91c5cf7ab85… commit cdca81c508b2d6c1f61aa91c5cf7ab8541c23127 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Sep 24 17:32:30 2015 +0200 Add GTP hub (code bomb). First steps towards a new GTP hub. The aim is to mux GTP connections, so that multiple SGSN <--> GGSN links can pass through a single point. Background: allow having more than one SGSN, possibly in various remote locations. The recent addition of OAP to GSUP is related to the same background idea. (This is a collapsed patch of various changes that do not make sense to review in chronological order anymore, since a lot of it has thorougly transmorphed after it was first committed.) Sponsored-by: On-Waves ehf gtphub: decode IE GSN addr using inet_ntop. gtphub: cosmetic: fix a name. map addresses wip gtphub: fix style: '} else {' gtphub: restructure Allow multiple addresses per peer. Allow multiple ports per address. Don't track ctrl<->user plane peers, allow any number of them. Have a single TEI map per plane, across all GGSNs and SGSNs. This is not only simpler, but necessary to establish mappings during a Create PDP Context Request <-> Response (thanks Holger!) -- during a Create PDP Context Request, we want to map TEI numbers before sending to the GGSN, but the GGSN has not announced its final tunnel endpoint addresses yet. We can't find an unused TEI for a given address if we don't know the address. The solution is to have globally unique mapped TEIs (per Ctrl / User plane). Change naming: "port" to "plane". There's now a gtphub_peer_port, so the "port" naming for the planes was confusing. Separate expiry from nr_map. It happened along the way, becoming obsolete again by the central TEI map, and now the code is there. Constify. gtphub: cosmetic Tweak comment. Rename gtphub_sep.c to gtphub_ext.c (personal preference) and add copyright header. Sort some definitions around in gtphub.c. In gtphub_from_sgsns_handle_buf, move a variable into the scope where it is used. Remove a debug peer counter. gtphub_test: cosmetic Rename seq_map_is to nr_map_is. gtphub: pull out current time to unit tests. An obsolete forward definition is dropped along the way. gtphub: publish gtphub_port_find_sa() to enhance test gtphub_test: find the GGSN peer struct and verify seq_map entries and timeouts. Also verify tei_map entries and timeouts. http://cgit.osmocom.org/openbsc/commit/?id=32ff8aeff0fc33be8646e3a3b82f1948… commit 32ff8aeff0fc33be8646e3a3b82f1948e6e89644 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Oct 19 14:37:12 2015 +0200 sgsn_vty.c: fix typo ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gtphub.h | 24 ++++ openbsc/src/gprs/Makefile.am | 6 +- openbsc/src/gprs/gprs_utils.c | 1 + openbsc/src/gprs/gtphub.c | 148 ++++++++++++-------- openbsc/src/gprs/gtphub_ext.c | 174 ++++++++++++++++++++---- openbsc/src/utils/meas_udp2db.c | 1 + openbsc/src/utils/meas_vis.c | 2 + openbsc/tests/gtphub/Makefile.am | 3 +- openbsc/tests/gtphub/gtphub_nc_test.gtphub.conf | 5 - openbsc/tests/gtphub/gtphub_nc_test.ok | 7 - openbsc/tests/gtphub/gtphub_nc_test.sh | 85 ------------ openbsc/tests/gtphub/gtphub_test.c | 122 +++++++++++++---- openbsc/tests/gtphub/gtphub_test.ok | 4 +- openbsc/tests/gtphub/hex2bin.py | 13 -- openbsc/tests/testsuite.at | 5 - 15 files changed, 371 insertions(+), 229 deletions(-) delete mode 100644 openbsc/tests/gtphub/gtphub_nc_test.gtphub.conf delete mode 100644 openbsc/tests/gtphub/gtphub_nc_test.ok delete mode 100755 openbsc/tests/gtphub/gtphub_nc_test.sh delete mode 100755 openbsc/tests/gtphub/hex2bin.py hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

← Newer
1
...
7
8
9
10
11
12
13
...
16
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

osmocom-commitlog November 2015