Attention is currently required from: fixeria. keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31131 )

Change subject: LCLS: Fix Global Call Reference generation ......................................................................

Patch Set 2:

(2 comments)

File src/libmsc/transaction.c:

https://gerrit.osmocom.org/c/osmo-msc/+/31131/comment/8e6a083b_e064df77 PS1, Line 165: %sfor

missing space between '%s' and 'for'

Actually done intentionally, because osmo_hexdump() seems to add a space at the end. If I add the "missing" space then the log line will contain two spaces.

https://gerrit.osmocom.org/c/osmo-msc/+/31131/comment/4fe15bb1_ac4f8812 PS1, Line 165: 0x%x

0x04x to ensure consistent formatting

I'm guessing you mean 0x%04x, although I don't understand why. It's 4 octets anyway, no? - the logging macro often logging callref uses: ..... LOGP(subsys, level, \ "trans(%s %s callref-0x%x tid-%u%s) " fmt, \ ....

But I trust your request, I hope I have it right.