Attention is currently required from: fixeria.

View Change

2 comments:

• File src/libmsc/transaction.c:

  • Patch Set #1, Line 165: %sfor

    missing space between '%s' and 'for'

    Actually done intentionally, because osmo_hexdump() seems to add a space at the end. If I add the "missing" space then the log line will contain two spaces.

  • Patch Set #1, Line 165: 0x%x

    0x04x to ensure consistent formatting

    I'm guessing you mean 0x%04x, although I don't understand why. It's 4 octets anyway, no? -  the logging macro often logging callref uses: 
            .....
    	LOGP(subsys, level, \
    	     "trans(%s %s callref-0x%x tid-%u%s) " fmt, \
    	....

    But I trust your request, I hope I have it right.

To view, visit change 31131. To unsubscribe, or for help writing mail filters, visit settings.