Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31033 )

Change subject: Add L1 signals to misdn driver ......................................................................

Patch Set 3:

(3 comments)

File src/input/misdn.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/31033/comment/e0994732_914d1617 PS3, Line 115: LOGP(DLMI, LOGL_DEBUG, "L1_SIGNAL_LOS_OFF\n"); did you think about using a value_string to print the type?

https://gerrit.osmocom.org/c/libosmo-abis/+/31033/comment/dbe1f250_4e4d3926 PS3, Line 274: mph_information_ind(line, *((int *)msg->data)); this looks weird, since you are reading an unspecified length (int) from msgb. Maybe uint32_t?

https://gerrit.osmocom.org/c/libosmo-abis/+/31033/comment/b91ef3fc_75f610d4 PS3, Line 636: mph_information_ind(line, *((int *)msg->data)); same. uint32_t?