Attention is currently required from: jolly.

View Change

3 comments:

• File src/input/misdn.c:

  • Patch Set #3, Line 115: LOGP(DLMI, LOGL_DEBUG, "L1_SIGNAL_LOS_OFF\n");

    did you think about using a value_string to print the type?

  • Patch Set #3, Line 274: mph_information_ind(line, *((int *)msg->data));

    this looks weird, since you are reading an unspecified length (int) from msgb. Maybe uint32_t?

  • Patch Set #3, Line 636: mph_information_ind(line, *((int *)msg->data));

    same. uint32_t?

To view, visit change 31033. To unsubscribe, or for help writing mail filters, visit settings.