Attention is currently required from: osmith.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33525 )

Change subject: Re-store last LLC frames never completely acked when freeing DL TBF ......................................................................

Patch Set 2:

(2 comments)

File src/llc.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/33525/comment/4efed514_77842342 PS2, Line 368: OSMO_ASSERT(info);

maybe add a comment on top of the function that the queue must not be empty if out_info is set?

If the queue is empty, msg=NULL and return in line 362 occurs, so this case you say cannot happen.

File src/tbf_dl.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/33525/comment/6ea3ec69_c7f9e926 PS2, Line 546: if any

might be a bit nitpicky, but the "if any" part is dealt with above; now the function will assert if […]

See my other comment, function doesn't assert.