Attention is currently required from: osmith.

View Change

2 comments:

• File src/llc.c:

  • Patch Set #2, Line 368: OSMO_ASSERT(info);

    maybe add a comment on top of the function that the queue must not be empty if out_info is set?

    If the queue is empty, msg=NULL and return in line 362 occurs, so this case you say cannot happen.

• File src/tbf_dl.cpp:

  • Patch Set #2, Line 546: if any

    might be a bit nitpicky, but the "if any" part is dealt with above; now the function will assert if […]

    See my other comment, function doesn't assert.

To view, visit change 33525. To unsubscribe, or for help writing mail filters, visit settings.