Attention is currently required from: fixeria, laforge, neels, pespin.

Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email )

Change subject: Add Emscripten build support and JS callback logging backend ......................................................................

Patch Set 22:

(2 comments)

File src/core/netdev.c:

https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/bd6cdc38_1ff8e0e1?u... : PS5, Line 67: #if (!EMBEDDED) && !defined(__EMSCRIPTEN__)

I'm delaying review of this patch until the previous one regarding netdev is solved, because anyway […]

I've moved the netdev changes into a separate patch and will address that first.

I dropped the Emscripten-specific include logic and instead guard the Linux netlink headers by the libmnl backend, because the only code that needs <linux/if_link.h>/<linux/rtnetlink.h> is under the libmnl-enabled blocks.

So when libmnl is disabled, we no longer try to include Linux-only headers on non-Linux targets. When libmnl is enabled, requiring those Linux headers is expected.

https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/27e9de57_c1f1ed3f?u... : PS5, Line 67: #if (!EMBEDDED) && !defined(__EMSCRIPTEN__)

I'm delaying review of this patch until the previous one regarding netdev is solved, because anyway […]

I've moved the netdev changes into a separate patch and will address that first.

I dropped the Emscripten-specific include logic and instead guard the Linux netlink headers by the libmnl backend, because the only code that needs <linux/if_link.h>/<linux/rtnetlink.h> is under the libmnl-enabled blocks.

So when libmnl is disabled, we no longer try to include Linux-only headers on non-Linux targets. When libmnl is enabled, requiring those Linux headers is expected.