Attention is currently required from: fixeria, laforge, neels, pespin.

View Change

2 comments:

• File src/core/netdev.c:

  • Patch Set #5, Line 67: #if (!EMBEDDED) && !defined(__EMSCRIPTEN__)

    I'm delaying review of this patch until the previous one regarding netdev is solved, because anyway […]

    I've moved the netdev changes into a separate patch and will address that first.

    I dropped the Emscripten-specific include logic and instead guard the Linux
    netlink headers by the libmnl backend, because the only code that needs
    <linux/if_link.h>/<linux/rtnetlink.h> is under the libmnl-enabled blocks.

    So when libmnl is disabled, we no longer try to include Linux-only headers on
    non-Linux targets. When libmnl is enabled, requiring those Linux headers is
    expected.

  • Patch Set #5, Line 67: #if (!EMBEDDED) && !defined(__EMSCRIPTEN__)

    I'm delaying review of this patch until the previous one regarding netdev is solved, because anyway […]

    I've moved the netdev changes into a separate patch and will address that first.

    I dropped the Emscripten-specific include logic and instead guard the Linux
    netlink headers by the libmnl backend, because the only code that needs
    <linux/if_link.h>/<linux/rtnetlink.h> is under the libmnl-enabled blocks.

    So when libmnl is disabled, we no longer try to include Linux-only headers on
    non-Linux targets. When libmnl is enabled, requiring those Linux headers is
    expected.

To view, visit change 41813. To unsubscribe, or for help writing mail filters, visit settings.