Attention is currently required from: jolly.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979 )

Change subject: ASCI: Add tests for voice group/broadcast calls at MSC ......................................................................

Patch Set 1: Code-Review-1

(2 comments)

File msc/MSC_Tests_ASCI.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979/comment/9e8ac10f_865db... PS1, Line 50: type integer ASCI_TEST; : const ASCI_TEST ASCI_TEST_NO_CALLREF := 1; : const ASCI_TEST ASCI_TEST_SETUP_REFUSE := 2; : const ASCI_TEST ASCI_TEST_ASSIGN_FAIL := 3; : const ASCI_TEST ASCI_TEST_COMPLETE_VGCS := 4; : const ASCI_TEST ASCI_TEST_COMPLETE_VBS := 5; I think this could/should go into an enum, not an integer?

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979/comment/fae9c643_137e5... PS1, Line 65: const charstring COORD_SETUP := "SETUP"; you don't really need to do this with charstring. It's sufficient in TTCN3 to define some enum, and then you can simply print the enum and get a string representation. Or when TITAN generates log lines, the enum names will also be used.

Let's try to make use of the power of the language and not make TTCN-3 code look like C :)