Attention is currently required from: jolly.

Patch set 1:Code-Review -1

View Change

2 comments:

• File msc/MSC_Tests_ASCI.ttcn:

  • Patch Set #1, Line 50:

    type integer ASCI_TEST;
    const ASCI_TEST ASCI_TEST_NO_CALLREF	:= 1;
    const ASCI_TEST ASCI_TEST_SETUP_REFUSE	:= 2;
    const ASCI_TEST ASCI_TEST_ASSIGN_FAIL	:= 3;
    const ASCI_TEST ASCI_TEST_COMPLETE_VGCS	:= 4;
    const ASCI_TEST ASCI_TEST_COMPLETE_VBS	:= 5;
    

    I think this could/should go into an enum, not an integer?

  • Patch Set #1, Line 65: const charstring COORD_SETUP := "SETUP";

    you don't really need to do this with charstring. It's sufficient in TTCN3 to define some enum, and then you can simply print the enum and get a string representation. Or when TITAN generates log lines, the enum names will also be used.

    Let's try to make use of the power of the language and not make TTCN-3 code look like C :)

To view, visit change 33979. To unsubscribe, or for help writing mail filters, visit settings.