Attention is currently required from: pespin.

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41616?usp=email )

Change subject: sctp_proxy: use lists:filter/2 in sctp_send_pending/2 ......................................................................

Patch Set 1:

(1 comment)

File src/sctp_proxy.erl:

https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41616/comment/26a4046b_e3a5e... : PS1, Line 307: lists:reverse(Pending)),

why this reverse? Are you adding them to the tx_queue in reverse order? ie prepending messages?

Yes, it's a normal practice in Erlang: you prepend items to a list and then do the reverse. Appending to a list is possible (`List ++ [Item]`), but this comes with performance penalty, because each addition requires allocating a new list. And please note that the reverse was here before this patch, I am not changing this.