Attention is currently required from: pespin.

View Change

1 comment:

• File src/sctp_proxy.erl:

  • Patch Set #1, Line 307: lists:reverse(Pending)),

    why this reverse? Are you adding them to the tx_queue in reverse order? ie prepending messages?

    Yes, it's a normal practice in Erlang: you prepend items to a list and then do the reverse. Appending to a list is possible (`List ++ [Item]`), but this comes with performance penalty, because each addition requires allocating a new list. And please note that the reverse was here before this patch, I am not changing this.

To view, visit change 41616. To unsubscribe, or for help writing mail filters, visit settings.