Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28325 ) Change subject: bts_chan_load(): also calculate per-TRX channel load ...................................................................... Patch Set 1: (2 comments) File src/osmo-bsc/chan_alloc.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28325/comment/223cd38d_2204e871 PS1, Line 47: struct load_counter *ll = &trx->lchan_load; Lchan Load, first letters of trx->lchan_load. https://gerrit.osmocom.org/c/osmo-bsc/+/28325/comment/6ea00e8a_b532df5f PS1, Line 85: ll->total++; Unfortunately, this is not going to work: * pl (pchan load) is a per-pchan counter, which in this context contains used/total values from previous iterations (other TRXes); * ll (lchan load) is a per-TRX counter, we don't care about pchan types here and we don't want values from previous iterations. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28325 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I220145238c23135f7e68ca2d474764312ffb66c5 Gerrit-Change-Number: 28325 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Jun 2022 19:28:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment