Attention is currently required from: pespin.

View Change

2 comments:

• File src/osmo-bsc/chan_alloc.c:

  • Patch Set #1, Line 47: struct load_counter *ll = &trx->lchan_load;

    I wonder what ll means here.

    Lchan Load, first letters of trx->lchan_load.

  • Patch Set #1, Line 85: ll->total++;

    You can simply do: […]

    Unfortunately, this is not going to work:

    • pl (pchan load) is a per-pchan counter, which in this context contains used/total values from previous iterations (other TRXes);
    • ll (lchan load) is a per-TRX counter, we don't care about pchan types here and we don't want values from previous iterations.

To view, visit change 28325. To unsubscribe, or for help writing mail filters, visit settings.