Attention is currently required from: neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27509 )

Change subject: struct gsm_encr: store alg_id in human-readable format ......................................................................

Patch Set 3:

(6 comments)

This change is ready for review.

Commit Message:

https://gerrit.osmocom.org/c/osmo-bsc/+/27509/comment/ec43a57c_06cadbdd PS2, Line 30: ciph_mod_set = (lchan->encr.alg_id << 1) | 1;

well, in Cipher Mode Setting, it has to be (a5_n - 1) << 1

Indeed, thanks! Fixed in the next patchset revision.

File include/osmocom/bsc/gsm_data.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/27509/comment/fa25f947_37a5464b PS2, Line 613: uint8_t alg_id;

alg_id is named after the Algorithm Identifier IE. […]

Agreed, done.

File src/osmo-bsc/abis_rsl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/27509/comment/c95648f8_54016850 PS2, Line 163: switch (*out++) {

nitpick (ok, it's correct, but IMHO the code becomes far less head scratchy when we don't ++ inline […]

Done

https://gerrit.osmocom.org/c/osmo-bsc/+/27509/comment/dade52f4_2485fa17 PS2, Line 663: if (lchan->encr.alg_id > 0) {

(here is a place where i have to think twice, I thought it is incorrect at first; if the name were a […]

Done

File src/osmo-bsc/gsm_04_08_rr.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/27509/comment/f9bf4d9c_85b2a568 PS2, Line 596: _id

"- 1" is missing now! 44.018 10.5.2. […]

Done

File src/osmo-bsc/gsm_08_08.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/27509/comment/38a76e39_eebd4e6a PS2, Line 88: chosen_encr

also rename this to chosen_a5_n?

Done