Attention is currently required from: neels, pespin.
6 comments:
Commit Message:
Patch Set #2, Line 30: ciph_mod_set = (lchan->encr.alg_id << 1) | 1;
well, in Cipher Mode Setting, it has to be (a5_n - 1) << 1
Indeed, thanks! Fixed in the next patchset revision.
File include/osmocom/bsc/gsm_data.h:
Patch Set #2, Line 613: uint8_t alg_id;
alg_id is named after the Algorithm Identifier IE. […]
Agreed, done.
File src/osmo-bsc/abis_rsl.c:
Patch Set #2, Line 163: switch (*out++) {
nitpick (ok, it's correct, but IMHO the code becomes far less head scratchy when we don't ++ inline […]
Done
Patch Set #2, Line 663: if (lchan->encr.alg_id > 0) {
(here is a place where i have to think twice, I thought it is incorrect at first; if the name were a […]
Done
File src/osmo-bsc/gsm_04_08_rr.c:
"- 1" is missing now! 44.018 10.5.2. […]
Done
File src/osmo-bsc/gsm_08_08.c:
Patch Set #2, Line 88: chosen_encr
also rename this to chosen_a5_n?
Done
To view, visit change 27509. To unsubscribe, or for help writing mail filters, visit settings.