Attention is currently required from: jolly, laforge.
pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email )
Change subject: Automatically increase io_uring, if too small. ......................................................................
Patch Set 13:
(3 comments)
File src/core/osmo_io_uring.c:
https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/467d3a63_0c5a6c39?u... : PS12, Line 194: /* The current ring is full, so we cannot get SQE for the current ring. */ And you removed this block, perhaps you wanted to move it up?
File src/core/osmo_io_uring.c:
https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/342ce93b_fb7c65d7?u... : PS13, Line 187: /* The current ring is full, subsequent reasd SQEs on different ring are not allowed. */ typo: read
https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/949d0777_de3f50e8?u... : PS13, Line 188: if (read && iofd->u.uring.reads_submitted > 0) btw, I think something's wrong here. In last revision you added this check and the one in line 179 which afaiu are checking similar stuff. I think it's probably wrong change you did here.