Attention is currently required from: jolly, laforge.

View Change

3 comments:

• File src/core/osmo_io_uring.c:

  • Patch Set #12, Line 194: /* The current ring is full, so we cannot get SQE for the current ring. */

    And you removed this block, perhaps you wanted to move it up?

• File src/core/osmo_io_uring.c:

  • Patch Set #13, Line 187: /* The current ring is full, subsequent reasd SQEs on different ring are not allowed. */

    typo: read

  • Patch Set #13, Line 188: if (read && iofd->u.uring.reads_submitted > 0)

    btw, I think something's wrong here. In last revision you added this check and the one in line 179 which afaiu are checking similar stuff. I think it's probably wrong change you did here.

To view, visit change 40725. To unsubscribe, or for help writing mail filters, visit settings.