[XS] Change in libosmocore[master]: osmo-release.sh: Fix coloring output under bash - gerrit-log

5 Dec 2025


      Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email )
Change subject: osmo-release.sh: Fix coloring output under bash
......................................................................
Patch Set 2:
(1 comment)
File osmo-release.sh:
https://gerrit.osmocom.org/c/libosmocore/+/41547/comment/3c447f23_d1e6e60c?u... :
PS2, Line 39: 	printf "${GREEN}OK:${RESET} $@\n"
...


actually this is better ("$@" would expand to multiple additional printf arguments whereas we only have one %s):
```suggestion
    printf "${GREEN}OK:${RESET} %s\n" "$1"
```
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib9e33ec8650ad8bc2e4b1893d9a7195c041c52dc
Gerrit-Change-Number: 41547
Gerrit-PatchSet: 2
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Fri, 05 Dec 2025 08:00:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith osmith@sysmocom.de