Attention is currently required from: pespin.
View Change
1 comment:
File osmo-release.sh:
Patch Set #2, Line 39: printf "${GREEN}OK:${RESET} $@\n"
```suggestion […]
actually this is better ("$@" would expand to multiple additional printf arguments whereas we only have one %s):
```suggestion
printf "${GREEN}OK:${RESET} %s\n" "$1"
```
To view, visit change 41547. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib9e33ec8650ad8bc2e4b1893d9a7195c041c52dc
Gerrit-Change-Number: 41547
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Fri, 05 Dec 2025 08:00:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith@sysmocom.de>