Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28602 ) Change subject: Add initial SBc-AP support to osmo-cbc ...................................................................... Patch Set 10: (4 comments) File include/osmocom/cbc/cbc_data.h: https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/56c05280_a0b510eb PS10, Line 23: CBC_PEER_PROTO_SBcAP cosmetic: missing comma File include/osmocom/cbc/internal.h: https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/a6eff4be_d01902c2 PS10, Line 30: enum sbcap_server_event { So we have the same set of events as in enum cbsp_server_event. Can both FSMs simply use a single unified set of events? File src/cbc_data.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/9947dc6a_f858f547 PS10, Line 104: ws, 'unsigned int i' could be added here (scoped variable) File src/smscb_peer_fsm.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/520e6770_6221b929 PS10, Line 483: cosmetic: there should be no space here -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28602 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Ib278bc1d1a74459814016fef7a8fe21cc29d46c9 Gerrit-Change-Number: 28602 Gerrit-PatchSet: 10 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Jul 2022 13:10:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment