Attention is currently required from: pespin.

View Change

4 comments:

• File include/osmocom/cbc/cbc_data.h:

  • Patch Set #10, Line 23: CBC_PEER_PROTO_SBcAP

    cosmetic: missing comma

• File include/osmocom/cbc/internal.h:

  • Patch Set #10, Line 30: enum sbcap_server_event {

    So we have the same set of events as in enum cbsp_server_event. Can both FSMs simply use a single unified set of events?

• File src/cbc_data.c:

  • Patch Set #10, Line 104:

    ws, 'unsigned int i' could be added here (scoped variable)

• File src/smscb_peer_fsm.c:

  • Patch Set #10, Line 483:

    cosmetic: there should be no space here

To view, visit change 28602. To unsubscribe, or for help writing mail filters, visit settings.