Attention is currently required from: lynxis lazus.

fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37903?usp=email )

Change subject: s2b: add PDN type to the create session request ......................................................................

Patch Set 1:

(3 comments)

File src/epdg_gtpc_s2b.erl:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37903/comment/4e76acab_26bcf... : PS1, Line 87: atom(). It's probably a good idea to define possible atom values here?

``` -type pdn_type() :: ipv4 | ipv6 | ipv4v6. ```

This allows dializer to catch typos in atoms.

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37903/comment/c8dd76a5_7f9e8... : PS1, Line 537: <<0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0>> Not critical, but you could do this as follows:

``` << 16#00:(8 * 4) >> %% for ipv4 << 16#00:(8 * 16) >> %% for ipv6 << 16#00:(8 * 20) >> %% for ipv4v6 ```

File src/epdg_ue_fsm.erl:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37903/comment/53e35966_d9707... : PS1, Line 70: atom(), You can export `-type pdn_type` from `epdg_gtpc_s2b.erl` and use it here.