Attention is currently required from: lynxis lazus.

View Change

3 comments:

• File src/epdg_gtpc_s2b.erl:

  • Patch Set #1, Line 87: atom().

    It's probably a good idea to define possible atom values here?

    ```
    -type pdn_type() :: ipv4 | ipv6 | ipv4v6.
    ```

    This allows dializer to catch typos in atoms.

  • Patch Set #1, Line 537: <<0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0>>

    Not critical, but you could do this as follows:

    ```
    << 16#00:(8 * 4) >> %% for ipv4
    << 16#00:(8 * 16) >> %% for ipv6
    << 16#00:(8 * 20) >> %% for ipv4v6
    ```

• File src/epdg_ue_fsm.erl:

  • Patch Set #1, Line 70: atom(),

    You can export `-type pdn_type` from `epdg_gtpc_s2b.erl` and use it here.

To view, visit change 37903. To unsubscribe, or for help writing mail filters, visit settings.