Attention is currently required from: fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31144 )

Change subject: pcu_sock: transfer E1 connection information to PCU ......................................................................

Patch Set 4:

(2 comments)

File src/osmo-bsc/pcu_sock.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/31144/comment/5b05ad66_54495d8e PS1, Line 315: struct gsm_bts_trx_ts *ts;

Thanks. I prefer to have everything at the top so I can immediately see what variables are present. […]

I agree with fixeria (and I also think it is long-established general practice in osmocom) to declare variables in the scope they're needed. So if some variable is only needed in a nested/inner scope, it should be declared in that scope only.

File src/osmo-bsc/pcu_sock.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/31144/comment/98bf4322_1a60fec7 PS4, Line 326: t for example ts should be declared here as it's only used inside the for-loop. likewise, msg, pcu_prim, e1_ccu_ind.