Attention is currently required from: fixeria, dexter.

View Change

2 comments:

• File src/osmo-bsc/pcu_sock.c:

  • Patch Set #1, Line 315: struct gsm_bts_trx_ts *ts;

    Thanks. I prefer to have everything at the top so I can immediately see what variables are present. […]

    I agree with fixeria (and I also think it is long-established general practice in osmocom) to declare variables in the scope they're needed. So if some variable is only needed in a nested/inner scope, it should be declared in that scope only.

• File src/osmo-bsc/pcu_sock.c:

  • Patch Set #4, Line 326: t

    for example ts should be declared here as it's only used inside the for-loop. likewise, msg, pcu_prim, e1_ccu_ind.

To view, visit change 31144. To unsubscribe, or for help writing mail filters, visit settings.