Attention is currently required from: arehbein.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31304 )

Change subject: Includes: Remove enum/include from libosmocore instead ......................................................................

Patch Set 6: Code-Review-1

(3 comments)

File include/osmocom/bsc/gsm_data.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/31304/comment/846e088c_d38df522 PS6, Line 657: uint16_t parameter[_NUM_NM_RLC_PAR_OFFSET]; why changing the name? I don't see the point in adding _OFFSET it just makes stuff larger with no benefit.

File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/31304/comment/f34edfb0_3eb0cb3a PS6, Line 173: for (offset = NM_RLC_T3142_OFFSET; offset <= NM_CV_COUNTDOWN_OFFSET; why not simply memcpy?

https://gerrit.osmocom.org/c/osmo-bsc/+/31304/comment/b7655540_ab4206c0 PS6, Line 174: ++offset) please don't use preincrement unless it really has a purpose over postincrement (code convention in all osmocom C code).