Attention is currently required from: arehbein.

Patch set 6:Code-Review -1

View Change

3 comments:

• File include/osmocom/bsc/gsm_data.h:

  • Patch Set #6, Line 657: uint16_t parameter[_NUM_NM_RLC_PAR_OFFSET];

    why changing the name? I don't see the point in adding _OFFSET it just makes stuff larger with no benefit.

• File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c:

  • Patch Set #6, Line 173: for (offset = NM_RLC_T3142_OFFSET; offset <= NM_CV_COUNTDOWN_OFFSET;

    why not simply memcpy?

  • Patch Set #6, Line 174: ++offset)

    please don't use preincrement unless it really has a purpose over postincrement (code convention in all osmocom C code).

To view, visit change 31304. To unsubscribe, or for help writing mail filters, visit settings.