Attention is currently required from: jolly.
laforge has posted comments on this change by jolly. (
https://gerrit.osmocom.org/c/libosmocore/+/40494?usp=email )
Change subject: Send multiple read/recvfrom/recvmsg SQEs in advance
......................................................................
Patch Set 10:
(2 comments)
File src/core/osmo_io_internal.h:
https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/d9e60010_b8a6584b?… :
PS10, Line 112: /* ! requested number of simultaniously submitted read SQEs */
simultaneously
https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/d2c6aa14_8c8e4989?… :
PS10, Line 116: /* ! current number of simultaniously submitted read SQEs */
same: simultaneously. Also: OTher comments above and elsewhere in omsocom use /*! with no
space between the asterisk and the exclamation mark. I'm not sure if it's relevant
to doxygen, but the easiest is usually to simply do it like the other code does, which
doesn't require testing and has no risk.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/40494?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id50a8900fa2fe6de553e5025feae7e1e8d501e30
Gerrit-Change-Number: 40494
Gerrit-PatchSet: 10
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Thu, 31 Jul 2025 13:04:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No