Attention is currently required from: fixeria, laforge, pespin.

jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34529?usp=email )

Change subject: ASCI: Prepare gsm48_rr_rx_acch for voice group channel ......................................................................

Patch Set 4:

(3 comments)

File src/host/layer23/src/mobile/gsm48_rr.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/34529/comment/a7dee417_af60de10 PS3, Line 4889: struct gsm48_system_information_type_header *sih; : struct gsm48_hdr_sh *sgh; : struct gsm48_hdr *gh;

all `const`?

Done

https://gerrit.osmocom.org/c/osmocom-bb/+/34529/comment/4a76a0c9_6487fd29 PS3, Line 4895: sgh = msgb_l3(msg);

do we want to check `if (msgb_l3len(msg) < sizeof(*sgh))` here?

No, the header is only one byte. There is already a length check for Bter frames which are 21 oe 23 bytes.

https://gerrit.osmocom.org/c/osmocom-bb/+/34529/comment/7ba57cdf_105be506 PS3, Line 4909: sih = msgb_l3(msg);

do we want to check `if (msgb_l3len(msg) < sizeof(*sih))` here?

No, similar as above. B4 frame length is already checked. The header is way smaller.