Attention is currently required from: fixeria, laforge, pespin.

View Change

3 comments:

• File src/host/layer23/src/mobile/gsm48_rr.c:

  • Patch Set #3, Line 4889:

    struct gsm48_system_information_type_header *sih;
    	struct gsm48_hdr_sh *sgh;
    	struct gsm48_hdr *gh;
    

    all `const`?

    Done

  • Patch Set #3, Line 4895: sgh = msgb_l3(msg);

    do we want to check `if (msgb_l3len(msg) < sizeof(*sgh))` here?

    No, the header is only one byte. There is already a length check for Bter frames which are 21 oe 23 bytes.

  • Patch Set #3, Line 4909: sih = msgb_l3(msg);

    do we want to check `if (msgb_l3len(msg) < sizeof(*sih))` here?

    No, similar as above. B4 frame length is already checked. The header is way smaller.

To view, visit change 34529. To unsubscribe, or for help writing mail filters, visit settings.