Attention is currently required from: daniel, fixeria, laforge, pespin.

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37868?usp=email )

Change subject: move gsm48_gmm_att_tlvdef into gprs_gmm_util ......................................................................

Patch Set 18:

(6 comments)

File include/osmocom/sgsn/gprs_gmm_util.h:

https://gerrit.osmocom.org/c/osmo-sgsn/+/37868/comment/a1839f7a_bcc5ee8a?usp... : PS15, Line 1: #ifndef _GPRS_GMM_UTIL_H

`#pragma once`

If this is a rule, we should add this to the checkpatch. I'm changing it to #pragma.

https://gerrit.osmocom.org/c/osmo-sgsn/+/37868/comment/34c42696_cfc012e0?usp... : PS15, Line 6: struct msgb;

Why adding it here?

it is a refactoring left over. the next commit is requiring it. I'll move this into the next commit.

https://gerrit.osmocom.org/c/osmo-sgsn/+/37868/comment/62a7eda5_b6a2c099?usp... : PS15, Line 6: struct msgb;

Why adding it here?

most likely because a commit later in this chain will

File src/sgsn/gprs_gmm_util.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/37868/comment/ffee5ea3_4f2869b7?usp... : PS15, Line 9: Author: Alexander Couzens lynxis@fe80.eu

`git-blame` tells me that Harald and Pau are the authors of code you're moving here.

Not sure if this is even be good enough for any copyright until I add more code to it. This is only simple tlv. @laforge@gnumonks.org what is the right solution here? What should I add here? How should the copyright look like?

https://gerrit.osmocom.org/c/osmo-sgsn/+/37868/comment/2d0004ec_a740b6ec?usp... : PS15, Line 9: Author: Alexander Couzens lynxis@fe80.eu

`git-blame` tells me that Harald and Pau are the authors of code you're moving here.

Yes you're right, but on the other side, I don't care.

I would argue here, this code isn't high enough to cover any copyright until I add more code in here from another commit.

https://gerrit.osmocom.org/c/osmo-sgsn/+/37868/comment/e64c3ce7_14b0b4fd?usp... : PS15, Line 25: #include <osmocom/gsm/gsm48.h>

Unneeded import?

Done