Attention is currently required from: daniel, fixeria, laforge, pespin.
6 comments:
File include/osmocom/sgsn/gprs_gmm_util.h:
Patch Set #15, Line 1: #ifndef _GPRS_GMM_UTIL_H
`#pragma once`
If this is a rule, we should add this to the checkpatch. I'm changing it to #pragma.
Patch Set #15, Line 6: struct msgb;
Why adding it here?
it is a refactoring left over. the next commit is requiring it. I'll move this into the next commit.
Patch Set #15, Line 6: struct msgb;
Why adding it here?
most likely because a commit later in this chain will
File src/sgsn/gprs_gmm_util.c:
Patch Set #15, Line 9: Author: Alexander Couzens <lynxis@fe80.eu>
`git-blame` tells me that Harald and Pau are the authors of code you're moving here.
Not sure if this is even be good enough for any copyright until I add more code to it. This is only simple tlv.
@laforge@gnumonks.org what is the right solution here? What should I add here? How should the copyright look like?
Patch Set #15, Line 9: Author: Alexander Couzens <lynxis@fe80.eu>
`git-blame` tells me that Harald and Pau are the authors of code you're moving here.
Yes you're right, but on the other side, I don't care.
I would argue here, this code isn't high enough to cover any copyright until I add more code in here from another commit.
Patch Set #15, Line 25: #include <osmocom/gsm/gsm48.h>
Unneeded import?
Done
To view, visit change 37868. To unsubscribe, or for help writing mail filters, visit settings.