Attention is currently required from: fixeria, pespin.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/34488?usp=email )
Change subject: ASCI: Add channel notification event to MM events
......................................................................
Patch Set 6:
(3 comments)
File src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/34488/comment/f13ac017_5b9da4a8
PS5, Line 170: uint8_t sres[4];
Looks like we want a `union` here.
Done
https://gerrit.osmocom.org/c/osmocom-bb/+/34488/comment/a25de2f9_0fe3052b
PS5, Line 171: struct {
Mention the related type somehow, example: […]
Done
https://gerrit.osmocom.org/c/osmocom-bb/+/34488/comment/c30035fe_3b62e9fc
PS5, Line 176: notification
btw, this struct is not going to be packed even though
it's defined in a packed struct. […]
Should all be packed, because it is
pushed/pulled to/from msg. See Change-Id: I6af7475c609b3293af708540d569fe1616fab43f
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/34488?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ifee286ba4628356cc19b5dc75f1843287c5d2342
Gerrit-Change-Number: 34488
Gerrit-PatchSet: 6
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 26 Sep 2023 10:26:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment