Attention is currently required from: fixeria, pespin.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34488?usp=email )
Change subject: ASCI: Add channel notification event to MM events ......................................................................
Patch Set 6:
(3 comments)
File src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/34488/comment/f13ac017_5b9da4a8 PS5, Line 170: uint8_t sres[4];
Looks like we want a `union` here.
Done
https://gerrit.osmocom.org/c/osmocom-bb/+/34488/comment/a25de2f9_0fe3052b PS5, Line 171: struct {
Mention the related type somehow, example: […]
Done
https://gerrit.osmocom.org/c/osmocom-bb/+/34488/comment/c30035fe_3b62e9fc PS5, Line 176: notification
btw, this struct is not going to be packed even though it's defined in a packed struct. […]
Should all be packed, because it is pushed/pulled to/from msg. See Change-Id: I6af7475c609b3293af708540d569fe1616fab43f
-
jolly