Attention is currently required from: fixeria, pespin.

View Change

3 comments:

• File src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h:

  • Patch Set #5, Line 170: uint8_t sres[4];

    Looks like we want a `union` here.

    Done

  • Patch Set #5, Line 171: struct {

    Mention the related type somehow, example: […]

    Done

  • Patch Set #5, Line 176: notification

    btw, this struct is not going to be packed even though it's defined in a packed struct. […]

    Should all be packed, because it is pushed/pulled to/from msg. See Change-Id: I6af7475c609b3293af708540d569fe1616fab43f

To view, visit change 34488. To unsubscribe, or for help writing mail filters, visit settings.